View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0026838||mantisbt||bugtracker||public||2020-04-01 10:13||2020-05-03 04:34|
|Target Version||2.24.1||Fixed in Version||2.24.1|
|Summary||0026838: OS build field not filled in viewing mode|
"OS build" field is not filled in viewing mode. in update mode it is OK
|Steps To Reproduce|
Report a new issue with a value in the field "OS buid" and then click on the issue.
I think the problem is in the "bug_view_inc.php" file .
at line 450 : echo '<td class="bug-os-version">', string_display_line( $t_issue['os_version'] ), '</td>';
It should be : echo '<td class="bug-os-version">', string_display_line( $t_issue['os_build'] ), '</td>';
|Tags||No tags attached.|
|related to||0025902||closed||vboctor||Implement IssueViewPageCommand to separate logic from rendering of issue view page|
|related to||0026840||resolved||atrol||Non existing field name os_version used where os_build should be used|
|related to||0026921||closed||atrol||View Issue page does not show "Product Build" (wrong key names in code)|
Regression introduced in 2.23.0
While checking this, I found that there are some more places where
@atrol Is this really the correct way to fix it? From my limited understanding there are internal variable names (like os_build) and variable names that are used in configuration files (which are close to the user interface, so that someone configuring mantis only needs to know the GUI names, but not the internal names). I don't know what side effects changing names has for example for existing filters.
I think, it would be more consistant to change only bug_view_inc.php $t_issue['os_version'] --> $t_issue['os_build'], but leave config_defaults.php and IssueCommand as they are, as config files should use the GUI names.
There are a number of other cases, where the $t_issue-name does not match the config field names. This is not nice, but at least, it would be consistant.
MantisBT: master-2.24 76fa47a8
2020-04-01 14:45:28Details Diff
|Fix regression no display of OS Version field on View Issue Details page
|mod - bug_view_inc.php||Diff File|
|mod - config_defaults_inc.php||Diff File|
|mod - core/commands/IssueViewPageCommand.php||Diff File|