0026921: View Issue page does not show "Product Build" (wrong key names in code) - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0026921	mantisbt	bugtracker	public	2020-04-28 04:34	2020-05-03 04:34

Reporter	polzin	Assigned To	atrol
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	2.23.0
Target Version	2.24.1	Fixed in Version	2.24.1

Summary	0026921: View Issue page does not show "Product Build" (wrong key names in code)
Description	"Product Build" are only shown on bug_report and bug_update, but not on view. (if $g_enable_product_build = ON) The reason are wrong key names in bug_view_inc.php The right field for Product Build is 'build' not 'product_build'. See attached patch.
Additional Information	@@ -480,7 +480,7 @@ if( ( $t_flags['profiles_platform_show'] && isset( $t_issue['platform'] ) && !is # if( ( $t_flags['versions_product_version_show'] && isset( $t_issue['version'] ) ) \|\| - ( $t_flags['versions_product_build_show'] && isset( $t_issue['product_build'] ) ) ) { + ( $t_flags['versions_product_build_show'] && isset( $t_issue['build'] ) ) ) { $t_spacer = 2; echo '<tr>'; @@ -494,9 +494,9 @@ if( ( $t_flags['versions_product_version_show'] && isset( $t_issue['version'] ) } # Product Build - if( $t_flags['versions_product_build_show'] && isset( $t_issue['product_build'] ) ) { + if( $t_flags['versions_product_build_show'] && isset( $t_issue['build'] ) ) { echo '<th class="bug-product-build category">', lang_get( 'product_build' ), '</th>'; - echo '<td class="bug-product-build">', string_display_line( $t_issue['product_build'] ), '</td>'; + echo '<td class="bug-product-build">', string_display_line( $t_issue['build'] ), '</td>'; } else { $t_spacer += 2; }
Tags	No tags attached.

polzin 2020-04-28 04:34 reporter ~0063923	@atrol This is a related bug to 0026838

polzin 2020-04-28 04:43 reporter ~0063925	I am sorry, the patch file in additional information got corrupted with the markup and I cannot change it.

atrol 2020-04-29 15:03 developer ~0063930	Regression introduced in 2.23.0

atrol 2020-04-29 16:07 developer ~0063932 Last edited: 2020-04-29 16:10	The issue is similar to what we had with `os_version` vs. `os_build` The name of the field in settings like `$g_bug_view_page_fields` is `product_build` The name of the field on `Manage Columns` pages is `build`

polzin 2020-04-29 17:04 reporter ~0063935	Same for product_version and version. As this field is more important thant the others, it might be sensible to check, if harmoizing breaks existing configurations or filters.

atrol 2020-05-01 15:40 developer ~0063943	PR https://github.com/mantisbt/mantisbt/pull/1665

atrol 2020-05-01 15:59 developer ~0063944 Last edited: 2020-05-01 22:30	it might be sensible to check, if harmoizing breaks existing configurations or filters. @polzin, right harmonizing would break. Not sure you noticed that I introduced a check in admin checks when harmonizing `os_version` and `os_build`. Admins are told to run admin/check/index.php after upgrade, so they will get a warning.