View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0025902||mantisbt||api rest||public||2019-07-04 15:55||2019-09-11 07:11|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||2.23.0||Fixed in Version||2.23.0|
|Summary||0025902: Implement IssueViewPageCommand to separate logic from rendering of issue view page|
|Tags||No tags attached.|
|related to||0026094||resolved||dregad||PHP notice in bug view page when viewing issue without category|
|related to||0026123||resolved||dregad||Both "monitor" and "end monitoring" buttons are displayed|
|related to||0026125||resolved||dregad||"Users monitoring this issue" section not shown if nobody is monitoring the issue|
How will this leverage current events for rendering custom content from plugins?
I use, as an example, several of those events:
Here is the link to the PR:
The EVENT_MENU_ISSUE is triggered via the command and the result is returned. The good thing about this event is that it returns logical menu option representation (i.e. a model rather than a view). It is up to the view to render this based on the UI template.
However, as you mentioned we have other events that output HTML. At this point the command doesn't return these and they are encoded directly into the view page (
The above applies for all types of extensions. They will continue to run in the web UI with the above limitations and will be part of the view page and not the IssueVIewCommand. I think we need a logical way to add extra fields to an issue, extra actions, etc.
For extra activities, it may make sense to question whether they should be part of the issue view or part of the issue itself (similar to custom fields).
This change doesn't limit what we can do, but highlights areas where we can do better with our extensibility model.
MantisBT: master 08abf7f4
2019-07-05 22:22:39Details Diff
|Control showing of action buttons via flags
Remove logic in issue view page to decide showing buttons and depend on flags from issue view command.
|mod - bug_view_inc.php||Diff File|
|mod - core/commands/IssueViewCommand.php||Diff File|
|2019-07-04 15:55||vboctor||New Issue|
|2019-07-04 15:55||vboctor||Status||new => assigned|
|2019-07-04 15:55||vboctor||Assigned To||=> vboctor|
|2019-07-04 18:45||cproensa||Note Added: 0062355|
|2019-07-04 20:17||vboctor||Note Added: 0062356|
|2019-08-25 13:01||vboctor||Status||assigned => resolved|
|2019-08-25 13:01||vboctor||Resolution||open => fixed|
|2019-08-25 13:01||vboctor||Fixed in Version||=> 2.23.0|
|2019-08-25 13:01||vboctor||Target Version||=> 2.23.0|
|2019-08-25 16:37||vboctor||Summary||Implement IssueViewCommand to make to separate logic from rendering of issue view page => Implement IssueViewPageCommand to separate logic from rendering of issue view page|
|2019-08-28 19:07||dregad||Relationship added||related to 0026094|
|2019-09-10 06:12||dregad||Relationship added||related to 0026123|
|2019-09-10 06:21||dregad||Changeset attached||=> MantisBT master 08abf7f4|
|2019-09-11 07:11||dregad||Relationship added||related to 0026125|