Source Control Integration

master 2b13777c 2020-04-25 09:30 dregad Details Diff	KEYS.md: add former developers' PGP keys Added the public keys used by former developers jreese and dhx to sign release tags, as well as an old key of vboctor. Issue 0022269 For future reference, here are the steps and commands used to automate the process of identifying the missing keys and adding them, as I really didn't want to manually check all 182 tags in he repository. 1. Find all annotated tags ``` git for-each-ref --format="%(objecttype) %(refname:short)" refs/tags \| grep ^tag \|cut -d" " -f2\| sort -V >/tmp/annotated-tags ``` 2. Get all signed tags (removing annotated tags without signature), with GPG verification data on a single line ``` cat /tmp/annotated-tags \| xargs -n1 -I TAG bash -c 'echo "TAG $(git verify-tag TAG \|& paste -s)"' \| grep -v "error: no signature found" >/tmp/signed-tags-data ``` 3. Identify the missing keys from the tags for which the signature could not be checked (i.e. excluding those for which we already have a public key). The command prints the number of identified keys. ``` cat /tmp/signed-tags-data \| sed -rn "/gpg: Can't check signature/s/^.using \w+ key (\w+).$/\1/p" \| sort -u \|tee /tmp/missing-keys \|wc -l ``` 4. Retrieve the missing keys from keyserver. The command should import the same number of keys as identified at step 3. ``` cat /tmp/missing-keys \|cut -d" " -f1 \|xargs gpg --receive-keys ``` 5. Review, sign and trust the newly added keys. ``` cat /tmp/missing-keys \|cut -d" " -f1 \|xargs -n1 gpg --sign-key ``` 6. Verify that we have successfully added all the necessary keys: the following command should return an empty list. ``` cat /tmp/signed-tags-data \|cut -d" " -f1 \| xargs -n1 -I TAG bash -c 'echo "TAG $(git verify-tag TAG \|& paste -s)"' \| grep -v "Good signature" ```	Affected Issues 0022269
	mod - KEYS.md	Diff File
master ab440b19 2020-04-25 08:55 dregad Details Diff	Add KEYS.md: PGP public keys used to sign releases The files contains basic instructions and lists the PGP public keys of MantisBT Developers, which were used to sign official release packages and the corresponding tags in the Git repository. Issue 0022269	Affected Issues 0022269
	add - KEYS.md	Diff File
master 99a5925e 2020-04-21 10:29 vboctor Details Diff	Bring in release scripts from mantisbt-tools We had our build tools split between MantisBT main repo and mantisbt-tools repo. It is a better approach to have the scripts in the main repo, so each MantisBT branch can have the corresponding version of the build scripts that works with it. Also it makes it easier to keep the build scripts up-to-date as the MantisBT core code changes. The code here is exactly the same as the following commit in `mantisbt/mantisbt-tools`: https://github.com/mantisbt/mantisbt-tools/commit/549d14d5680c6104f958507e0b771d87e4d81af7 Fixes 0026903	Affected Issues 0026903
	add - build-scripts/.htaccess	Diff File
	add - build-scripts/Web.config	Diff File
	add - build-scripts/buildrelease-repo.py	Diff File
	add - build-scripts/buildrelease.py	Diff File
	add - build-scripts/check_apostrophe.php	Diff File
	add - build-scripts/check_formatting.php	Diff File
	add - build-scripts/check_lang.php	Diff File
	add - build-scripts/check_lineterm.php	Diff File
	add - build-scripts/docbook-manual-repo.py	Diff File
	add - build-scripts/docbook-manual.py	Diff File
	add - build-scripts/update-copyright.sh	Diff File
	add - build-scripts/update-credits.sh	Diff File
master 70fa6aaf 2020-04-20 13:02 dregad Details Diff	Rename status message language strings
	mod - core/classes/InvalidDefinitionPlugin.class.php	Diff File
	mod - core/classes/MissingClassPlugin.class.php	Diff File
	mod - core/classes/MissingPlugin.class.php	Diff File
	mod - lang/strings_english.txt	Diff File
master c31e56cd 2020-04-20 13:00 dregad Details Diff	Tweak invalid plugin status message strings
	mod - lang/strings_english.txt	Diff File
master 84dcd811 2020-04-20 12:59 dregad Details Diff	Add status message for MissingPlugin class
	mod - admin/check/check_plugins_inc.php	Diff File
	mod - core/classes/MissingPlugin.class.php	Diff File
	mod - lang/strings_english.txt	Diff File
master 1cc269b5 2020-04-20 12:57 dregad Details Diff	Refactor following PR review Based on @cproensa's suggestion, see https://github.com/mantisbt/mantisbt/pull/1565#discussion_r329311690 Invalid Plugin classes changes: - Define a new InvalidDefinitionPlugin class for the case of missing required properties (name and version) - InvalidPlugin becomes a generic, base class for invalid plugins - Initialize with InvalidPlugin::setInvalidPlugin() method MantisPlugin base class changes: - New properties $status (with related STATUS_xxx constants) and $status_message to MantisPlugin class - Method isValid() returns a loaded plugin's actual validity status - Method getInvalidPlugin() creates an InvalidPlugin object from the current plugin and initializes it with setInvalidPlugin(). Plugin API, management and admin checks page have been modified to leverage the new class, properties and methods.
	mod - admin/check/check_plugins_inc.php	Diff File
	add - core/classes/InvalidDefinitionPlugin.class.php	Diff File
	mod - core/classes/InvalidPlugin.class.php	Diff File
	mod - core/classes/MantisPlugin.class.php	Diff File
	mod - core/classes/MissingClassPlugin.class.php	Diff File
	mod - core/classes/MissingPlugin.class.php	Diff File
	mod - core/plugin_api.php	Diff File
	mod - manage_plugin_page.php	Diff File
	mod - manage_plugin_uninstall.php	Diff File
	mod - manage_plugin_upgrade.php	Diff File
master a0b18ec6 2020-04-20 12:32 dregad Details Diff	Split plugin_missing_class_description string One string for the actual description, and another for detailed info.
	mod - core/classes/MissingClassPlugin.class.php	Diff File
	mod - lang/strings_english.txt	Diff File
master c7f1c919 2020-04-20 06:56 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_persian.txt	Diff File
	add - plugins/Gravatar/lang/strings_persian.txt	Diff File
master c2da45c9 2020-04-19 22:40 dependabot-preview[bot] Committer: vboctor Details Diff	Bump guzzlehttp/guzzle from 6.5.2 to 6.5.3 Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/guzzle/guzzle/releases) - [Changelog](https://github.com/guzzle/guzzle/blob/6.5.3/CHANGELOG.md) - [Commits](https://github.com/guzzle/guzzle/compare/6.5.2...6.5.3) Fixes 0026919 Signed-off-by: dependabot-preview[bot] <support@dependabot.com>	Affected Issues 0026919
	mod - composer.lock	Diff File
dependabot/composer/guzzlehttp/guzzle-6.5.3 f84612c8 2020-04-19 22:40 dependabot-preview[bot] Committer: community Details Diff	Bump guzzlehttp/guzzle from 6.5.2 to 6.5.3 Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/guzzle/guzzle/releases) - [Changelog](https://github.com/guzzle/guzzle/blob/6.5.3/CHANGELOG.md) - [Commits](https://github.com/guzzle/guzzle/compare/6.5.2...6.5.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
	mod - composer.lock	Diff File
master 4b436c4c 2020-04-19 13:36 vboctor Details Diff	Fix attachments API access checks - Fix attachment access checks for private attachments. (REST and SOAP) - Include note attachments within notes (REST) Fixes 0026893	Affected Issues 0026893
	mod - api/soap/mc_issue_api.php	Diff File
	mod - core/file_api.php	Diff File
master-2.24 f1f236f9 2020-04-19 13:36 vboctor Details Diff	Fix attachments API access checks - Fix attachment access checks for private attachments. (REST and SOAP) - Include note attachments within notes (REST) Fixes 0026893	Affected Issues 0026893
	mod - api/soap/mc_issue_api.php	Diff File
	mod - core/file_api.php	Diff File
master 1dea5adc 2020-04-19 09:36 atrol Details Diff	Add attachment settings to "Workflow Thresholds" page Fixes 0026892	Affected Issues 0026892
	mod - manage_config_work_threshold_page.php	Diff File
	mod - manage_config_work_threshold_set.php	Diff File
master d616c2e8 2020-04-19 03:06 dregad Details Diff	Display MissingClassPlugin as warning in checks Issue a warning instead of a failure, to cover the case of a directory created under plugins/ for other purposes than storing a plugin, as suggested by @cproensa in the PR [[1]]. Code was refactored as a switch statement to make it easier to identify and differentiate the various cases. [1]: https://github.com/mantisbt/mantisbt/pull/1565#discussion_r329311260
	mod - admin/check/check_plugins_inc.php	Diff File
master d4564e65 2020-04-19 02:58 dregad Details Diff	Added admin checks for plugins Fixes 0026143	Affected Issues 0026143
	add - admin/check/check_plugins_inc.php	Diff File
	mod - admin/check/index.php	Diff File
master 1523f6d3 2020-04-18 12:32 vboctor Details Diff	Implement `ConfigsGetCommand` Fixes 0026889 Signed-off-by: Victor Boctor <victor@mantishub.net>	Affected Issues 0026889
	mod - api/rest/restcore/config_rest.php	Diff File
	add - core/commands/ConfigsGetCommand.php	Diff File
master e87fcc40 2020-04-18 12:25 vboctor Details Diff	Implement `LocalizedStringsGetCommand` Fixes 0026890 Signed-off-by: Victor Boctor <victor@mantishub.net>	Affected Issues 0026890
	mod - api/rest/restcore/lang_rest.php	Diff File
	add - core/commands/LocalizedStringsGetCommand.php	Diff File
master 29e0d6db 2020-04-18 12:20 vboctor Details Diff	Config API falsely reports users as not found Fixes 0026891 Signed-off-by: Victor Boctor <victor@mantishub.net>	Affected Issues 0026891
	mod - api/rest/restcore/config_rest.php	Diff File
master 950cebcc 2020-04-18 02:44 dregad Details Diff	Improve markup formatting Add some newlines to make the generated HTML easier to read.
	mod - core/html_api.php	Diff File
	mod - core/layout_api.php	Diff File
master edb40eab 2020-04-18 02:41 dregad Details Diff	Function to display formatted project selection links New project_link_for_menu() function added to Project API, to avoid code duplication when displaying project selection links in the navbar menu and the project menu bar. Handles the indentation logic based on the subproject's level in the hierarchy, selection of the active project as well as context-specific formatting ($p_class parameter). Fixes 0026887, 0026888	Affected Issues 0026887, 0026888
	mod - core/html_api.php	Diff File
	mod - core/layout_api.php	Diff File
	mod - core/project_api.php	Diff File
master 7554f413 2020-04-16 07:10 translatewiki.net Details Diff	Localisation updates from https://translatewiki.net.
	mod - lang/strings_afrikaans.txt	Diff File
	mod - lang/strings_arabic.txt	Diff File
	mod - lang/strings_arabicegyptianspoken.txt	Diff File
	mod - lang/strings_asturian.txt	Diff File
	mod - lang/strings_basque.txt	Diff File
	mod - lang/strings_belarusian_tarask.txt	Diff File
	mod - lang/strings_breton.txt	Diff File
	mod - lang/strings_bulgarian.txt	Diff File
	mod - lang/strings_catalan.txt	Diff File
	mod - lang/strings_chinese_simplified.txt	Diff File
	mod - lang/strings_chinese_traditional.txt	Diff File
	mod - lang/strings_croatian.txt	Diff File
	mod - lang/strings_czech.txt	Diff File
	mod - lang/strings_danish.txt	Diff File
	mod - lang/strings_dutch.txt	Diff File
	mod - lang/strings_eo.txt	Diff File
	mod - lang/strings_estonian.txt	Diff File
	mod - lang/strings_finnish.txt	Diff File
	mod - lang/strings_french.txt	Diff File
	mod - lang/strings_galician.txt	Diff File
	mod - lang/strings_georgian.txt	Diff File
	mod - lang/strings_german.txt	Diff File
	mod - lang/strings_greek.txt	Diff File
	mod - lang/strings_hebrew.txt	Diff File
	mod - lang/strings_hungarian.txt	Diff File
	mod - lang/strings_icelandic.txt	Diff File
	mod - lang/strings_interlingua.txt	Diff File
	mod - lang/strings_italian.txt	Diff File
	mod - lang/strings_japanese.txt	Diff File
	mod - lang/strings_korean.txt	Diff File
	mod - lang/strings_latvian.txt	Diff File
	mod - lang/strings_lithuanian.txt	Diff File
	mod - lang/strings_macedonian.txt	Diff File
	mod - lang/strings_norwegian_bokmal.txt	Diff File
	mod - lang/strings_norwegian_nynorsk.txt	Diff File
	mod - lang/strings_occitan.txt	Diff File
	mod - lang/strings_persian.txt	Diff File
	mod - lang/strings_polish.txt	Diff File
	mod - lang/strings_portuguese_brazil.txt	Diff File
	mod - lang/strings_portuguese_standard.txt	Diff File
	mod - lang/strings_qqq.txt	Diff File
	mod - lang/strings_ripoarisch.txt	Diff File
	mod - lang/strings_romanian.txt	Diff File
	mod - lang/strings_russian.txt	Diff File
	mod - lang/strings_serbian.txt	Diff File
	mod - lang/strings_serbian_latin.txt	Diff File
	mod - lang/strings_slovak.txt	Diff File
	mod - lang/strings_slovene.txt	Diff File
	mod - lang/strings_spanish.txt	Diff File
	mod - lang/strings_swedish.txt	Diff File
	mod - lang/strings_swissgerman.txt	Diff File
	mod - lang/strings_tagalog.txt	Diff File
	mod - lang/strings_turkish.txt	Diff File
	mod - lang/strings_ukrainian.txt	Diff File
	mod - lang/strings_urdu.txt	Diff File
	mod - lang/strings_vietnamese.txt	Diff File
	mod - lang/strings_zazaki.txt	Diff File
	mod - plugins/MantisGraph/lang/strings_german.txt	Diff File
master-2.24 6210c647 2020-04-15 16:13 dregad Details Diff	REST API password reset for protected user now fails The endpoint now returns a 403 status code if the user is protected. Fixes 0026885	Affected Issues 0026885
	mod - api/rest/restcore/users_rest.php	Diff File
master e118e8e8 2020-04-15 15:36 dregad Details Diff	Specific notification for password reset by admin The email notification sent when password is reset by an administrator was misleading, implying that it can be ignored when in fact it should not as the password has effectively been changed to a random one. If the user does not reset their password, they will not be able to login. This commit avoids confusion caused by the misleading message, by sending a specific notification for password resets by admin. A new $p_reset_by_admin optional parameter, defaulting to false, was added to email_send_confirm_hash_url() function, allowing it to be used for resets by user (lost password feature) also. Fixes 0026884	Affected Issues 0026884
	mod - core/email_api.php	Diff File
	mod - core/user_api.php	Diff File
	mod - lang/strings_english.txt	Diff File
master-2.24 2c237c4e 2020-04-15 07:59 dregad Details Diff	UserResetPasswordCommand now returns status code The introduction of the command (see issue 0026632) broke the password reset from the GUI (manage_user_reset.php), as some variables used in the program were no longer initialized. As a result, it could only unlock the account (i.e. reset the failed login count). This commit changes the Command's process() method to return a status code (RESET, UNLOCK or FAILURE, defined as class constants), which can then be used by manage_user_reset.php to display an appropriate message. Fixes 0026880	Affected Issues 0026632, 0026880
	mod - core/commands/UserResetPasswordCommand.php	Diff File
	mod - manage_user_reset.php	Diff File

Changesets: MantisBT