Changesets: MantisBT
|
master a0c0645a 2015-11-10 10:21 Details Diff |
Remove unused parameter $p_user_id from function string_get_bug_view_link | ||
| mod - core/print_api.php | Diff File | ||
| mod - core/string_api.php | Diff File | ||
|
master c4724f65 2015-11-10 10:10 Details Diff |
Remove unused parameter $p_user_id from function string_get_bug_page | ||
| mod - core/string_api.php | Diff File | ||
|
master 38474adc 2015-11-10 09:58 Details Diff |
Remove unused parameter $p_password from function email_signup | ||
| mod - core/email_api.php | Diff File | ||
| mod - core/user_api.php | Diff File | ||
|
master 8cec63bf 2015-11-10 09:53 Details Diff |
Remove unused local variables | ||
| mod - api/soap/mc_filter_api.php | Diff File | ||
| mod - api/soap/mc_issue_api.php | Diff File | ||
| mod - api/soap/mc_project_api.php | Diff File | ||
| mod - core/bug_group_action_api.php | Diff File | ||
| mod - core/file_api.php | Diff File | ||
|
master fddd8313 2015-11-10 09:20 Details Diff |
Correct wrong call of function mci_issue_data_as_header_array | ||
| mod - api/soap/mc_issue_api.php | Diff File | ||
|
master 455c4993 2015-11-08 13:06 Details Diff |
Add filename + line number info to inline errors Fixes 0020554 |
Affected Issues 0020554 |
|
| mod - core/error_api.php | Diff File | ||
|
master 7f997e87 2015-11-05 10:03 Committer: dregad Details Diff |
Cache reporter user data in view_all_bug_page Add the reporter id to the array of users to be cached from the bug filter result. This saves later individual sql queries from user_cache_row() Changed the temporary arrays to be associative indexed by id, so we don't need to call 'array_unqiue' later. Fixes 0020258 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0020258 |
|
| mod - view_all_bug_page.php | Diff File | ||
|
master f82565ae 2015-11-04 11:52 Committer: dregad Details Diff |
Dont use token for manage_proj_edit_page The destination page does not verify form tokens, so call print_button() with the token parameter OFF. Issue 0020242 |
Affected Issues 0020242 |
|
| mod - manage_proj_edit_page.php | Diff File | ||
|
master c596d45b 2015-11-04 11:39 Committer: dregad Details Diff |
Dont create multiple tokens for buttons Call print_button() with a previously created token which is reutilized for all buttons. Previously, for each button a new token was created, which is a expensive operation that read/writes session variables repeated times. Issue 0020242 |
Affected Issues 0020242 |
|
| mod - manage_proj_edit_page.php | Diff File | ||
|
master b499d5c8 2015-11-04 10:24 Committer: dregad Details Diff |
Remove call to project_includes_user project_includes_user() is called once for every user that is displayed in project manage page, to check if user is directly assigned to the project and print the "remove" button. This function performs a db query for each user, which degrades performance as user count grows, and is especilally severe on public projects. Instead, fetch all local user at once and compare against the saved array if user is directly assigned to the project. Fixes 0020242 |
Affected Issues 0020242 |
|
| mod - manage_proj_edit_page.php | Diff File | ||
|
master 9eb915c3 2015-11-03 13:48 Committer: dregad Details Diff |
Check workflow prior to reopening bug Add a check to access_can_reopen_bug() to ensure the reopen status is reachable by the current workflow configuration. If not, return false. Previously, the reopen operation would fail anyway when the status is changed. With this early check, failure is detected before the action is made. A direct benefit from this is that the "reopen" button is not shown to the user if the action is not possible. Fixes 0020256 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0020256 |
|
| mod - core/access_api.php | Diff File | ||
|
master 557c1d76 2015-11-03 10:51 Details Diff |
remove unused parameters in string_get_bugnote_view_url_with_fqdn call | ||
| mod - core/string_api.php | Diff File | ||
|
master 8ea40421 2015-11-03 10:50 Details Diff |
remove unused parameters in string_get_bug_view_url_with_fqdn calls | ||
| mod - core/email_api.php | Diff File | ||
| mod - core/string_api.php | Diff File | ||
|
master ffd78e0a 2015-11-03 10:42 Details Diff |
Remove unused parameter $p_user_id | ||
| mod - core/string_api.php | Diff File | ||
|
master 7c7fa974 2015-11-03 10:34 Details Diff |
Correct wrong call of function print_info_row | ||
| mod - admin/index.php | Diff File | ||
|
master 14bf1e9c 2015-11-03 10:31 Details Diff |
Remove unused parameters in email_generic_to_recipients calls | ||
| mod - core/email_api.php | Diff File | ||
|
master 1f53923b 2015-11-03 10:27 Details Diff |
Remove unused parameters in plugin_pop_current calls | ||
| mod - core/plugin_api.php | Diff File | ||
|
master 878db3d0 2015-11-03 10:21 Details Diff |
Remove unused parameters in string_get_bugnote_view_url calls | ||
| mod - core/string_api.php | Diff File | ||
|
master cd340536 2015-11-03 10:16 Details Diff |
Remove unused parameters in string_get_bug_view_url calls | ||
| mod - core/print_api.php | Diff File | ||
| mod - core/string_api.php | Diff File | ||
|
master 576fd772 2015-11-03 09:24 Committer: dregad Details Diff |
Fix resetting of access level when updating workflow This is the same fix as 63bbb19393c3a2b9bdc7e159992c160561a7ce09, and addresses the incorrect behavior for the fields - Who can change workflow - Who can change access levels by applying the same mechanism used to detect a change in the status to the access level, i.e. comparing the updated access level with the parent and not the current value. Fixes 0016771 Signed-off-by: Damien Regad <dregad@mantisbt.org> Original commit message reworded |
Affected Issues 0016771 |
|
| mod - manage_config_workflow_set.php | Diff File | ||
|
master b649c9c9 2015-11-03 03:23 Details Diff |
Fix 0017870: XSS in adm_config_report.php This is the *real* correct fix for this issue (i.e. using string_attribute() to escape the variable), which was supposed to have been fixed in commit 1a49a780a7881b6eb7a2384a432db072a5c6db79. Unfortunately, for some reason I somehow ended up redoing the same mistake of using string_display_line() again instead (see original fix b509ab380f91e84d9683dbfdb02206b88a9b86fb, reverted in b02557d88a2094330249dc06c2990184d2696372). It is worth mentioning that string_display_line() *does* protect against the XSS attack vector, provided that the relevant MantisBT Formatting plugin configuration (text processing) is set to ON. Thanks to Patrice Morineau for pointing this out. |
Affected Issues 0017870 |
|
| mod - adm_config_report.php | Diff File | ||
|
master 3f093388 2015-11-01 14:03 Details Diff |
Adjust CSS / HTML of Workflow Transitions page A few minor adjustments to improve page layout - new CSS class (.form-container .footer), similar to .submit-button but without centered text - use <h2> tag for section titles instead of a table row - move "who can change" selects within the corresponding sections - display form submit button centered - delete button within a section of its own Note: the 2 buttons are not displayed within a single section because it would generate invalid HTML (closing the main form within an open div or require nested forms). |
||
| mod - css/default.css | Diff File | ||
| mod - manage_config_workflow_page.php | Diff File | ||
|
master c5e99534 2015-11-01 11:59 Committer: dregad Details Diff |
CSS add outline to field-container div Added the property 'outline' to the field-container div class. Seems like it has a more consistent rendering than margins or borders defined at 1px. Keep the previous definition of margin 1px as fallback for old browsers. Fixes 0017816 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0017816 |
|
| mod - css/default.css | Diff File | ||
|
master 979be2df 2015-11-01 00:25 Details Diff |
Refactor set_overrides() function The code now properly detects project vs global overrides, which prevents unnecessary display of the 'Delete' button when editing workflow for a project which only has overrides at the global level. Two parameters have been added, which allow moving the logic to detect whether an override is applied within the function, reducing code duplication. Fixes 0006847 |
Affected Issues 0006847 |
|
| mod - manage_config_workflow_page.php | Diff File | ||
|
master 0fce5e95 2015-10-31 23:46 Details Diff |
Define constants for color overrides class names | ||
| mod - manage_config_workflow_page.php | Diff File | ||
