| Attached Files |
roadmapbypriority.diff (1,121 bytes)
commit 08ab8233e2dcae790f8bb5244a2ea8e5ab4af2bb
Author: Matt Williams <matt@miliams.com>
Date: Tue Mar 31 17:09:58 2009 +0100
Order items by priority on the roadmap page.
It now sorts by status, then priority then by last_updated
Signed-off-by: Matt Williams <matt@miliams.com>
diff --git a/roadmap_page.php b/roadmap_page.php
index 3b82400..979a6e7 100644
--- a/roadmap_page.php
+++ b/roadmap_page.php
@@ -168,7 +168,7 @@
$query = "SELECT sbt.*, $t_relation_table.source_bug_id, dbt.target_version as parent_version FROM $t_bug_table AS sbt
LEFT JOIN $t_relation_table ON sbt.id=$t_relation_table.destination_bug_id AND $t_relation_table.relationship_type=2
LEFT JOIN $t_bug_table AS dbt ON dbt.id=$t_relation_table.source_bug_id
- WHERE sbt.project_id=" . db_param() . " AND sbt.target_version=" . db_param() . " ORDER BY sbt.status ASC, sbt.last_updated DESC";
+ WHERE sbt.project_id=" . db_param() . " AND sbt.target_version=" . db_param() . " ORDER BY sbt.status ASC, sbt.priority DESC, sbt.last_updated DESC";
$t_description = $t_version_row['description'];
bug8949.patch (1,819 bytes)
From 573ab37ebf09b6f87a5caf76d9d1bf47a376b1be Mon Sep 17 00:00:00 2001
From: Brian Wrightson <brian.wrightson@gmail.com>
Date: Thu, 2 Apr 2009 00:19:54 -0400
Subject: [PATCH] Fix #8949: Some formatting tweaks for the Roadmap
I used the sort that @milliams posted and added a bold header at the top of each Priority section.
---
roadmap_page.php | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/roadmap_page.php b/roadmap_page.php
index 7e050db..5731148 100644
--- a/roadmap_page.php
+++ b/roadmap_page.php
@@ -106,7 +106,7 @@
$query = "SELECT sbt.*, $t_relation_table.source_bug_id, dbt.target_version as parent_version FROM $t_bug_table AS sbt
LEFT JOIN $t_relation_table ON sbt.id=$t_relation_table.destination_bug_id AND $t_relation_table.relationship_type=2
LEFT JOIN $t_bug_table AS dbt ON dbt.id=$t_relation_table.source_bug_id
- WHERE sbt.project_id='$c_project_id' AND sbt.target_version='$c_version' ORDER BY sbt.status ASC, sbt.last_updated DESC";
+ WHERE sbt.project_id='$c_project_id' AND sbt.target_version='$c_version' ORDER BY sbt.status ASC, sbt.priority DESC, sbt.last_updated DESC";
$t_description = $t_version_row['description'];
@@ -235,7 +235,15 @@
for ( $j = 0; $j < count( $t_issue_set_ids ); $j++ ) {
$t_issue_set_id = $t_issue_set_ids[$j];
$t_issue_set_level = $t_issue_set_levels[$j];
-
+
+ $t_bug = bug_get( $t_issue_set_id );
+
+ if ( $t_bug->priority != $t_priority
+ && $t_bug->status < $t_resolved ) {
+ echo '<b> ', strtoupper( get_enum_element( 'priority', $t_bug->priority ) ), '</b><br />';
+ $t_priority = $t_bug->priority;
+ }
+
helper_call_custom_function( 'roadmap_print_issue', array( $t_issue_set_id, $t_issue_set_level ) );
}
--
1.6.1
bug8949_UPDATE.patch (3,050 bytes)
From 573ab37ebf09b6f87a5caf76d9d1bf47a376b1be Mon Sep 17 00:00:00 2001
From: Brian Wrightson <brian.wrightson@gmail.com>
Date: Thu, 2 Apr 2009 00:19:54 -0400
Subject: [PATCH 1/2] Fix #8949: Some formatting tweaks for the Roadmap
I used the sort that @milliams posted and added a bold header at the top of each Priority section.
---
roadmap_page.php | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/roadmap_page.php b/roadmap_page.php
index 7e050db..5731148 100644
--- a/roadmap_page.php
+++ b/roadmap_page.php
@@ -106,7 +106,7 @@
$query = "SELECT sbt.*, $t_relation_table.source_bug_id, dbt.target_version as parent_version FROM $t_bug_table AS sbt
LEFT JOIN $t_relation_table ON sbt.id=$t_relation_table.destination_bug_id AND $t_relation_table.relationship_type=2
LEFT JOIN $t_bug_table AS dbt ON dbt.id=$t_relation_table.source_bug_id
- WHERE sbt.project_id='$c_project_id' AND sbt.target_version='$c_version' ORDER BY sbt.status ASC, sbt.last_updated DESC";
+ WHERE sbt.project_id='$c_project_id' AND sbt.target_version='$c_version' ORDER BY sbt.status ASC, sbt.priority DESC, sbt.last_updated DESC";
$t_description = $t_version_row['description'];
@@ -235,7 +235,15 @@
for ( $j = 0; $j < count( $t_issue_set_ids ); $j++ ) {
$t_issue_set_id = $t_issue_set_ids[$j];
$t_issue_set_level = $t_issue_set_levels[$j];
-
+
+ $t_bug = bug_get( $t_issue_set_id );
+
+ if ( $t_bug->priority != $t_priority
+ && $t_bug->status < $t_resolved ) {
+ echo '<b> ', strtoupper( get_enum_element( 'priority', $t_bug->priority ) ), '</b><br />';
+ $t_priority = $t_bug->priority;
+ }
+
helper_call_custom_function( 'roadmap_print_issue', array( $t_issue_set_id, $t_issue_set_level ) );
}
--
1.6.1
From 0baffa769713624873a56127cc1e8deb4f58bc6b Mon Sep 17 00:00:00 2001
From: Brian Wrightson <brian.wrightson@gmail.com>
Date: Fri, 3 Apr 2009 16:09:36 -0400
Subject: [PATCH 2/2] Fix #8949: Text and icon to indicate priority in Roadmap
I added the priority icon as well, next to the text. It's simple but I think it looks good.
---
roadmap_page.php | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/roadmap_page.php b/roadmap_page.php
index 5731148..b136c23 100644
--- a/roadmap_page.php
+++ b/roadmap_page.php
@@ -26,6 +26,7 @@
$t_core_path = config_get( 'core_path' );
require_once( $t_core_path.'bug_api.php' );
+ require_once( $t_core_path.'icon_api.php' );
# Print header for the specified project version.
function print_version_header( $p_version_row ) {
@@ -240,7 +241,7 @@
if ( $t_bug->priority != $t_priority
&& $t_bug->status < $t_resolved ) {
- echo '<b> ', strtoupper( get_enum_element( 'priority', $t_bug->priority ) ), '</b><br />';
+ echo ' ', icon_get_status_icon( $t_bug->priority ), '<b>', strtoupper( get_enum_element( 'priority', $t_bug->priority ) ), '</b><br />';
$t_priority = $t_bug->priority;
}
--
1.6.1
|
|---|
