View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0026063||mantisbt||code cleanup||public||2019-08-22 12:34||2019-08-25 12:36|
|Target Version||2.22.0||Fixed in Version||2.22.0|
|Summary||0026063: Glue after String Array is being Deprecated|
The Join() function will soon be strict on the order of its parameters (PHP 7.4), so any mismatches there will need to be changed. So far, I've only found an instance of the wrong Join() order: on line 653 of "core/layout_api.php"; but there may be others.
|Tags||No tags attached.|
Thanks @RealityRipple for entering the issue.
The same applies to implode() as join() is just an alias for implode()
Not sure if it's needed or just good to have for the moment.
According the PHP Wiki it should work, but emit a deprecation warning
I had a very short look, but there are some more.
Last edited: 2019-08-23 11:04
At present, I can't get Mantis to run correctly on 7.4b1 - I get repeated Internal Server Errors on bug and admin pages. However, I believe you're correct in that this issue only triggers a warning in 7.4. That's why this is under code cleanup and not an actual error.
Edit: Sorry, I said alpha, but it's beta. Unimportant, but just in case anyone else tries to run Mantis on b1, it'd be best to have some confirmation that there's some teething issues.
IMO not worth to invest time in going on to try it, as there is 7.4.0beta4 available
I'm aware and waiting for my webserver's host to update their 7.4 version. That's why I haven't gone through and tried to find all the causes of the ISEs and report them as bugs. As far as I know, though, this particular issue does not contribute to the failures I run into. Just a warning in the ol' error log.
@dregad while you are on it https://github.com/ADOdb/ADOdb/blob/master/pear/Auth/Container/ADOdb.php#L202
Thanks for the heads up, I'll fix that
MantisBT: master 7ab90f60
|PHP 7.4: remove deprecated usage of implode()
Passing parameters to implode() in reverse order is deprecated
|mod - api/soap/mc_api.php||Diff File|
|mod - api/soap/mc_file_api.php||Diff File|
|mod - core/error_api.php||Diff File|
|mod - core/file_api.php||Diff File|
|mod - core/filter_api.php||Diff File|
|mod - core/install_helper_functions_api.php||Diff File|
|mod - core/layout_api.php||Diff File|
|mod - core/news_api.php||Diff File|
|mod - core/print_api.php||Diff File|
|mod - manage_plugin_page.php||Diff File|