View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0025446 | mantisbt | ui | public | 2019-02-06 11:40 | 2019-03-16 20:20 |
Reporter | cproensa | Assigned To | atrol | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 2.20.0 | ||||
Target Version | 2.20.0 | Fixed in Version | 2.20.0 | ||
Summary | 0025446: 'show_queries_count' is a global setting, but 'show_memory_usage', 'show_timer' are not | ||||
Description | Seems like Thoughts? | ||||
Tags | No tags attached. | ||||
I believe config options that are related to instrumentation and diagnostics should be required to be global, since they can expose information about the server, overwrite a critical file with a log file, etc. These should be controlled via IT admin / hoster via |
|
In general, I prefer config_get_global for such kind of settings, because of better performance and security. As mentioned by @cproensa there is no reason to prevent setting show_queries_count in database as long as we allow settings like show_memory_usage, show_timer to be set in database. I think we should merge the PR and start the general discussion in #25460 (IMO something that could just be changed in 3.x) |
|
@atrol I would rather move these diagnostics configs to global rather than moving them the other way around. See reasoning at 0025460:0061507. |
|
I understand the reasons for #0025460. But also the settings referenced here don't have any impact on security, or side effects with application functionality, system files, etc. I think the point here is: all of them should have the same treatment. I don't really mind if it's to use them as config-file only, or not. |
|
Ok, so there is now PR https://github.com/mantisbt/mantisbt/pull/1466 |
|
MantisBT: master 9be5a953 2019-02-16 23:50 Details Diff |
Remove unused function helper_show_query_count Issue 0025446 |
Affected Issues 0025446 |
|
mod - core/helper_api.php | Diff File | ||
MantisBT: master 3965532b 2019-02-17 00:08 Details Diff |
Don't allow show_timer and show_memory_usage to be set in database Harmonize options with treatment of show_queries_count Fixes 0025446 |
Affected Issues 0025446 |
|
mod - config_defaults_inc.php | Diff File | ||
mod - core/layout_api.php | Diff File |