View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0025033||mantisbt||installation||public||2018-12-07 08:45||2019-01-02 17:25|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||2.19.0||Fixed in Version||2.19.0|
|Summary||0025033: Warning with PHP 7.3: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?|
I'm seeing this warning in my logs if I try to use mantis with PHP 7.3:
PHP Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /[path]/core/install_helper_functions_api.php on line 467
Probably just a cosmetic issue, but should be fixed now that PHP 7.3 is stable.
|Tags||No tags attached.|
@hanno you wrote
Am I right that you are not talking about using or installing a new MantisBT, but about upgrading an old version of MantisBT?
I was upgrading from a previous (2.17.1) version today, so it's very well possible that the warning happened during the update.
Thanks for the feedback.
That's a bit strange, as there is no difference in database schema between 2.17.1 and 2.18.0, so I don't expect that the code in
MantisBT: master 3250e83b
2018-12-07 09:17:47Details Diff
|Fix PHP 7.3 warning
Starting from PHP 7.3, continue statements targeting switch control flow
structures generate a warning .
In our case, we don't want just to break the switch, but continue with
the next row of the database fetch.
|mod - core/install_helper_functions_api.php||Diff File|
|2018-12-07 08:45||hanno||New Issue|
|2018-12-07 09:24||atrol||Assigned To||=> atrol|
|2018-12-07 09:24||atrol||Status||new => assigned|
|2018-12-07 09:25||atrol||Target Version||=> 2.19.0|
|2018-12-07 09:26||atrol||Note Added: 0061045|
|2018-12-07 09:29||atrol||Note Added: 0061046|
|2018-12-07 09:32||hanno||Note Added: 0061047|
|2018-12-07 09:40||atrol||Note Added: 0061048|
|2018-12-11 10:59||atrol||Changeset attached||=> MantisBT master 3250e83b|
|2018-12-11 10:59||atrol||Status||assigned => resolved|
|2018-12-11 10:59||atrol||Resolution||open => fixed|
|2018-12-11 10:59||atrol||Fixed in Version||=> 2.19.0|
|2019-01-02 17:25||vboctor||Status||resolved => closed|