0009396: Wrong error message for tag attach - MantisBT - Signup temporarily disabled due to spam

ID	Project	Category	View Status	Date Submitted	Last Update

0009396	mantisbt	tagging	public	2008-07-15 15:00	2009-01-15 11:26

Reporter	mthibeault	Assigned To	grangeway
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	1.2.0a1
Fixed in Version	1.2.0a3

Summary	0009396: Wrong error message for tag attach
Description	When attaching a tag, the error messages are wrong. When a tag needs to be created and the user doesn't have the appropriate access level, Mantis returns the invalid name error. When a tag name is invalid, Mantis returns the access denied error.
Additional Information	To solve this issue, error messages just needs to be switched.
Tags	No tags attached.
Attached Files	tag_error_messages.diff (800 bytes) diff --unified Copy of mantisbt/tag_attach.php mantisbt/tag_attach.php --- Copy of mantisbt/tag_attach.php 2008-11-27 19:09:15.000000000 -0500 +++ mantisbt/tag_attach.php 2008-11-28 11:31:12.805962200 -0500 @@ -92,10 +92,11 @@ foreach( $t_tags_failed as $t_tag_row ) { echo '<tr ',helper_alternate_class(),'>'; if ( -1 == $t_tag_row['id'] ) { - echo '<td class="category">', lang_get( 'tag_invalid_name' ), '</td>'; - } elseif ( -2 == $t_tag_row['id'] ) { echo '<td class="category">', lang_get( 'tag_create_denied' ), '</td>'; + } elseif ( -2 == $t_tag_row['id'] ) { + echo '<td class="category">', lang_get( 'tag_invalid_name' ), '</td>'; } + echo '<td>', string_html_specialchars( $t_tag_row['name'] ), '</td></tr>'; if ( !is_blank( $t_tag_string ) ) { tag_error_messages.diff (800 bytes)