Mantis Bug Tracker
 

View Issue Details Jump to Notes ] Wiki ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003371mantisbtfeaturepublic2003-09-26 20:232004-08-29 02:03
Reporterleus 
Assigned Tovboctor 
PrioritynormalSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version0.19.0rc1 
Summary0003371: CVS Integration (patch included)
DescriptionHi, this is a small patch for CVS integration (and cvsweb)
TagsNo tags attached.
Attached Filesgz file icon mantis_cvs.tar.gz [^] (2,480 bytes) 2003-09-26 20:24
txt file icon diff.txt [^] (2,593 bytes) 2003-09-26 20:24 [Show Content]
txt file icon instructions.txt [^] (1,301 bytes) 2003-09-26 22:05 [Show Content]
txt file icon mantis_cvs.pl.txt [^] (4,150 bytes) 2003-09-26 22:15 [Show Content]
gif file icon Image1.gif [^] (9,513 bytes) 2004-03-15 08:20


diff file icon source_control_integration.diff [^] (12,242 bytes) 2004-07-30 07:44 [Show Content]

Sponsor - Users sponsoring this issue
Sponsors List Total Sponsorship = US$ 20

2004-07-23 17:57: gabbs (US$ 20)

- Relationships
has duplicate 0002172closedvboctor CVS integration a la cvstrac? 
has duplicate 0004079closedvboctor Integration into CVS 
related to 0003758closedjreese Perforce Integration (script included) 
child of 0003987closedvboctor Mantis 0.19.0 Release 

-  Notes
User avatar (0004658)
vboctor (administrator)
2003-09-29 01:25

Leus, this looks like a very good work. I will look at it in details. Have a look at 0002172 which I marked as a duplicate for this one.
User avatar (0004662)
leus (reporter)
2003-09-29 18:01

Thanks. However, is not that good, as I've found two bugs to the perl script already...
User avatar (0004665)
vboctor (administrator)
2003-09-30 01:18

There will always be bugs, we just need to keep fixing them :)
User avatar (0004666)
leus (reporter)
2003-09-30 16:13

Thee is a problem with the mantis_cvs script attached. The "process" function is parsing incorrectly the parameters passed to the script.

Here is a small patch.

102,103c102,107
< foreach ( @ARGV ) {
< my ($file,$newv) = split ",";
---
> for (my $i=0; $i < scalar @ARGV; $i++ ) {
> my @args = split ' ', $ARGV[$i];
> my $module_name = $args[0];
> for (my $j=1; $j < scalar @args; $j++ ) {
> my ($file,$newv) = split ",", $args[$j];
> $file = "$module_name/$file";
105a110
> }
User avatar (0005199)
leus (reporter)
2004-03-11 08:15

Hi, just wanted to know if anybody is looking for this feature.
User avatar (0005200)
kmars (reporter)
2004-03-11 16:45

Very interested. We use cvs to roll out many systems and software. WEare constantly developing and would lov to see this feature implemented
User avatar (0005206)
vboctor (administrator)
2004-03-14 17:08

Leus, how easy would it be to port mantis_cvs.pl to PHP?
User avatar (0005208)
leus (reporter)
2004-03-15 07:16

Frankly, I don't know. Should be easy.
User avatar (0005210)
vboctor (administrator)
2004-03-15 07:43

It would be good if we do the following:
- Port the script to PHP.
- Update instructions to reflect the use of the PHP script.
- Update instructions to explain how does the integration work. For example, what will appear in Mantis after a commit (i.e. the benefit of the whole thing)

Once we have this stuff done, I think we should add this to Mantis distribution + manual.
User avatar (0005211)
leus (reporter)
2004-03-15 08:19
edited on: 2004-03-15 08:21

There is one thing that bothered me about mantis: the fact that bugnotes and history events are separated. It bothered me so much that I did change it; the way I see, a bugtracker should be an annotated history of every event related to the solution of one particular issue. I did it by listing the history events by time, and showing the appropiate remark. I'm attaching a screenshot for you to see.

Should we add a new "view" for a bug? (Normal view /Advanced view /Chrono list)

If we can't, maybe just adding a history item or a special bugnote should do the trick. In the attached image check out the "CVS checkin" event (in my setup, the link goes to the cvsweb)

edited on: 03-15-04 08:21
User avatar (0005316)
vboctor (administrator)
2004-04-01 08:42

Leus, I like your chronological view, it can be an option that would affect how the simple/advanced view pages are rendered. Please re-upload your screenshot and add any patches/comments to 0003701.
User avatar (0005324)
gstarrett (reporter)
2004-04-02 00:31

I'd be interested in this patch too since we already use both Mantis and CVS here.
User avatar (0005353)
alexl (reporter)
2004-04-07 15:08

I tried CVS integration patch and patching with diff.txt produces errors with 0.18.2
# patch -p0 <diff.txt
patching file config_defaults_inc.php
patching file core/constant_inc.php
patching file core/history_api.php
Hunk 0000002 FAILED at 252.
Hunk 0000003 FAILED at 256.
2 out of 3 hunks FAILED -- saving rejects to file core/history_api.php.rej
patching file lang/strings_english.txt
patching file lang/strings_spanish.txt
Hunk 0000002 FAILED at 866.
1 out of 2 hunks FAILED -- saving rejects to file lang/strings_spanish.txt.rej
User avatar (0005792)
kmars (reporter)
2004-06-24 11:19

I have this installed and have one last thing to overcome. In my Bug History section my change field comes up with the location of the file in cvs, but it is not a hyperlink.

I am unsure if this is something with the mantis core or the cvs integration patch. I have allow_html_tags enabled.
I would love to complete this and implement it for our developers. Any help is appreciated
User avatar (0006331)
vboctor (administrator)
2004-07-24 09:54

I can see some interest in this issue given the monitor list + the sponsorship. So is Perl solution ok for now or do you guys prefer a PHP port of the script before adding this into Mantis?

If there is enough support for this, I will try to put it in 0.19.0, if not, then will be in the following major release.
User avatar (0006336)
gstarrett (reporter)
2004-07-24 14:48
edited on: 2004-07-24 14:49

>>> So is Perl solution ok for now or do you guys prefer a PHP port of the script before adding this into Mantis?
<<<

The PERL CVS script is fine for me, it's customary for CVS and I'm all set up for that anyway. I'd be happy if the required elements are added to Mantis core and the CVS script is supported (e.g. maintained across releases of Mantis, and posted at the Mantis site).

I'm assuming that the Mantis side will take care of notifying all the people monitoring the bug that there is a new bugnote as if it were directly added in Mantis, but the script talks about sending an email. I hope it would :)

Another note: For CVSNT (http://www.cvsnt.org/ [^] ), the list of files & versions will come in from STDIN, not on the command line. We use CVSNT, but I suppose I could ask someone on the CVSNT list for some help porting it if you don't have a way to do that. (The change was made because of a limit on the length of the command line that caused missed information on large checkins)

edited on: 07-24-04 14:49
User avatar (0006345)
grangeway (developer)
2004-07-25 08:15

PHP port + cvsnt support for me
User avatar (0006365)
gabbs (reporter)
2004-07-26 08:15
edited on: 2004-07-26 08:17

Yup PHP port would be good, in the future maybe instead of putting it in as a comment, putting it into the mantis database in another table so you can list the files and versions changed within the bug and then link them to a web based CVS viewer (Chora etc) now that would be SMART! :) all you need now is simple integration into a testing tool (eg: http://majordojo.com/testitool/ [^] - dunno if its any good tho) and everybody will be using it :) Mantis is great all hail mantis :)

edited on: 07-26-04 08:17
User avatar (0006367)
leus (reporter)
2004-07-26 09:29

Gabbs, checkins are inserted as history notes; you _can_ list all checkins associated to a bug. And linking to cvsweb is already in place; there is a lot of room for improvement here.

(I have an updated diff file for the current version of Mantis, but I cannot upload attachments...)
User avatar (0006400)
leus (reporter)
2004-07-27 15:57

Okay, I have updated versions of the diff file and a new PHP version of the
mantis_cvs script. I cannot upload files, thought; who can upload these files for
me?
User avatar (0006402)
vboctor (administrator)
2004-07-27 17:11

Leus, please send me the files. Thanks.
User avatar (0006416)
fusenigk (reporter)
2004-07-28 07:08
edited on: 2004-07-28 07:09

hi, this feature looks really good!
But I have some problems to patch the core/history_api.php file correctly to the current Mantis version.
Can someone send me a working version for 0.19.a2 to fusenigk@web.de or a current path file?
thanks in advance!

edited on: 07-28-04 07:09
User avatar (0006474)
vboctor (administrator)
2004-07-30 07:51

I attached a patch that I applied to CVS. This patch achieves the following:
- Supports script logins
- Fixes some issues with php-cgi.
- Implements a PHP script which calls a custom function per issue when a commit is done. By default this adds a history entry + can set status of the issue to a specified status (eg: FIXED or something). This can be overridden to do more/other things.

The thing that this patch doesn't do is to link to cvsweb. I am not aware of all the details regarding how to get the filenames + versions. Also what if the developer made a commit which affects 50 files?

I suggest people have a look at it and give me feedback (suggestions / bugs). Note that I didn't test it with a real cvs (source control) server. I test the script by entering data in stdin, and made sure that the appropriate actions are done.
User avatar (0006620)
vboctor (administrator)
2004-08-04 06:35

Did anyone get a chance to test the CVS integration in CVS HEAD version of Mantis?
User avatar (0006625)
thraxisp (manager)
2004-08-04 08:39

Is the script called from CVS in CVS HEAD? I can't seem to find it.
User avatar (0006629)
vboctor (administrator)
2004-08-04 09:20

The script can be found under core/checkin.php

- Issue History
Date Modified Username Field Change
2003-09-26 20:23 leus New Issue
2003-09-26 20:24 leus File Added: mantis_cvs.tar.gz
2003-09-26 20:24 leus File Added: diff.txt
2003-09-26 22:05 leus File Added: instructions.txt
2003-09-26 22:15 leus File Added: mantis_cvs.pl.txt
2003-09-26 23:59 leus Issue Monitored: leus
2003-09-29 01:22 vboctor Relationship added duplicate of 0002172
2003-09-29 01:25 vboctor Note Added: 0004658
2003-09-29 10:49 cfranco_amsatec Issue Monitored: cfranco_amsatec
2003-09-29 18:01 leus Note Added: 0004662
2003-09-30 01:18 vboctor Note Added: 0004665
2003-09-30 16:13 leus Note Added: 0004666
2004-03-11 08:15 leus Note Added: 0005199
2004-03-11 16:45 kmars Note Added: 0005200
2004-03-14 17:08 vboctor Note Added: 0005206
2004-03-15 07:16 leus Note Added: 0005208
2004-03-15 07:43 vboctor Note Added: 0005210
2004-03-15 08:19 leus Note Added: 0005211
2004-03-15 08:20 leus File Added: Image1.gif
2004-03-15 08:21 leus Note Edited: 0005211
2004-04-01 08:42 vboctor Note Added: 0005316
2004-04-02 00:31 gstarrett Issue Monitored: gstarrett
2004-04-02 00:31 gstarrett Note Added: 0005324
2004-04-02 03:39 blaat Issue Monitored: blaat
2004-04-07 15:08 alexl Note Added: 0005353
2004-04-07 15:21 redcom Issue Monitored: redcom
2004-04-07 15:24 alexl Issue Monitored: alexl
2004-04-09 07:52 ralfiii Issue Monitored: ralfiii
2004-04-29 03:59 pcs Issue Monitored: pcs
2004-05-12 19:32 epu Issue Monitored: epu
2004-06-24 11:19 kmars Note Added: 0005792
2004-06-25 10:25 kmars Issue Monitored: kmars
2004-07-13 05:26 vboctor Relationship added duplicate of 0004079
2004-07-23 17:57 gabbs Sponsorship Added gabbs: US$ 20
2004-07-23 17:57 gabbs Sponsorship Total 0 => 20
2004-07-23 17:57 gabbs Issue Monitored: gabbs
2004-07-24 09:54 vboctor Note Added: 0006331
2004-07-24 09:55 vboctor Assigned To => vboctor
2004-07-24 14:48 gstarrett Note Added: 0006336
2004-07-24 14:49 gstarrett Note Edited: 0006336
2004-07-24 17:02 thraxisp Issue Monitored: thraxisp
2004-07-25 08:15 grangeway Note Added: 0006345
2004-07-26 08:15 gabbs Note Added: 0006365
2004-07-26 08:17 gabbs Note Edited: 0006365
2004-07-26 09:29 leus Note Added: 0006367
2004-07-27 15:57 leus Note Added: 0006400
2004-07-27 16:53 bluetooth Sponsorship Added bluetooth: US$ 5
2004-07-27 16:53 bluetooth Sponsorship Total 20 => 25
2004-07-27 16:53 bluetooth Issue Monitored: bluetooth
2004-07-27 17:11 vboctor Note Added: 0006402
2004-07-28 04:51 fusenigk Issue Monitored: fusenigk
2004-07-28 06:58 bluetooth Sponsorship Deleted bluetooth: US$ 5
2004-07-28 06:58 bluetooth Sponsorship Total 25 => 20
2004-07-28 07:05 DGtlRift Issue Monitored: DGtlRift
2004-07-28 07:08 fusenigk Note Added: 0006416
2004-07-28 07:09 fusenigk Note Edited: 0006416
2004-07-30 06:45 grangeway Relationship added child of 0003987
2004-07-30 07:44 vboctor File Added: source_control_integration.diff
2004-07-30 07:51 vboctor Note Added: 0006474
2004-07-30 07:56 vboctor Status new => assigned
2004-07-31 21:01 vboctor Relationship added related to 0003758
2004-08-04 06:35 vboctor Note Added: 0006620
2004-08-04 08:39 thraxisp Note Added: 0006625
2004-08-04 09:15 johnwebbcole Issue Monitored: johnwebbcole
2004-08-04 09:20 vboctor Note Added: 0006629
2004-08-05 11:37 vboctor Status assigned => resolved
2004-08-05 11:37 vboctor Fixed in Version => 0.19.0rc1
2004-08-05 11:37 vboctor Resolution open => fixed
2004-08-29 02:03 vboctor Status resolved => closed


MantisBT 1.2.2 git master-1.2.x[^]
Copyright © 2000 - 2010 MantisBT Group
Time: 0.5160 seconds.
memory usage: 2,190 KB
Powered by Mantis Bugtracker