It's not really clear how you're trying to set your link, maybe a code snippet would help. Posting the generated HTML may also be useful, as well as your instance's relevant configuration (config_inc.php).

Please see https://github.com/mantisbt-plugins/source-integration/blob/master/Source/Source.php#L145 for a working example of a plugin link with this event

The code of the Source Integration plugin is for Mantis 1.3. I've no problem with Mantis 1.3, but with 2.0.
My event handler for EVENT_MENU_MAIN looks like this:

function event_menu_main() {
    return array(
        array(
            'title' => 'Entry 1',
            'access_level' => UPDATER,
            'url' => plugin_page("entry1.php")
        ),
        array(
            'title' => 'Entry 2',
            'access_level' => UPDATER,
            'url' => plugin_page("entry2.php")
        ),
        array(
            'title' => 'Entry3',
            'access_level' => ADMINISTRATOR,
            'url' => plugin_page("entry3.php")
        )
    );
}

The HTML looks like this:

<li>
<a href="//plugin.php?page=myPlugin/entry1.php">
<i class="menu-icon fa fa-plug"></i> 
<span class="menu-text"> Entry 1 </span>
</a>
<b class="arrow"></b>
</li>
<li>
<a href="//plugin.php?page=myPlugin/entry2.php">
<i class="menu-icon fa fa-plug"></i> 
<span class="menu-text"> Entry 2 </span>
</a>
<b class="arrow"></b>
</li>
<li>
<a href="//plugin.php?page=myPlugin/entry3.php">
<i class="menu-icon fa fa-plug"></i> 
<span class="menu-text"> Entry 3 </span>
</a>
<b class="arrow"></b>
</li>

So the problem seems to be that Mantis adds an extra slash to the link, accidently turning it into a protocol relative url. My config file contains only the database and email config.

EDIT: fix markdown

My apologies, I mistakenly linked to the wrong branch, the URL should have been
https://github.com/mantisbt-plugins/source-integration/blob/modern-ui/Source/Source.php#L143

Notice the use of 'true' as second parameter to plugin_page.php, which will bypass the use of helper_mantis_url(). See [1] for an explanation of the change.

Let me know if that fixes the problem.

[1] https://github.com/mantisbt-plugins/source-integration/commit/1491ba13b288d1b8ac18d3025e3db29e62265cb5

Yes, this fixes the problem, thank you. However, I'm not really convinced that this is the way to go. Maybe I misunderstand the use of the $p_redirect parameter. To me this seems more like a workaround than a proper solution. In my opinion a proper solution would be to check whether the link starts with a slash and not add an extra slash if it does.

this seems more like a workaround than a proper solution.

You may be right, actually.

a proper solution would be to check whether the link starts with a slash and not add an extra slash if it does.

What helper_mantis_url() does is prepend the given URL with $g_short_path, so simply checking for a leading '/' would definitely not be the right way to fix this, as it would only work if Mantis were installed at the root. The function would have to determine whether the short path has already been added.

Try this:

diff --git a/core/helper_api.php b/core/helper_api.php

index 47d6b0e..d63d1e2 100644

--- a/core/helper_api.php

+++ b/core/helper_api.php

@@ -605,7 +605,14 @@ function helper_mantis_url( $p_url ) {

if( is_blank( $p_url ) ) {

return $p_url;

}


return config_get_global( 'short_path' ) . $p_url;



Return URL as-is if it already starts with short path

$t_short_path = config_get_global( 'short_path' );
if( strpos( $p_url, $t_short_path ) === 0 ) {
return $p_url;
}



return $t_short_path . $p_url;

}
/**

PR https://github.com/mantisbt/mantisbt/pull/986

The change seems to be in the 2.0.x branch only. I cannot see it in the 2.1.0 release. Does this mean that it won't be merged to future versions of Mantis?

@TiKu the 2.0.x branch as been merged into master; this is fixed in 2.1 as well:

 $ git branch -r --contains bbf4cac7
  origin/HEAD -> origin/master
  origin/master
  origin/master-2.0.x
  origin/master-2.1

@dregad Ah, thank you. I've misinterpreted the changelog.