See discussion thread [1]

I can consistently reproduce the issue with dates (in VersionTest.php), using both php5_soap and nusoap, and I believe it's clearly a case of not taking the timezone into consideration (due to comparing a string instead of a datetime object).

The case of AttachmentTest is a bit weird though. I tested with different setups and PHP versions (but always with same Mantis code) and in most cases, the attachment's download_url as returned by mc_issue_get() has an encoded '&', but in one case [2] it returned '&' (regardless of which soap was used), and I have no idea why.

So IMO a good way to fix this would be to use html_entity_decode() on the download_url returned by soap api.

[1] http://thread.gmane.org/gmane.comp.bug-tracking.mantis.devel/4412
[2] PHP 5.2.14 with Suhosin-Patch 0.9.7 on Apache/2.2.10 (Linux/SUSE)

Test this: https://github.com/dregad/mantisbt/tree/fix-15817

All three commits look good to me. BTW, what did you use to format the code?

Thx for feedback.

what did you use to format the code?

What do you mean?

Did you reformat the code manually? https://github.com/dregad/mantisbt/commit/4517dd1a6a54a1294ca71235aa81aef26cae925d introduces whitespace changes and I'm curious if you did them manually or with an IDE.

My text editor (geany) is configured to automatically remove trailing whitespace, and to use tabs for indents as per our coding guidelines.

Using the tab key indents/outdents a text block, and this function replaces spaces by tabs if needed. There's also a function to replace spaces by tabs and vice-versa.

I also have git configured to highlight whitespace errors (trailing-space, space-before-tab, indent-with-non-tab) so I easily spot issues when I diff changes; I have also been playing with a pre-commit hook to validate such things.

So in short, it's a mix of manual and automated.