0014466: New Signup user has protected account

(0032281)
atrol (developer)
2012-07-09 09:51

Which database do you use?

(0032282)
mva (reporter)
2012-07-09 10:37

PostgreSQL

(0032285)
dregad (developer)
2012-07-09 22:28

This is probably a side effect of 0014288 - will have a look.

Note: removing relationship to 0014398 which deals with issues related to 1.3, not the case here

(0032288)
atrol (developer)
2012-07-10 01:30

dregad, you set the same relationship at 0014385. So I thought it is a good idea to add it also here.
I added better relationship 0013713 to collect test cases when introducing a new version of ADOdb.

(0032289)
mva (reporter)
2012-07-10 01:42

Hm-m, on my opinion error in php code and indpendentd from database platform.

At user_api.php line 457

$c_protected = db_prepare_bool( $p_protected );

$c_protected always has value!

At user_api.php line 457

    if( $c_protected ) {
        user_set_field( $t_user_id, 'protected', 1 );
    }

Always set new user to protected state!

I'm sorry if this note was unnecessary

(0032290)
atrol (developer)
2012-07-10 01:47

I had a bad gut feeling when seeing this commit.
> This is probably a side effect of 0014288 - will have a look.
<smartass>Dealing with systems instead of the root cause is no good ideas most of the time</smartass>

Our real problem is, that we don't have enough automated tests to make such kind of changes without fearing to break existing functionality.

(0032291)
atrol (developer)
2012-07-10 01:50

mva, if( $c_protected ) doesn't mean "has a value" it means "is true"

(0036154)
grangeway (developer)
2013-04-05 17:56

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

Related Changesets
MantisBT: master d9e97d9e Timestamp: 2012-08-01 17:34:44 Author: dregad [ Details ] [ Diff ]	Fix new signup user is protected account on PostgreSQL This fixes a regression introduced with resolution of 0014288 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2) The user_create() function was not properly resetting the account's protected flag to false due to specific handling of Boolean type as a string for PostgreSQL. Fixes 0014466
	mod - core/user_api.php	[ Diff ] [ File ]

MantisBT: master-1.2.x 7124ee6f Timestamp: 2012-08-01 17:34:44 Author: dregad [ Details ] [ Diff ]	Fix new signup user is protected account on PostgreSQL This fixes a regression introduced with resolution of 0014288 (see commit b8d4b5039598248d0b0c78619450c51d4dc98df2) The user_create() function was not properly resetting the account's protected flag to false due to specific handling of Boolean type as a string for PostgreSQL. Fixes 0014466
	mod - core/user_api.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-07-09 09:11	mva	New Issue
2012-07-09 09:51	atrol	Note Added: 0032281
2012-07-09 09:51	atrol	Status	new => feedback
2012-07-09 10:37	mva	Note Added: 0032282
2012-07-09 10:37	mva	Status	feedback => new
2012-07-09 10:44	atrol	Category	signup => db postgresql
2012-07-09 10:48	atrol	Relationship added	related to 0014398
2012-07-09 22:27	dregad	Relationship added	related to 0014288
2012-07-09 22:27	dregad	Assigned To	=> dregad
2012-07-09 22:27	dregad	Status	new => assigned
2012-07-09 22:28	dregad	Note Added: 0032285
2012-07-09 22:28	dregad	Relationship deleted	related to 0014398
2012-07-10 01:30	atrol	Note Added: 0032288
2012-07-10 01:30	atrol	Relationship added	related to 0013713
2012-07-10 01:42	mva	Note Added: 0032289
2012-07-10 01:47	atrol	Note Added: 0032290
2012-07-10 01:50	atrol	Note Added: 0032291
2012-08-03 18:09	dregad	Status	assigned => resolved
2012-08-03 18:09	dregad	Resolution	open => fixed
2012-08-03 18:09	dregad	Fixed in Version	=> 1.2.12
2012-08-03 18:09	dregad	Target Version	=> 1.2.12
2012-08-03 18:09	dregad	Changeset attached	=> MantisBT master d9e97d9e
2012-08-03 18:09	dregad	Changeset attached	=> MantisBT master-1.2.x 7124ee6f
2012-11-10 18:54	dregad	Status	resolved => closed
2013-04-05 17:56	grangeway	Status	closed => acknowledged
2013-04-05 17:56	grangeway	Note Added: 0036154
2013-04-05 19:25	grangeway	Relationship added	related to 0015721
2013-04-06 03:40	dregad	Status	acknowledged => closed
2013-04-06 07:23	grangeway	Status	closed => acknowledged
2013-04-06 09:22	dregad	Tag Attached: 2.0.x check
2013-04-06 09:23	dregad	Status	acknowledged => closed

Notes
(0032281) atrol (developer) 2012-07-09 09:51	Which database do you use?

(0032282) mva (reporter) 2012-07-09 10:37	PostgreSQL

(0032285) dregad (developer) 2012-07-09 22:28	This is probably a side effect of 0014288 - will have a look. Note: removing relationship to 0014398 which deals with issues related to 1.3, not the case here

(0032288) atrol (developer) 2012-07-10 01:30	dregad, you set the same relationship at 0014385. So I thought it is a good idea to add it also here. I added better relationship 0013713 to collect test cases when introducing a new version of ADOdb.

(0032289) mva (reporter) 2012-07-10 01:42	Hm-m, on my opinion error in php code and indpendentd from database platform. At user_api.php line 457 $c_protected = db_prepare_bool( $p_protected ); $c_protected always has value! At user_api.php line 457 if( $c_protected ) { user_set_field( $t_user_id, 'protected', 1 ); } Always set new user to protected state! I'm sorry if this note was unnecessary

(0032290) atrol (developer) 2012-07-10 01:47	I had a bad gut feeling when seeing this commit. > This is probably a side effect of 0014288 - will have a look. <smartass>Dealing with systems instead of the root cause is no good ideas most of the time</smartass> Our real problem is, that we don't have enough automated tests to make such kind of changes without fearing to break existing functionality.

(0032291) atrol (developer) 2012-07-10 01:50	mva, if( $c_protected ) doesn't mean "has a value" it means "is true"

(0036154) grangeway (developer) 2013-04-05 17:56	Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch