View Issue Details

IDProjectCategoryView StatusLast Update
0014191mantisbtbugtrackerpublic2014-09-23 18:05
Reporterdregad Assigned Todregad  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.11 
Target Version1.2.11Fixed in Version1.2.11 
Summary0014191: SYSTEM NOTICE: 'Undefined variable: t_project' in html_api.php
Description

The fix for 0014156 introduced an undefined variable warning, due to removal of a call to bug_get_field function to retrieve the project_id.

SYSTEM NOTICE: 'Undefined variable: t_project' in '.../core/html_api.php' line 1542
SYSTEM NOTICE: 'Undefined variable: t_project' in '.../core/html_api.php' line 1558

Additional Information

This could actually cause the incorrect status to be retrieved in html_button_bug_reopen() and html_button_bug_close(), potentially allowing users to close or reopen issues when they are not entitled to.

TagsNo tags attached.

Relationships

related to 0014156 closeddregad Add Close button for Reporter if allow_reporter_close is enabled 
related to 0015721 closedgrangeway Functionality to consider porting to master-2.0.x 

Activities

grangeway

grangeway

2013-04-05 17:57

reporter   ~0036262

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

Related Changesets

MantisBT: master-1.2.x a8e5b81a

2012-04-25 00:56

dregad


Details Diff
Use BugData object as function param for several functions

Commit 0ec4563af05e02dfe9d82238f3f1634fd3884b0e introduced an undefined
variable warning, due to removal of a call to bug_get_field function to
retrieve the project_id. This could actually cause the incorrect status
to be retrieved in html_button_bug_reopen() and html_button_bug_close(),
potentially allowing users to close or reopen issues when they are not
entitled to.

Instead of adding the function call back as it was, the code was
modified to use a BugData object instead of a bug id as parameter for
several functions in access_api.php and html_api.php, resulting in
simpler and more efficient code thanks to fewer calls to bug_get() and
bug_get_field().

Fixes 0014191, Affects 0014156
Affected Issues
0014191
mod - bug_actiongroup.php Diff File
mod - bug_change_status_page.php Diff File
mod - bug_update_advanced_page.php Diff File
mod - core/access_api.php Diff File
mod - core/html_api.php Diff File