MantisBT

View Issue Details Jump to Notes ] Wiki ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0013060mantisbtauthenticationpublic2011-06-07 09:372013-04-06 09:24
ReporterLapinkiller 
Assigned Todregad 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2.5 
Target Version1.2.9Fixed in Version1.2.9 
Summary0013060: links from excel to mantis
DescriptionHi,

In a excel file (office 2003) i have links to bugs, attachments etc...

If I'm not authenticated on mantis, Mantis ask me to authenticate, and redirect me to the link (as a bug or an attachment). If I click on a second link (I'm still authenticated, I'm redirected to view page instead of the bug or the attachment... I can see, the url is modified ( {mantisurl}/view.php?bug_id=1 to {mantisurl}/login_page.php?return={mantisurl}/view.php?bug_id=1 )

I tried with and without options : "remember me" & "secure session" and still have the problem...

But sometimes there is no problem...
Additional Informationtried on
Win XP : firefox 4.01, Firefox 7alpha1, IE6
Win Seven : IE8
Tags2.0.x check, patch
Attached Filespatch file icon return-parameter-is-ignored-when-already-auth.patch [^] (1,450 bytes) 2011-06-10 07:27 [Show Content]
txt file icon return-parameter-is-ignored-when-already-auth.patch-2.txt [^] (1,470 bytes) 2011-11-22 08:57 [Show Content]

- Relationships
related to 0015721new Functionality to consider porting to master-2.0.x 
has duplicate 0013065closeddregad login_page.php return paremter is ignored, when already logged in 

-  Notes
User avatar (0028937)
mluker (reporter)
2011-06-07 10:54

I've found that if I paste a link to a bug id into eg a mail document, the link works fine.
However, the same link in Excel or Word re-directs me to the MyView page.
User avatar (0028938)
atrol (developer)
2011-06-07 11:08

If the solution is found, please post also to the forum
http://www.mantisbt.org/forums/viewtopic.php?f=3&t=12741 [^]
User avatar (0028945)
Lapinkiller (reporter)
2011-06-08 09:28
edited on: 2011-06-08 09:34

i have investigate : when the link is open via Excel, Mantis doesn't see the cookie MANTIS_COOKIE_STRING ... but it exists...

about the hidden cookie :

http://stackoverflow.com/questions/1299632/using-a-query-string-in-an-excel-hyperlink-to-an-asp-net-web-application [^]
http://support.microsoft.com/kb/899927 [^]

Why mantis try to get cookie and not try to get php session ??? (with a flag in session that confirm we are authenticated)

User avatar (0028969)
Lapinkiller (reporter)
2011-06-10 07:27

patch attached !
User avatar (0029245)
Lapinkiller (reporter)
2011-07-21 04:11

no feedack about my patch ?
User avatar (0029259)
rombert (developer)
2011-07-21 17:55

@Lapinkiller: sorry for the lack of feedback. Could you submit a pull request on GitHub ? That should be more visible ...
User avatar (0030257)
funta222 (reporter)
2011-11-22 03:53
edited on: 2011-11-22 04:06

@Lapinkiller

I installed your patch in Mantis 1.2.8, but unfortunately it does not resolve the issue.

Now all links clicked in an external application (Excel, Word, desktop URL shortcuts etc) go to this URL:

http://mantis.my.domain.com/mantis//mantis/view.php?id=123 [^]

instead to

http://mantis.my.domain.com/mantis/view.php?id=123 [^]

Can you help?
Thanks in advance.

User avatar (0030262)
Lapinkiller (reporter)
2011-11-22 08:48
edited on: 2011-11-22 09:03

@rombert, as i said on another bug, i cannot do easily pull request due to the proxy


@funta222 it's seems, there is a bug when mantis is not installed at the root of the domain... my patch use mantis core functions et variable... it just use the variable $f_return instead of go ignoring it and go to home page...

i have reproduced the problem and i have found a solution :

EDIT 1 :

in login_page.php, on lines

if($f_return !== ''){//If return URL is specified
    print_header_redirect( $f_return );
}else{


=> replace with
if($f_return !== ''){//If return URL is specified
    print_header_redirect( $f_return, false, false, true );
}else{

i will submit a new patch ;)

EDIT 2 :
patch return-parameter-is-ignored-when-already-auth.patch-2.txt
I hope this second patch file is working

User avatar (0030331)
funta222 (reporter)
2011-11-24 09:28

Hi Lapinkiller,
return-parameter-is-ignored-when-already-auth.patch-2.txt
works fine with 1.2.8

Thanks!

Finally i can use this
 0013559: Provide a Link to the issue in Summary field
 http://www.mantisbt.org/bugs/view.php?id=13559 [^]
User avatar (0030336)
dregad (developer)
2011-11-24 18:05

I was not able to reproduce the error you describe myself, but I'll take your word for it, considering that it was confirmed by other users.

Many thanks for the patch ! I have applied it with some minor changes to 1.2.x and master
User avatar (0036327)
grangeway (developer)
2013-04-05 17:57

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

- Related Changesets
MantisBT: master 6a9adc66
Timestamp: 2011-06-10 04:23:41
Author: Lapinkiller
Details ] Diff ]
login_page.php return param is ignored when already logged in

This prevents proper behavior when links to bugs are used from an
external application after the initial authentication

Fixes 0013060

Aligned form variables initialization for better code readability

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
mod - login_page.php Diff ] File ]
MantisBT: master-1.2.x bbebc4e3
Timestamp: 2011-06-10 04:23:41
Author: Lapinkiller
Details ] Diff ]
login_page.php return param is ignored when already logged in

This prevents proper behavior when links to bugs are used from an
external application after the initial authentication

Fixes 0013060

Aligned form variables initialization for better code readability

Signed-off-by: Damien Regad <damien.regad@merckgroup.com>
mod - login_page.php Diff ] File ]
MantisBT: master 453e7d8f
Timestamp: 2011-11-24 15:16:23
Author: dregad
Details ] Diff ]
Fix syntax error

Introduced in 6a9adc66ba7c27f0f68d02922bd59cfa1a8763f9, forgot to git
add before commit...

Fixes 0013060
mod - login_page.php Diff ] File ]
MantisBT: master-1.2.x 5d1febbe
Timestamp: 2011-11-24 15:16:23
Author: dregad
Details ] Diff ]
Fix syntax error

Introduced in bbebc4e3666eabe91938bcd9251933568a7aa031, forgot to git
add before commit...

Fixes 0013060
mod - login_page.php Diff ] File ]

- Issue History
Date Modified Username Field Change
2011-06-07 09:37 Lapinkiller New Issue
2011-06-07 10:54 mluker Note Added: 0028937
2011-06-07 11:08 atrol Note Added: 0028938
2011-06-08 09:28 Lapinkiller Note Added: 0028945
2011-06-08 09:31 Lapinkiller Note Edited: 0028945 View Revisions
2011-06-08 09:34 Lapinkiller Note Edited: 0028945 View Revisions
2011-06-10 07:27 Lapinkiller File Added: return-parameter-is-ignored-when-already-auth.patch
2011-06-10 07:27 Lapinkiller Note Added: 0028969
2011-06-10 07:48 atrol Relationship added related to 0013065
2011-06-10 07:49 atrol Tag Attached: patch
2011-07-21 04:11 Lapinkiller Note Added: 0029245
2011-07-21 17:55 rombert Note Added: 0029259
2011-11-22 03:53 funta222 Note Added: 0030257
2011-11-22 04:06 funta222 Note Edited: 0030257 View Revisions
2011-11-22 08:48 Lapinkiller Note Added: 0030262
2011-11-22 08:55 Lapinkiller Note Edited: 0030262 View Revisions
2011-11-22 08:57 Lapinkiller File Added: return-parameter-is-ignored-when-already-auth.patch-2.txt
2011-11-22 09:02 Lapinkiller Note Edited: 0030262 View Revisions
2011-11-22 09:03 Lapinkiller Note Edited: 0030262 View Revisions
2011-11-23 18:39 belfar Note Added: 0030288
2011-11-24 09:28 funta222 Note Added: 0030331
2011-11-24 16:51 dregad Assigned To => dregad
2011-11-24 16:51 dregad Status new => assigned
2011-11-24 17:01 dregad Relationship replaced has duplicate 0013065
2011-11-24 17:02 dregad Note Deleted: 0030288
2011-11-24 18:05 dregad Note Added: 0030336
2011-11-24 18:05 dregad Status assigned => resolved
2011-11-24 18:05 dregad Fixed in Version => 1.2.9
2011-11-24 18:05 dregad Resolution open => fixed
2011-11-24 18:06 dregad Target Version => 1.2.9
2011-12-05 12:32 dregad Changeset attached => MantisBT master 453e7d8f
2011-12-05 12:32 Lapinkiller Changeset attached => MantisBT master 6a9adc66
2011-12-05 12:32 dregad Changeset attached => MantisBT master-1.2.x 5d1febbe
2011-12-05 12:32 Lapinkiller Changeset attached => MantisBT master-1.2.x bbebc4e3
2012-03-03 21:45 vboctor Status resolved => closed
2013-04-05 17:57 grangeway Status closed => acknowledged
2013-04-05 17:57 grangeway Note Added: 0036327
2013-04-05 18:23 grangeway Relationship added related to 0015721
2013-04-06 03:42 dregad Status acknowledged => closed
2013-04-06 07:23 grangeway Status closed => acknowledged
2013-04-06 09:24 dregad Tag Attached: 2.0.x check
2013-04-06 09:24 dregad Status acknowledged => closed


MantisBT 1.2.16dev master-1.2.x-8c2bd07 [^]
Copyright © 2000 - 2013 MantisBT Team
Time: 0.1503 seconds.
memory usage: 2,922 KB
Powered by Mantis Bugtracker