MantisBT

View Issue Details Jump to Notes ] Wiki ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0011995mantisbthtmlpublic2010-06-05 02:412014-09-23 18:05
Reporterbrandonjackson 
Assigned Todaryn 
PrioritynormalSeverityfeatureReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Versiongit trunk 
Target Version1.3.xFixed in Version1.3.x 
Summary0011995: Add CSS IDs to html elements for styling and javascript access.
DescriptionI've added some ID's to several of the tables in the header to make CSS-based customizations easier. For example, by adding an id to the mantis logo it can be hidden using #logo-image{display: none;}, as opposed to editing config files and creating replacement html files. These changes should be completely unobtrusive, and are an easy step that can be taken to make Mantis designer friendly.

Also, I've created a div which encloses everything within the body tags with the ID of mantis. This was discussed in issue 2814. It will allow designers to distinguish between elements from mantis and their cms. Also, it allows mantis to have a fixed-width and centered layout if a designer so desires.
Tagspatch, redesign
Attached Filespatch file icon new-element-ids.patch [^] (5,433 bytes) 2010-06-05 02:42 [Show Content]

- Relationships
related to 0015721closedgrangeway Functionality to consider porting to master-2.0.x 

-  Notes
User avatar (0025850)
djcarr (reporter)
2010-06-14 23:52
edited on: 2010-06-14 23:53

I too have spent some time getting CSS control over the print_menu() function.

Instead of printing the <a href>s out directly, could they perhaps call a new function eg:

function string_get_menu_option_link( $page_url, $lang_string ) {
    return [a href="' . helper_mantis_url( $page_url ) . '"]' . lang_get( $lang_string ) . '[/a]';
}

    (replace [] with <>)

Then it becomes quite trivial for a customisation effort to wrap this with span or other tags using the $lang_string as the identifier.

User avatar (0026305)
daryn (developer)
2010-08-13 12:51

Patch merged with following changes:

Modified mantis wrapper to include plugin output for the EVENT_LAYOUT_BODY_BEGIN
and EVENT_LAYOUT_BODY_END events.

Modified menu-bar to be a class and named it main-menu-container as it the main
menu may appear above and below the content and with new styling may not be a bar.

Added a content wrapper to isolate the content from the template elements.
User avatar (0026453)
daryn (developer)
2010-08-24 10:27

Added some ids on bug change status page.
User avatar (0026463)
daryn (developer)
2010-08-25 02:09

Added ids and classes on view all bug filter.
User avatar (0036381)
grangeway (developer)
2013-04-05 17:57

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

- Related Changesets
MantisBT: master 0c379c9d
Timestamp: 2010-08-13 16:34:51
Author: daryn
Details ] Diff ]
Fix 0011995 - Merge patch for adding id's and classes to layout elements
with some minor changes. Added a content wrapper also.

Contributed-by: Brandon Jackson <brandonscottjackson@gmail.com
Signed-off-by: Daryn Warriner <daryn@iivip.com>
mod - core/html_api.php Diff ] File ]
MantisBT: master 729d5530
Timestamp: 2010-08-13 17:29:01
Author: daryn
Details ] Diff ]
Fix 0011995 - Add containers and ids to allow styling of various menus.
mod - core/html_api.php Diff ] File ]
MantisBT: master ca23cc99
Timestamp: 2010-08-24 14:23:37
Author: daryn
Details ] Diff ]
Bug 0011995 - Add a css id and name to bug change status form.
mod - bug_change_status_page.php Diff ] File ]
MantisBT: master a50748bb
Timestamp: 2010-08-24 14:24:37
Author: daryn
Details ] Diff ]
Bug 0011995 - Add css id to bugnote row on bug change status page. This should eventually
be a div rather than a table row.
mod - bug_change_status_page.php Diff ] File ]
MantisBT: master 6b5e037c
Timestamp: 2010-08-25 05:31:45
Author: daryn
Details ] Diff ]
Bug 0011826, Bug 0011995, Fix invalid html in the view all bug filter. Add divs, classes and id's
where necessary to facilitate moving style elements into css and inline
javascript into javascript files.
mod - css/default.css Diff ] File ]
mod - core/filter_api.php Diff ] File ]
mod - javascript/dev/common.js Diff ] File ]
mod - javascript/common.js Diff ] File ]
MantisBT: master 7ec1d497
Timestamp: 2010-08-27 17:00:51
Author: daryn
Details ] Diff ]
Issue 0011826 - Remove all inline JavaScript from MantisBT (use external scripts instead)
Issue 0011995 - Add CSS IDs to html elements for styling and javascript access.
mod - css/default.css Diff ] File ]
mod - core/html_api.php Diff ] File ]
mod - javascript/dev/common.js Diff ] File ]
mod - javascript/common.js Diff ] File ]

- Issue History
Date Modified Username Field Change
2010-06-05 02:41 brandonjackson New Issue
2010-06-05 02:42 brandonjackson File Added: new-element-ids.patch
2010-06-05 02:43 brandonjackson Tag Attached: patch
2010-06-14 23:52 djcarr Note Added: 0025850
2010-06-14 23:52 djcarr Note Edited: 0025850 View Revisions
2010-06-14 23:53 djcarr Note Edited: 0025850 View Revisions
2010-06-14 23:53 djcarr Note Edited: 0025850 View Revisions
2010-08-13 12:49 daryn Changeset attached => MantisBT master 0c379c9d
2010-08-13 12:49 daryn Assigned To => daryn
2010-08-13 12:49 daryn Resolution open => fixed
2010-08-13 12:49 daryn Fixed in Version => 1.3.x
2010-08-13 12:51 daryn Note Added: 0026305
2010-08-13 12:51 daryn Status new => assigned
2010-08-13 13:29 daryn Changeset attached => MantisBT master 729d5530
2010-08-24 10:25 daryn Changeset attached => MantisBT master a50748bb
2010-08-24 10:25 daryn Changeset attached => MantisBT master ca23cc99
2010-08-24 10:27 daryn Summary CSS IDs added to header => Add CSS IDs to html elements for styling and javascript access.
2010-08-24 10:27 daryn Note Added: 0026453
2010-08-25 02:05 daryn Changeset attached => MantisBT master 6b5e037c
2010-08-25 02:09 daryn Note Added: 0026463
2010-08-27 13:02 daryn Changeset attached => MantisBT master 7ec1d497
2010-09-28 20:12 daryn Tag Attached: redesign
2012-02-26 16:32 grangeway Status assigned => resolved
2013-04-05 17:57 grangeway Status resolved => acknowledged
2013-04-05 17:57 grangeway Note Added: 0036381
2013-04-05 18:14 grangeway Relationship added related to 0015721
2013-04-06 09:26 dregad Tag Attached: 2.0.x check
2013-04-06 09:26 dregad Status acknowledged => resolved
2013-04-27 17:47 atrol Target Version => 1.3.x
2014-09-23 18:05 grangeway Tag Detached: 2.0.x check


MantisBT 1.2.17 [^]
Copyright © 2000 - 2014 MantisBT Team
Time: 0.1208 seconds.
memory usage: 3,141 KB
Powered by Mantis Bugtracker