View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0011517 | mantisbt | code cleanup | public | 2010-02-18 07:32 | 2010-02-22 14:34 |
Reporter | atrol | Assigned To | dhx | ||
Priority | low | Severity | tweak | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.0rc2 | ||||
Target Version | 1.2.0 | Fixed in Version | 1.2.0 | ||
Summary | 0011517: Unnecessary code line in bug_api.php | ||||
Description | $t_field_count = 18; | ||||
Tags | No tags attached. | ||||
in my installation, following master-1.2.x (currently at commit 17c46c7c9047ab4727effeb6493fb435ce568795), $t_field_count appears just once in all of the code. line 431 of core/bug_api.php, as described above |
|
Thanks atrol! Committed a fix to clean up the unused variable. I'm not sure if you know how to use git, but I'd be very happy to sign off on a stream of small cleanup patches like this if they're in an easy to get format (such as a branch on MantisForge). It'd make it quite quick and easy to push through small changes. That is of course if you plan on doing further cleanups in the future - or are interested in committing patches yourself as a developer :) |
|
Could you please give me another formulation for the sentence: |
|
It'd be funny to know what it sounded like in German... it would have been very hard to translate :) To rephrase: If you're interested in making small code cleanup patches (changes) to MantisBT like the one mentioned in this bug report, maybe you could consider creating your own git branch at git.mantisforge.org? This would probably save you time writing out a bug report here, developers having to read bug reports, fix the code, commit it, update this bug report, etc. Instead you just let a developer know you've got a branch on mantisforge containing a number of small cleanup commits (patches) and we can merge them into the main repository with a single command. So if you plan on making more cleanup patches (please do - your time permitting - we desperately need help cleaning up old code), I am just reminding you of a faster and easier method for submitting patches. I don't mind receiving patches in any format, but it would be preferred (if possible) to save as much time and effort as possible for yourself and developers committing the patches. Thanks again for your help :) |
|
MantisBT: master-1.2.x 89b7e001 2010-02-18 08:52 Details Diff |
Fix 0011517: Cleanup unused variable in bug_api:update |
Affected Issues 0011517 |
|
mod - core/bug_api.php | Diff File | ||
MantisBT: master 01733186 2010-02-18 08:52 Details Diff |
Fix 0011517: Cleanup unused variable in bug_api:update |
Affected Issues 0011517 |
|
mod - core/bug_api.php | Diff File |