View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011038 | mantisbt | administration | public | 2009-10-14 07:38 | 2010-04-23 23:22 |
| Reporter | atrol | Assigned To | jreese | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | won't fix | ||
| Product Version | 1.2.0rc2 | ||||
| Summary | 0011038: allow_signup can not be set in database | ||||
| Description | in 1.1.x allow_signup can be disabled by database configuration, now I am told to change this in config_inc.php. I use as much configuration in database as possible. At first glance this seems to be a step backwards for me. Maybe you changed this, because the customization can be set per project and per user in 1.1 which makes not much sense. A configuration in database for the whole instance might be the right solution? | ||||
| Tags | No tags attached. | ||||
|
Setting "sensitive" or "global" configuration values in the database is generally discouraged for reasons of preventing loopholes in policy or security due to the way that database config values can be set on a per-project or per-user basis. However, there is a list of these "disallowed" values in the config_defaults_inc.php ($g_global_settings), so if you really want to allow these sorts of values to be stored in the database regardless of their sensitive nature (ie, you trust your database to not be compromised), then you can override that value in your config_inc.php to suit your own preferences. |
|
|
Funny: I have to change sourcecode to be able not to have change sourcecode ;-) No, I will not change your sourcecode, as you certainly know better than me why things are as they are. Or you will read this and maybe change something in future: If you changed the behaviour because database can be compromised you would also have to disallow further configurations which can be used by bad guys, for example: Please don't add this parameter to your list, I customized it in my database ;-) I think if database is compromised, there are many things which could be done by an MantisBT expert. But a compromised database can hardly be more problematic than for example a compromised config_defaults_inc.php or config_inc.php? I see two aspects: If you agree with me, please reopen the issue, maybe not as a bug but as a feature request:
If you don't agree, please take the time to comment my thoughts. |
|
|
I'm not asking you to change any sourcecode; I was suggesting that you override a configuration option that specifies what configuration options are allowed in the database. Overriding the setting in config_inc.php will still allow you to stay perfectly in sync with a "standard" installation. :) Now, I'm not the one that made this change to Mantis. However, I'm probably not going to be able to come to an agreement with you anyways, because I have a strong preference towards keeping as much configuration in config_inc.php as possible, because database configurations are not as transparent or easily modifiable as a file is. But then again, I'm not "normal" in any meaning of the word. :P |
|
|
Should this be resolved as a won't fix? |
|