Also, it would be really good if administrators could turn on wavatar or monsterid defaults.

Eg:
http://www.gravatar.com/avatar/3b3be63a4c2a439b013787725dfce802?d=identicon
http://www.gravatar.com/avatar/3b3be63a4c2a439b013787725dfce802?d=monsterid
http://www.gravatar.com/avatar/3b3be63a4c2a439b013787725dfce802?d=wavatar
http://www.gravatar.com/avatar/3b3be63a4c2a439b013787725dfce802?d=404

Forget the wavatar thing. I just noticed you can set:
$g_default_avatar = "wavatar";
in file config_inc.php and this will enable Wavatars!
Nice one.

I can see that the code snippets from the developer resources on the Gravatar website support the 1.2.0rc1 implementation, but I think that these developer resources are out of date.

My suggested implementation in core/user_api.php would be ...

function user_get_avatar( $p_user_id, $p_size = 80 ) {
$t_email = strtolower( user_get_email( $p_user_id ) );
if( is_blank( $t_email ) ) {
$t_result = false;
} else {
$t_default_image = config_get( 'default_avatar' );
$t_size = $p_size;

    $t_use_ssl = false;
    if( isset( $_SERVER['HTTPS'] ) && ( strtolower( $_SERVER['HTTPS'] ) != 'off' ) ) {
        $t_use_ssl = true;
    }

    if( !$t_use_ssl ) {
        $t_gravatar_domain = 'http://www.gravatar.com/avatar/';
    } else {
        $t_gravatar_domain = 'https://secure.gravatar.com/avatar/';
    }

    $t_avatar_url = $t_gravatar_domain . md5( $t_email ) . '.jpg&default=' . urlencode( $t_default_image ) . '&size=' . $t_size . '&;rating=G';
    $t_result = array(
        $t_avatar_url,
        $t_size,
        $t_size,
    );
}

return $t_result;

}

oops - there should be a ? after .jpg, not an &

dominik, you added a patch without any comments
Do we have to reopen the issue?
You changed &default to ?default
Should &size also be ?size and &rating be ?rating

Hi Atrol

Yes the issue should be reopened (I cannot do this I get an error "access denied")...

No the path is right, it's just the first & which should be an ? to mark the start of parameters...

Sorry for the missing clarifications...

Greetings Dominik

Dominik, I am wondering because I found ?s (short form of size) and ?r (short form of rating) when looking at the link that David provided
http://en.gravatar.com/site/implement/images/

Hi Atrol

You're right - there are two things to consider:

a) the old patch did only fix the semantically wrong url:

without patch:
http://www.gravatar.com/avatar/6edf05ec8a5816f00d1730a76b247f59&default=blabla&size=80&rating=G

with patch:
http://www.gravatar.com/avatar/6edf05ec8a5816f00d1730a76b247f59?default=blabla&size=80&rating=G

b) the new patch contains also the new short params:

with new patch:
http://www.gravatar.com/avatar/6edf05ec8a5816f00d1730a76b247f59?d=blabla&s=80&r=G

Thanks Dominik, I removed the old patch.

Fix committed to 1.2.x and master branches.

Well, only the first & needed to be changed to a ?, and their documentation says that both the short and long forms are acceptable, at which point I would prefer to use the lang forms to be more explicit. The patch I committed is therefore basically comparable to what Dominik submitted.

I agree to use the long form

Still confusing:
The example http://en.gravatar.com/site/implement/images/ uses ? for all parameters, not only the first one
but http://de.gravatar.com/site/implement/images/php/ uses ? and & mixed

I played with Firebug to test the size parameter.
& is working and ? is wrong.
So one part of the gravatar documentation is wrong and your patch is OK concerning ? and &

There is also another difference to the documentation
The allowed values for parameter rating are documented lower case. We use G (suitable for display on all websites with any audience type)
I tried G and g, both work.

So your patch is also OK concerning G and g