0010231: Assigned bug status cannot be changed to new?

(0021145)
giallu (developer)
2009-03-21 09:52

Just tested. The only problem I see is that the assigned=>new transition fails (or is ignored) silently.

Yes, looks like something to fix

(0021163)
jreese (administrator)
2009-03-23 16:21

is this a problem in 1.1.x as well?

(0021347)
bwrightson (reporter)
2009-03-31 23:57

I just removed the small chunk of code that was labeled "Handle auto-assigning" and everything seems to work fine. I couldn't find anything else that that particular piece of code did except create the problem outlined in this bug.

(0021350)
prabhurangan (reporter)
2009-04-01 06:26

@bwrightson

Thanks a lot. Issue has been fixed.

(0021356)
bwrightson (reporter)
2009-04-01 13:21

That patch "fixes" the reported issue at the expense of some functionality - I'll update it again tonight.

(0021357)
jreese (administrator)
2009-04-01 13:31

Attaching a related IRC log:

13:09 < bleftson> http://www.mantisbt.org/bugs/view.php?id=10231 [^]
13:10 < nuclear_eclipse> bleftson: that fix is "incorrect"; it removes a feature
13:11 < bleftson> that's what i thought, but i went through everything i could possibly think of 
and i couldn't 
      find anything that it caused to behave incorrectly
13:12 < nuclear_eclipse> the point of that code is: if you report/update a bug and set a handler 
while the status 
      is set to 'new', then MantisBT will automatically change the status to 'assigned' (or whatever 
the 
      configured status should be)
13:13 < nuclear_eclipse> however, it should probably have some sort of logic added that checks 
to see if the 
      status has been modified, in which case it shoudln't make that auto-assignment
13:13 < bleftson> right - i believe that still happens though when you remove that code - i think 
it's handled 
      elsewhere?
13:13 < nuclear_eclipse> no, it doesn't get handled anywhere else
13:13 < bleftson> maybe my confusion comes from terminology
13:13 < bleftson> handler = user?
13:15 < nuclear_eclipse> handler = user assigned to the issue
13:17 < bleftson> ah i see, i see

(0021359)
bwrightson (reporter)
2009-04-01 14:43

OK, the new patch (bug_10231_UPDATE.patch) should allow Assigned->New without killing auto-assign functionality.

(0021360)
jreese (administrator)
2009-04-01 14:57

Fix committed to 1.1.7 and 1.2.x development branches.

(0021368)
prabhurangan (reporter)
2009-04-02 03:17

@bwrightson

The new patch gives me some issue:

Parse error: syntax error, unexpected $end in C:\Documents and Settings\prabhu_rangan\workspace\mylo\bug_update.php on line 240

(0021371)
bwrightson (reporter)
2009-04-02 07:15

@prabhurangan

I'm sorry to hear that! I've been trying to reproduce this problem but I've been unable to. Question: I noticed that for you the error occurs on line 240, but my bug_update.php file doesn't even have 240 lines. Are you sure the error is not occurring for some other reason? It's usually do to a missing curly brace. Thoughts?

Related Changesets
MantisBT: master-1.1.x 02288569 Timestamp: 2009-04-01 03:04:53 Author: bwrightson [ Details ] [ Diff ]	Fix 0010231: Can't change bugs from Assigned to New Put in a check so that an issue won't be auto-assigned if the Handler is updated but the Status is not. <span class="signoff">Signed-off-by: John Reese <jreese@leetcode.net></span>
	mod - bug_update.php	[ Diff ] [ File ]

MantisBT: master 3b837f17 Timestamp: 2009-04-01 03:04:53 Author: bwrightson [ Details ] [ Diff ]	Fix 0010231: Can't change bugs from Assigned to New Put in a check so that an issue won't be auto-assigned if the Handler is updated but the Status is not. <span class="signoff">Signed-off-by: John Reese <jreese@leetcode.net></span>
	mod - bug_update.php	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2009-03-20 00:45	prabhurangan	New Issue
2009-03-21 09:50	giallu	Status	new => assigned
2009-03-21 09:50	giallu	Assigned To	=> giallu
2009-03-21 09:51	giallu	Assigned To	giallu =>
2009-03-21 09:51	giallu	Status	assigned => new
2009-03-21 09:52	giallu	Note Added: 0021145
2009-03-21 09:52	giallu	Status	new => confirmed
2009-03-23 16:21	jreese	Note Added: 0021163
2009-03-31 23:56	bwrightson	File Added: bug_10231.patch
2009-03-31 23:57	bwrightson	Note Added: 0021347
2009-04-01 06:26	prabhurangan	Note Added: 0021350
2009-04-01 13:21	bwrightson	Note Added: 0021356
2009-04-01 13:31	jreese	Note Added: 0021357
2009-04-01 14:42	bwrightson	File Added: bug_10231_UPDATE.patch
2009-04-01 14:43	bwrightson	Note Added: 0021359
2009-04-01 14:57	jreese	Note Added: 0021360
2009-04-01 14:57	jreese	Fixed in Version	=> 1.1.7
2009-04-01 14:57	jreese	Target Version	=> 1.1.7
2009-04-01 14:58	jreese	Status	confirmed => resolved
2009-04-01 14:58	jreese	Resolution	open => fixed
2009-04-01 14:58	jreese	Assigned To	=> jreese
2009-04-01 15:00	bwrightson	Changeset attached	master 3b837f17 =>
2009-04-01 15:00	bwrightson	Changeset attached	master-1.1.x 02288569 =>
2009-04-02 03:17	prabhurangan	Note Added: 0021368
2009-04-02 07:15	bwrightson	Note Added: 0021371
2009-04-20 09:49	jreese	Status	resolved => closed

Notes
(0021145) giallu (developer) 2009-03-21 09:52	Just tested. The only problem I see is that the assigned=>new transition fails (or is ignored) silently. Yes, looks like something to fix

(0021163) jreese (administrator) 2009-03-23 16:21	is this a problem in 1.1.x as well?

(0021347) bwrightson (reporter) 2009-03-31 23:57	I just removed the small chunk of code that was labeled "Handle auto-assigning" and everything seems to work fine. I couldn't find anything else that that particular piece of code did except create the problem outlined in this bug.

(0021350) prabhurangan (reporter) 2009-04-01 06:26	@bwrightson Thanks a lot. Issue has been fixed.

(0021356) bwrightson (reporter) 2009-04-01 13:21	That patch "fixes" the reported issue at the expense of some functionality - I'll update it again tonight.

(0021357) jreese (administrator) 2009-04-01 13:31	Attaching a related IRC log: 13:09 < bleftson> http://www.mantisbt.org/bugs/view.php?id=10231 [^] 13:10 < nuclear_eclipse> bleftson: that fix is "incorrect"; it removes a feature 13:11 < bleftson> that's what i thought, but i went through everything i could possibly think of and i couldn't find anything that it caused to behave incorrectly 13:12 < nuclear_eclipse> the point of that code is: if you report/update a bug and set a handler while the status is set to 'new', then MantisBT will automatically change the status to 'assigned' (or whatever the configured status should be) 13:13 < nuclear_eclipse> however, it should probably have some sort of logic added that checks to see if the status has been modified, in which case it shoudln't make that auto-assignment 13:13 < bleftson> right - i believe that still happens though when you remove that code - i think it's handled elsewhere? 13:13 < nuclear_eclipse> no, it doesn't get handled anywhere else 13:13 < bleftson> maybe my confusion comes from terminology 13:13 < bleftson> handler = user? 13:15 < nuclear_eclipse> handler = user assigned to the issue 13:17 < bleftson> ah i see, i see

(0021359) bwrightson (reporter) 2009-04-01 14:43	OK, the new patch (bug_10231_UPDATE.patch) should allow Assigned->New without killing auto-assign functionality.

(0021360) jreese (administrator) 2009-04-01 14:57	Fix committed to 1.1.7 and 1.2.x development branches.

(0021368) prabhurangan (reporter) 2009-04-02 03:17	@bwrightson The new patch gives me some issue: Parse error: syntax error, unexpected $end in C:\Documents and Settings\prabhu_rangan\workspace\mylo\bug_update.php on line 240

(0021371) bwrightson (reporter) 2009-04-02 07:15	@prabhurangan I'm sorry to hear that! I've been trying to reproduce this problem but I've been unable to. Question: I noticed that for you the error occurs on line 240, but my bug_update.php file doesn't even have 240 lines. Are you sure the error is not occurring for some other reason? It's usually do to a missing curly brace. Thoughts?

Relationships