Changesets: MantisBT
|
master fc771e16 2017-08-21 09:28 Committer: dregad Details Diff |
Timeline preserve parent script parameters Correctly preserve parent script parameters for navigation. Fixes: 0023251 |
Affected Issues 0023251 |
|
| mod - core/timeline_inc.php | Diff File | ||
|
master 0e56d6f2 2017-08-20 21:44 translatewiki.net Details Diff |
Localisation updates from https://translatewiki.net. | ||
| mod - lang/strings_interlingua.txt | Diff File | ||
| mod - lang/strings_swedish.txt | Diff File | ||
|
master fa9d727f 2017-08-20 12:51 Committer: atrol Details Diff |
Move notify user checkbox outside the form On manage user page, the "notify user" checkbox is not part of the user data, and is only used to trigger a notification if the form is saved. Move the item outside the form, next to the update button to better match the context of the action. Fixes: 0021695 |
Affected Issues 0021695 |
|
| mod - lang/strings_english.txt | Diff File | ||
| mod - manage_user_edit_page.php | Diff File | ||
|
master 10dcdd93 2017-08-20 10:53 Committer: dregad Details Diff |
Print class name when logging backtrace caller info If the caller function is a class method, print the class name alognside the function name in the log info. Fixes: 0023249 |
Affected Issues 0023249 |
|
| mod - core/logging_api.php | Diff File | ||
|
master 075369ab 2017-08-20 10:48 Committer: dregad Details Diff |
Add logging functionality for plugins - Create a new loglevel LOG_PLUGIN to write logs specifically from plugins. - Add function plugin_log_event() to wrap the log call for plugins. Fixes: 0022053 |
Affected Issues 0022053 |
|
| mod - config_defaults_inc.php | Diff File | ||
| mod - core/constant_inc.php | Diff File | ||
| mod - core/logging_api.php | Diff File | ||
| mod - core/plugin_api.php | Diff File | ||
| mod - docbook/Admin_Guide/en-US/config/logging.xml | Diff File | ||
|
master 16ed967b 2017-08-19 16:51 Committer: dregad Details Diff |
Exclude unlinked projects from custom fields filter Don't get data from custom field values from issues in projects that are not linked to the custom field. This data can exists if the field has been unlinked after data has been saved. When unlinking a field from a project, the stored values are not deleted, however they must be ignored. Fixes: 0019385 |
Affected Issues 0019385 |
|
| mod - core/filter_api.php | Diff File | ||
|
master 1c436505 2017-08-19 07:50 Committer: dregad Details Diff |
Deprecate access_has_any_project() This function may mislead into incorrect validations. Usually you want to check that a user meets a threshold for any project, but that threshold may be configured differently for each project, and the user may also have different access levels in each project due to private projects assignment. In that scenario, $p_access_level can't be a static threshold, but a "threshold identifier" instead, that must be evaluated for each project. Function "access_has_any_project_level()" provides that functionality, also covers the basic usage of this function. For such reasons, this function has been deprecated. Fixes: 0021654 |
Affected Issues 0021654 |
|
| mod - core/access_api.php | Diff File | ||
|
master 513dd1ab 2017-08-19 07:23 Committer: dregad Details Diff |
Replace usages of access_has_any_project() Use access_has_any_project_level() instead. |
||
| mod - core/bug_group_action_api.php | Diff File | ||
| mod - core/columns_api.php | Diff File | ||
| mod - core/filter_form_api.php | Diff File | ||
| mod - core/layout_api.php | Diff File | ||
|
master 5d0c9427 2017-08-19 05:18 Committer: dregad Details Diff |
Focus on current project selection To follow the expected behaviour of a standard dropdown selection list, make the list to be scrolled and focused on the currently selected project. Fixes: 0023248 |
Affected Issues 0023248 |
|
| mod - core/layout_api.php | Diff File | ||
| mod - js/common.js | Diff File | ||
|
master a152d85b 2017-08-19 02:31 Committer: dregad Details Diff |
Fix timetracking report with no category Don't require a category to be assigned to the bug as there is an option to not require a category ($g_allow_no_category) Fixes: 0022158 |
Affected Issues 0022158 |
|
| mod - core/billing_api.php | Diff File | ||
|
master 9f70532f 2017-08-18 03:35 Committer: dregad Details Diff |
Deprecate project_get_local_user_access_level() This function is redundant, with access_get_local_level() having the same functionality. Fixes: 0023242 |
Affected Issues 0023242 |
|
| mod - core/project_api.php | Diff File | ||
| mod - core/user_api.php | Diff File | ||
|
master 37918923 2017-08-18 03:09 Committer: dregad Details Diff |
Fix cache of linked fields for empty value Save an empty value for projects that don't have linked custom fields, so this result is also cached. |
||
| mod - core/custom_field_api.php | Diff File | ||
|
master 10ca3127 2017-08-18 02:48 Committer: dregad Details Diff |
Cache custom fields linked projects with main data Cache custom fields linked projects with main custom field definition. |
||
| mod - core/custom_field_api.php | Diff File | ||
|
master ade8dac9 2017-08-17 06:36 Committer: dregad Details Diff |
Better detection of config string as parameter Better determination in access_project_array_filter() of access level parameter, if it's a string or a threshold. If an integer number is passed as string, sill consider it as a integer threshold, instead of a string representing a confgiuration option. |
||
| mod - core/access_api.php | Diff File | ||
|
master 8fec1632 2017-08-17 05:39 translatewiki.net Details Diff |
Localisation updates from https://translatewiki.net. | ||
| mod - lang/strings_french.txt | Diff File | ||
| mod - lang/strings_galician.txt | Diff File | ||
| mod - lang/strings_macedonian.txt | Diff File | ||
| mod - lang/strings_russian.txt | Diff File | ||
|
master 188739ae 2017-08-17 05:33 Committer: atrol Details Diff |
Cache projects used in filter query The projects will be used to check access level, that will require reading the project rows from database. Making sure the projects rows are cached avoids having individual queries later for each project. |
||
| mod - core/filter_api.php | Diff File | ||
|
master 29c2912f 2017-08-17 05:05 Committer: atrol Details Diff |
Cache all needed projects for navbar layout Reduce DB query count by caching all needed projects for the navbar layout. Fixes: 0023237 |
Affected Issues 0023237 |
|
| mod - core/layout_api.php | Diff File | ||
|
master 85484ea4 2017-08-17 01:44 Committer: dregad Details Diff |
Fix time tracking stopwatch lag Prior to this, the stopwatch was lagging behind the real time and it was not possible to manually edit the time field. The lag was caused by the use of setTimeout to add to a counter each second. Browsers put inactive tabs to sleep for a few seconds, causing cumulative delays between each call to setTimeout. I have changed setTimeout to setInterval to better express the intention of calling a function in a loop and inside that function I have switched from a simple add to a counter, to calculate the diff in seconds between startTime and current time, using the moment.js library to help. Fixes 0022919 Signed-off-by: Damien Regad <dregad@mantisbt.org> |
Affected Issues 0022919 |
|
| mod - js/common.js | Diff File | ||
|
master fe444f15 2017-08-16 16:10 Committer: dregad Details Diff |
Custom field columns include subprojects fields Evaluate subprojects of current project to include readable custom fields in the available columns list. This allows adding a column for a custom field that is linked to a subproject, which is the default behaviour when selecting ALL_PROJECTS. Since columns are related to a project, but the filter by default shows issues from subproject, extending the behaviour for any project/subproject is consistent with the expectation that columns for those custom fields can be used for view-all-bug page Fixes: 0023233 |
Affected Issues 0023233 |
|
| mod - core/columns_api.php | Diff File | ||
|
master 224e4fb7 2017-08-16 11:49 Details Diff |
Correct button style on bug_update_page Fixes 0023227 |
Affected Issues 0023227 |
|
| mod - bug_update_page.php | Diff File | ||
|
master 3476b161 2017-08-16 04:11 Committer: dregad Details Diff |
Get accessible custom field values Rewrite custom_field_distinct_values() to retrieve only those values that are accessible by the user, according to either issue view permission, or custom field definition for view access level. Only values that are viewable by the user should be retrieved, so we must account for: - View issue permissions: if the issue is private or public. - Project level permissions: if a private project is accessible directly, or indirectly. - Limit view issues for reporters: if the option is enabled. - Custom field definition for viewing threshold Viewable issues can be resolved by using a filter, which already accounts for those restrictions. So here we only need to additionally check for custom field view threshold on each project. Fixes: 0016359 |
Affected Issues 0016359 |
|
| mod - core/custom_field_api.php | Diff File | ||
|
master fd38b5d3 2017-08-15 16:34 Committer: dregad Details Diff |
Account for project permission on custom fields filter When filtering on custom fields, return only issues where the custom fields is viewable by the user according to each project access level. Fixes: 0023223 |
Affected Issues 0023223 |
|
| mod - core/filter_api.php | Diff File | ||
|
master 19fb937b 2017-08-15 15:36 Committer: dregad Details Diff |
Get custom fields values from a list of projects Extend custom_field_distinct_values() to allow a list of projects to get values from. Extend the custom fields filter input to show values from all the projects included in the filter scope, which may also include subprojects. Fixes: 0016358 |
Affected Issues 0016358 |
|
| mod - core/custom_field_api.php | Diff File | ||
| mod - core/filter_form_api.php | Diff File | ||
|
master 79666331 2017-08-15 14:54 Committer: dregad Details Diff |
Add explicit check for ALL_PROJECTS in filter Provide a shortcut in filter_get_included_projects() to return ALL_PROJECTS if that value is found directly, or indirectly, in the filter. A parameter can be set to explicitly expand ALL_PROJECTS if required. |
||
| mod - core/filter_api.php | Diff File | ||
|
master b139b96d 2017-08-15 14:21 Committer: dregad Details Diff |
Include custom fields from all included projects When retrieving custom fields to show in the filter form, evaluate all projects included in the filter scope. Previously, evaluation of subprojects only happened when filtering from ALL_PROJECTS. Additionally, check access level for the defined view threshold, to only show those custom fields that are viewable by the user Fixes: 0005713, 0023232 |
Affected Issues 0005713, 0023232 |
|
| mod - core/filter_form_api.php | Diff File | ||
