View Issue Details

IDProjectCategoryView StatusLast Update
0009793mantisbtjavascriptpublic2014-12-08 00:34
Reporterswekey Assigned Todhx  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionduplicate 
Platformall 
Product Version1.2.0a2 
Target Version1.3.0-beta.1Fixed in Version1.3.0-beta.1 
Summary0009793: ActiveXObject emulation hack should be removed
Description

xmlhttprequest.js contains a nasty hack to emulate IE activex support:

// ActiveXObject emulation
if (!window.ActiveXObject && window.XMLHttpRequest) {
window.ActiveXObject = function(type) {
switch (type.toLowerCase()) {
case 'microsoft.xmlhttp':
case 'msxml2.xmlhttp':
return new XMLHttpRequest();
}
return null;
};
}

That's very bad since plugins can no longer rely on 'window.ActiveXObject' to check for activex support in the current browser.

This method is widely used when we try to embed a browser plugin (Flash Player for instance) to check of the browser should load the activex or the mozilla plugin.

TagsNo tags attached.

Relationships

duplicate of 0012631 closeddhx Replace old inline dynamic filter code with jQuery equivalent 
related to 0011826 closeddhx Remove all inline JavaScript from MantisBT (use external scripts instead) 
related to 0015721 closedgrangeway Functionality to consider porting to master-2.0.x 

Activities

vboctor

vboctor

2008-11-12 17:30

manager   ~0019860

Do you have a proposed patch?

dhx

dhx

2010-09-19 03:21

reporter   ~0026785

I can't believe the term "ActiveX" is contained within the MantisBT source. It's a disgrace and needs to be removed at once. Queued for 1.3.x :)

dhx

dhx

2010-12-26 07:57

reporter   ~0027701

Removed today as part of the fix for 0012631.

grangeway

grangeway

2013-04-05 17:57

reporter   ~0036314

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch