View Issue Details

IDProjectCategoryView StatusLast Update
0030992mantisbtdb mysqlpublic2022-09-26 12:21
Reporterstarlocke Assigned Todregad  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionwon't fix 
Product Version2.25.5 
Summary0030992: Exclude adodb-php v5.22.3 because it is faulty
Description

See https://github.com/ADOdb/ADOdb/issues/867

Pull request to exclude the faulty dependency: https://github.com/mantisbt/mantisbt/pull/1850

Steps To Reproduce

As of ~5 days ago, a fresh "compose update" execution will install adodb-php v5.22.3 which will produce a ton of "Object of class mysqli_result could not be converted to int in .../adodb.inc.php on line 3946" warning messages all over the UI, every place where queries are executed.

The "install results" page will be the first place where one experiences those error messages, with a fresh installation. With an existing installation, the vast majority of pages will be affected.

TagsNo tags attached.

Activities

dregad

dregad

2022-09-12 03:50

developer   ~0066987

Thanks for the report.

Yes this is a known issue as you pointed out. A patch is already available and ADOdb 5.22.4 will be released very soon to fix it.

That being said, we deliver MantisBT with a composer.lock file for a reason... You should be doing composer install instead of composer update. Note that MantisBT has NOT yet been fully tested and is not supported with ADOdb 5.22, this is why the Dependabot pull requests are not being merged right now.

Also, keep in mind that this is just a PHP Notice, not an error, which would not disrupt a site with default error reporting settings on PHP < 8.0 at all. On PHP 8, you can set error_reporting( E_ALL & ~E_NOTICE); as a workaround.

Consequently, I don't think it's worth updating our composer configuration for this.

starlocke

starlocke

2022-09-12 09:05

reporter   ~0066988

Ah. I see. Today I learned that compose.lock files are not resolved in "all-in-one" fashion and that per-dependency bumps can actually happen! :)