View Issue Details

IDProjectCategoryView StatusLast Update
0029257mantisbtbugtrackerpublic2021-11-26 15:16
Reportercas Assigned Todregad  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionno change required 
Product Version2.25.2 
Summary0029257: Duplicate-id is always shown when resolving an issue
Description

in bug_change_status.php the following code is used to determine if the duplicate-id should be shown:
if( $t_resolution != config_get( 'bug_duplicate_resolution' ) ) {
this is not correct im view, should be:
if( $t_resolution == config_get( 'bug_duplicate_resolution' ) ) {

TagsNo tags attached.

Activities

dregad

dregad

2021-11-09 13:11

developer   ~0066002

Remember we're generating a static page here - we need the Duplicate ID field shown so it is available when users select duplicate resolution. Otherwise, some JavaScript would be required to dynamically show/hide the field depending on value selected in Resolution.

The Duplicate ID field will be hidden when resolving an issue that has a relationship of type BUG_DUPLICATE.

cas

cas

2021-11-09 13:21

reporter   ~0066004

Oops, I would have expected it to work just the other way around.....

dregad

dregad

2021-11-10 03:52

developer   ~0066005

Last edited: 2021-11-10 03:59

The Duplicate ID field will be hidden when resolving an issue that has a relationship of type BUG_DUPLICATE.

Oops, I would have expected it to work just the other way around.....

This is debatable I guess, but the rationale is that we already have an associated duplicate bug ID in this case, so there is no need to ask the user for another one to add (which is what this field does).

cas

cas

2021-11-10 10:58

reporter   ~0066009

This needs to be validated. Because when I resolve an issue with resolution "Duplicate" there is no mandatory registration of the duplicate issue id which I would have expected based upon your explanation.

dregad

dregad

2021-11-11 08:29

developer   ~0066012

True, we currently do not enforce that. This allows the flexibility to mark an issue as duplicate, without requiring to specify an actual duplicate relation.

If the current behavior is not satisfactory for you, then I suggest you provide a detailed specification of how you think it should work.

Consider also the case of admins that may not want this to be mandatory; also what should happen in the case of multiple duplicates (technically possible since relationships are many-to-many), and in an upgrade scenario where duplicate relationship is mandatory, what to do with existing issues that do not have one. It could also happen that a duplicate relationship is deleted after the issue has been resolved; what to do in this case ?

Based on the above, I'm personally not in favor of making duplicate id field mandatory but again I'm open to discussion.

cas

cas

2021-11-11 08:41

reporter   ~0066013

I have to agree, given your arguments, that we should not make it mandatory.
Nevertheless the logic used currently is also not conclusive.
Think I would opt for a config option to show this field or not during resolving.

The field does not bother me personally, I looked into this because of a forum question