0025224: User not recognize when you try to update from 2.15 to 2.19 - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0025224	mantisbt	authentication	public	2019-01-15 05:27	2019-01-27 10:07

Reporter	rgoossen	Assigned To	atrol
Priority	normal	Severity	crash	Reproducibility	always
Status	closed	Resolution	no change required
Product Version	2.19.0

Summary	0025224: User not recognize when you try to update from 2.15 to 2.19
Description	Since this modification: https://github.com/mantisbt/mantisbt/commit/a5847f5fe7ea6a4b6ad3628582e9e7df90bd0ff1 It seems there are problems with the variable $g_cache_current_user_id from the authentification API. Maybe, the autor of this commit forget to change the null condition to NO_USER constant ?
Steps To Reproduce	When you try to login in with your account (admin for example), you get warning on the landing page from the user_api.php (user_get_field function). The application can't be used at all. To correct the problem, you'll have to change the condition in authentication_api at auth_get_current_user_id() function. You need to change `if( null !== $g_cache_current_user_id )` => `if( NO_USER !== $g_cache_current_user_id ) {`
Tags	No tags attached.

dregad 2019-01-15 05:36 developer ~0061236	Possible regression introduced by 0024931 (did not actually test myself).

rgoossen 2019-01-15 05:46 reporter ~0061237 Last edited: 2019-01-15 05:47	My bad ... The update wasn't completely done ! Didn't understand why some line were modified and not others.... But it works !

atrol 2019-01-15 05:51 developer ~0061238	Right, there is obviously something wrong with your installation. https://github.com/mantisbt/mantisbt/blame/release-2.19.0/core/authentication_api.php#L1081