View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0024976 | mantisbt | ui | public | 2018-11-14 14:40 | 2019-01-02 17:25 |
Reporter | zdenek | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 2.13.0 | ||||
Target Version | 2.19.0 | Fixed in Version | 2.19.0 | ||
Summary | 0024976: Sidebar's collapsed state is not preserved | ||||
Description | If I collapse the left sidebar (buttons My View, View Issues, ...) and navigate to another issue, the sidebar is show in uncollapsed state. It would be nice if the sidebar's state was preserved through all pages. | ||||
Tags | No tags attached. | ||||
Are you able to reproduce it on https://www.mantisbt.org/bugs ? |
|
Yes, I'm. |
|
Changed version, as the bug has been introduced in 2.13.0. |
|
I've tried your patch and it works like a charm. |
|
Thanks @zdenek for confirming the fix. |
|
MantisBT: master b5ea0dd1 2018-11-16 04:26 Committer: atrol Details Diff |
Proper fix for duplicate 'sidebar' div ID The initial attempt at fixing this issue [1] introduced a regression in the persistence of the sidebar's collapse state. Using a different ID for the toggle button or the sidebar div caused other issues (e.g. malfunctioning hambuger menu on narrow screens, or failure to save collapse state). The root cause was a bug in the javascript code saving the sidebar's state, which was referencing the toggle button's id instead of the sidebar div's. We now have ID 'sidebar' for the actual sidebar, and 'sidebar-btn' for the toggle button, and the javascript has been modified accordingly. Fixes 0024976 [1]: commit b7b914549fe8fbdf4ee4053f475031df9d6a4674 |
Affected Issues 0024976 |
|
mod - core/layout_api.php | Diff File | ||
mod - js/common.js | Diff File |