View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0021683 | mantisbt | ui | public | 2016-09-10 05:12 | 2016-10-02 18:41 |
| Reporter | dregad | Assigned To | dregad | ||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 2.0.0-beta.1 | ||||
| Target Version | 2.0.0-beta.3 | Fixed in Version | 2.0.0-beta.3 | ||
| Summary | 0021683: Standardize "operation successful" messages | ||||
| Description | We have an API function, html_operation_successful(), which displays a standard confirmation message with a "Proceed" button. This function is not always used, sometimes we have custom HTML to display the message. In some cases this is required to display a non-standard message or multiple buttons, in others it is really not necessary. We should offer API functions to avoid use of custom HTML. | ||||
| Tags | No tags attached. | ||||
|
MantisBT: master e6a2378e 2016-09-10 00:54 Details Diff |
Use html_operation_successful() instead of custom layout Fixes 0021683 |
Affected Issues 0021683 |
|
| mod - manage_user_create.php | Diff File | ||
| mod - manage_user_reset.php | Diff File | ||
| mod - manage_user_update.php | Diff File | ||
| mod - query_delete.php | Diff File | ||
|
MantisBT: master d14b3089 2016-09-10 00:57 Details Diff |
New html_operation_successful_buttons() function The new API function expands the existing html_operation_successful(), allowing display of multiple redirect buttons instead of a single 'Proceed' link. Fixes 0021683 |
Affected Issues 0021683 |
|
| mod - core/html_api.php | Diff File | ||
|
MantisBT: master 3f610629 2016-09-10 01:04 Details Diff |
Use new API for pages with multiple redirection links - bug_report.php - news_update.php Fixes 0021683 |
Affected Issues 0021683 |
|
| mod - bug_report.php | Diff File | ||
| mod - news_update.php | Diff File | ||
|
MantisBT: master c1359323 2016-09-10 01:32 Details Diff |
Remove spacing between the redirection buttons To be consistent with the rest of the UI where the buttons are printed right next to each other, remove the and wrap them in a btn-group div. Issue 0021683 |
Affected Issues 0021683 |
|
| mod - core/html_api.php | Diff File | ||
|
MantisBT: master 6d4a5fe2 2016-09-10 01:46 Details Diff |
New functions for warning and failure confirmations Modify html_operation_successful_buttons() to accept an optional type parameter, allowing caller to specify the type of confirmation message to display (success, warning, failure). Add 2 new functions and corresponding language strings: - html_operation_warning() - html_operation_failure() Fixes 0021683 |
Affected Issues 0021683 |
|
| mod - core/html_api.php | Diff File | ||
| mod - lang/strings_english.txt | Diff File | ||
|
MantisBT: master 750950da 2016-09-10 01:51 Details Diff |
Use constants instead of hardcoding values Define 3 new constants to replace string values: - 'success' -> CONFIRMATION_TYPE_SUCCESS, - 'warning' -> CONFIRMATION_TYPE_WARNING, - 'failure' -> CONFIRMATION_TYPE_FAILURE. Issue 0021683 |
Affected Issues 0021683 |
|
| mod - core/constant_inc.php | Diff File | ||
| mod - core/html_api.php | Diff File | ||
|
MantisBT: master 0c00cc9e 2016-09-10 04:24 Details Diff |
More replacements of custom layout by html_operation_xxx() Issue 0021683 |
Affected Issues 0021683 |
|
| mod - core/access_api.php | Diff File | ||
| mod - lost_pwd.php | Diff File | ||
|
MantisBT: master 49728830 2016-09-10 04:34 Details Diff |
Only append default message when none provided If the caller provided a custom message, then we display it as-is, without appending the default one based on confirmation type. This gives more flexibility to the caller when displaying confirmation messages. Issue 0021683 |
Affected Issues 0021683 |
|
| mod - core/html_api.php | Diff File | ||
|
MantisBT: master a7ae02da 2016-09-20 23:37 Details Diff |
Standardize "operation successful" messages Adding new API functions to handle display of confirmation messages, and replace custom HTML in various files to display the same by calls to these functions. Fixes 0021683 Merge PR https://github.com/mantisbt/mantisbt/pull/884 |
Affected Issues 0021683 |
|
| mod - bug_report.php | Diff File | ||
| mod - core/access_api.php | Diff File | ||
| mod - core/constant_inc.php | Diff File | ||
| mod - core/html_api.php | Diff File | ||
| mod - lang/strings_english.txt | Diff File | ||
| mod - lost_pwd.php | Diff File | ||
| mod - manage_user_create.php | Diff File | ||
| mod - manage_user_reset.php | Diff File | ||
| mod - manage_user_update.php | Diff File | ||
| mod - news_update.php | Diff File | ||
| mod - query_delete.php | Diff File | ||
|
MantisBT: master 9882d64f 2016-09-22 03:11 Details Diff |
Fix bug_report.php regressions Commit a7ae02dae5e20ba498520551984be026fc658005 (issue 0021683) introduced 2 regressions when displaying bug report page: - Confirmation message as '0': due to a missing parameter in the html_operation_confirmation() call - Incorrect display of the footer: caused by an extra div tag Fixes 0021710 |
Affected Issues 0021683, 0021710 |
|
| mod - bug_report.php | Diff File | ||
