View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020682 | mantisbt | bugtracker | public | 2016-03-09 18:32 | 2016-08-28 01:12 |
Reporter | cproensa | Assigned To | cproensa | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-rc.2 | ||||
Target Version | 1.3.1 | Fixed in Version | 1.3.1 | ||
Summary | 0020682: Workflow transitions not consistent with bug action "change status to" | ||||
Description | When configuring a status that has no "outbound" status, this is, in workflow configuration, there is no other status marked as allowed to move to. In practice, this means that any transition, from this status to any other, is allowed (this probably is implemented for not locking an issue in a dead end status) However, in view_bug, even if the transition is possible, the option for "change status to" is not present. I'd rather have the possibility to configure a status that cant be transitioned into any other.
Note that these use cases are not satisfied by the options "Minimum Access Level to Change to this Status", becasue they'd need to be "changing FROM this status" Additionally: A status without a transitions row, which is defaulted to all transitions, it still shows: | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Any opinions on this? IMO, transistions should comply strictly to the workflow settings: |
|
This seems like a breaking change and may confuse users when all of a sudden they are not able to do things that they were able to do before. So it may be worth exploring other options. One option is to enable plugins to filter the valid target statuses for an issue. This may be dependent on plugin logic, issue details beyond status, etc. |
|
Se the attached screenshot for a bug in such status. So one issue, is that the status selector should be available, according to current logic. A secondary issue, but no less important: |
|
@vboctor regarding defaults: This is from config_defaults_inc Note this inconsistency again: I suggest setting this semantics: 2) If any row is not set
3) make the workflow config save an empty array if no status are checked, so tha: I have tested that hardcoding status_enum_workflow[STATUS] = '' |
|
Updated description with another inconsistency: A status without a transitions row, which is defaulted to all transitions, it still shows: |
|
submitted PR: https://github.com/mantisbt/mantisbt/pull/836 It does not break current configurations and behaviour. |
|
MantisBT: master-1.3.x c2bee49c 2016-08-04 08:54 Committer: dregad Details Diff |
Modify empty and default cases for workflow configuration Fix several inconsistencies with the treatment of status_enum_workflow configuration. 1. Fix showing a non existant status row in workflow config array. This is interpreted as if that status allows all transitions, but in the config page, the checks were shown unmarked, which can be confusing. Now the checks appear marked in this situation. 2. As consequence of (1), the message "You cannot move an issue out of this status" is not show anymore in that situation. 3. When a status row is saved with all transitions unchecked, an empty enum string is saved, meaning effectively that no transitions are allowed from that status. This specific configuration was previously unavailable from the workflow config page. Fixes 0020682 Signed-off-by: Damien Regad <dregad@mantisbt.org> Original commit message reworded and formatted |
Affected Issues 0020682 |
|
mod - core/workflow_api.php | Diff File | ||
mod - manage_config_workflow_set.php | Diff File |