View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0020641 | mantisbt | ui | public | 2016-02-28 05:45 | 2016-06-12 00:42 |
Reporter | dregad | Assigned To | vboctor | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.3.0-rc.2 | ||||
Target Version | 1.3.0-rc.2 | Fixed in Version | 1.3.0-rc.2 | ||
Summary | 0020641: When $g_show_avatar = OFF, no avatar should be displayed | ||||
Description | This works fine in bug view page, but the Timeline always shows an anonymous avatar. | ||||
Tags | avatar | ||||
I'm of the opinion that we should always have avatars ON. This is consistent with all modern services and makes our life easier in terms of layouts. The only concern I heard before if users don't want their MantisBT communicating with external services. In that case, they can have avatars ON, gravatar OFF, and possibly some other providers (e.g. file based or LDAP based, upload your photo) to serve these avatars. To have a good story, I think we should implement another provider to enable users to upload their avatar picture to MantisBT. |
|
I disagree. I believe we should provide admin the choice to use them or not, even if personally I like to use them.
This was part of my original roadmap. |
|
Please make OFF a real OFF: leave out the placeholder image, too (PR 728)! |
|
If we are going to offer the feature of uploading avatars + the gravatar approach, why would it be necessary to turn avatars off. There is no way to do the same in internet services like github, why is it an expectation to be able to do this in MantisBT? |
|
Because MantisBT is not just an "internet service", but also an intranet application where someone may not want or care about such feature. We don't even need a config option for that - no Avatar plugin installed = no avatars displayed. |
|
I agree with the issue.
probably a local avatar storage, its a popular request. |
|
OK, I'll think through the approach to support disabling avatars either explicitly or implicitly via having no avatar plugins installed. Will post a info here or a pull request once done. @cproensa local avatar storage / ldap ones are good candidates. But I was mentioning the upload ones since it allows end users to manage their own avatars rather than their admin or having a dependency on LDAP for example. |
|
a local avatar plugin could provide a page to manage user own image, through "my account" page. |
|
A workaround if that is really a problem, is to have a transparent image, as no avatar when th config is OFF. |
|
MantisBT: master a05fca6e 2016-03-09 18:24 Committer: dregad Details Diff |
Don't show avatar when it's off If avatar is off or user doesn't have access to see it then don't show an avatar image. Fixes 0020641 |
Affected Issues 0020641 |
|
mod - core/classes/Avatar.class.php | Diff File | ||
mod - core/classes/TimelineEvent.class.php | Diff File | ||
mod - core/print_api.php | Diff File |