View Issue Details

IDProjectCategoryView StatusLast Update
0020217mantisbtplug-inspublic2019-01-11 06:39
Reportercproensa Assigned Tocproensa  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.3.0-beta.3 
Target Version1.3.0-rc.1Fixed in Version1.3.0-rc.1 
Summary0020217: MantisGraph: dont show links for users without access level
Description

The link for the plugin MantisGraph is showed to all users, even those who dont have access to the page, which results in an "access denied" error

TagsNo tags attached.
Attached Files
Selección_075.png (55,005 bytes)   
Selección_075.png (55,005 bytes)   

Relationships

related to 0020954 closedatrol Graph Problem 

Activities

cproensa

cproensa

2015-10-23 08:04

developer   ~0051685

trivial fix, PR: https://github.com/mantisbt/mantisbt/pull/663

dregad

dregad

2015-10-23 19:47

developer   ~0051696

Thanks for your contribution !

atrol

atrol

2015-10-29 06:00

developer   ~0051746

This introduces a regression.
I get an empty login page.

No time to have a deeper look at the moment, but access_has_project_level is causing issues if you are not logged in (there is no current user and no current project at this moment)

cproensa

cproensa

2015-10-29 06:07

developer   ~0051748

Atrol, i think that happens with 1.2?

Plugin init sequence is different in 1.3. At the time the hooks() are called, the core functions are ready

atrol

atrol

2015-10-29 06:18

developer   ~0051749

Last edited: 2015-10-29 06:23

This piece of code is called now when visiting the login page (login_page.php)

  • if( access_has_project_level( config_get( 'view_summary_threshold' ) ) ) {
  • $t_hooks['EVENT_MENU_FILTER'] = 'graph_filter_menu';
  • }

Is this what you expect?

cproensa

cproensa

2015-10-29 07:42

developer   ~0051751

you are right, the problem is when aonyomous login is disabled
This is the correction
PR:https://github.com/mantisbt/mantisbt/pull/667

Related Changesets

MantisBT: master 738272f2

2015-10-23 03:59

cproensa

Committer: dregad


Details Diff
Don't show MantisGraph link for users without access

fixes 0020217

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0020217
mod - plugins/MantisGraph/MantisGraph.php Diff File

MantisBT: master 2c0b2a59

2015-10-29 03:32

cproensa

Committer: dregad


Details Diff
Revert 738272f and reimplement hide graph link

commit 738272f23900243de35b5f0ce29564274bad3090 to hide Mantisgraph link
introduced a regression: failing at login when anonymous login is
disabled.

Here that change is reverted and the access level check is now placed in
the callback function, instead of the hook initialization

Fixes 0020217

Signed-off-by: Damien Regad <dregad@mantisbt.org>
Affected Issues
0020217
mod - plugins/MantisGraph/MantisGraph.php Diff File