We don't have a standalone function to copy attachments, are you referring to issue Cloning ?

I mean function file_copy_attachments() of file_api

We should set user_id to the user who is creating the copy (not the user that added the original attachment)

Furthermore we should set date_added to the current date (we copy this information from original attachment at the moment)

PR for review https://github.com/mantisbt/mantisbt/pull/630

For the record, this problem exists also in 1.2.x branch, so the fix should probably be backported.

Following the proposed implementation following atrol's suggestion in 0020018:0051228, a discussion took place in the pull request. Maybe a more targeted fix just correcting the erroneous behavior as reported by badfiles is the better way to go.

Sorry about that, I inadvertantly pushed to mantisbt instead of my own fork.

PR, take 2 https://github.com/mantisbt/mantisbt/pull/632

Roland, as per the discussion in the previous PR and since you were the one proposing the change in behavior, I let you open another issue to track and discuss it (as per vboctor's suggestion) if you feel it's necessary.

Backported to 1.2.x