View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0019700 | mantisbt | filters | public | 2015-05-08 16:41 | 2017-01-31 04:02 |
Reporter | fgalvis | Assigned To | cproensa | ||
Priority | low | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.19 | ||||
Target Version | 2.1.0 | Fixed in Version | 2.1.0 | ||
Summary | 0019700: Filters table on the view_all_bug_page.php shows empty lines when $g_enable_profiles is set to OFF | ||||
Description | The filters table in the view_all_bug_page.php shows the empty lines of the filters not loaded because of the config_inc.php of the profiles is set to OFF This leaves unpleasant empty rows on the screen. | ||||
Steps To Reproduce |
| ||||
Additional Information | Ist a minor tweak but its visualy unpleasant Solution proposal: Change the filters_api.php where it makes the verification if the profiles are ON outside of the <tr> label filters_php.api line 2961 | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
I have managed to solve the Issue with the proposed solution.
|
|
This row also displays the tags filter, which you appear to have disabled; applying your fix would hide tag filtering, regardless of $g_tag_view_threshold setting. Your proposed patch can't be applied as it is. Furthermore, instead of proposing your change as a screenshot from your code editor, it would be much better if you submitted your changes as a pull request on Github, a git patch or a unified diff. |
|
I know, but for now this solved the requeriments for my company (we dont use the tags), i did not made a PR because i think the report must be aproved here first. If somenone can come up with a better solution will be nice. I think syncguru on the modern UI made progress in this matter, I will check his code. thanks dregad. |
|
Let us know if you come up with a better patch. And don't hesitate to submit a PR (reference this issue in it), the detailed discussion on the code can also take place on Github. |
|
<?php if( ON == config_get( 'enable_profiles' ) OR access_has_global_level( config_get( 'tag_view_threshold' ) ) ) { ?> |
|
JulienR, Providing patches is highly appreciated, but please do so in a way that allows us to integrate them easily. You can do this in several ways. In the order of preference:
Kindly avoid to upload entire modified PHP files or random code snippets. Please make sure that your submissions adhere to our Coding Guidelines [2], if they don't your patch might be rejected. [1] https://github.com/mantisbt/mantisbt |
|
Please dregad close this, not going to make PR, its and old visual issue and I don't know if the 1.3 version will make changes on the layout or the css. Also the modern version of mantis from Syncguru will be used in the 2.0 version ( if i am not wrong ) so this should be adressed there. I changed the code to include several flags in the cofiguration file ( aka config_inc.php ) to allow the users to select what parts of the filter must be shown and whatnot. If anyone is interested in these changes you can message me in the forums. |
|
track as included in PR 862 |
|