View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0018050 | mantisbt | installation | public | 2015-01-22 03:58 | 2015-05-27 12:49 |
Reporter | foXen | Assigned To | dregad | ||
Priority | normal | Severity | tweak | Reproducibility | always |
Status | closed | Resolution | no change required | ||
Product Version | 1.3.0-beta.1 | ||||
Summary | 0018050: Warnings on display_errors and display_startup_errors while there is all right | ||||
Description | Both checks in check_php_inc.php do "!ini_get_bool" instead of not negating that. So, you get a warning, while everything is OK (and vice versa?). check_print_test_warn_row( check_print_test_warn_row( | ||||
Steps To Reproduce | Simply extract new download anbd perform check.php | ||||
Tags | No tags attached. | ||||
I'm sorry! So in my environment display_startup_errors IS set to "On"... and your warning is right. BUT: As it is display as: Would like to change the "Auswirkung" to "Unschönheit". |
|
As you pointed out, this test works exactly as designed. In terms of wording: the checks's first line should always be read as "Check that ...", and the following lines (in italics) indicate the outcome of the test, i.e. why it failed or triggered a warning. I may be biased, but I think it's pretty clear. If you think otherwise, you're welcome to suggest a better wording. Your last line is confusing (sorry my German is not so good) - you want to change the "Impact" to ??? |
|
He means: Set "Severity" to "Tweak" |
|
Yes it's only wording and therefor just a Tweak. :) What about prefixing the first lines with something like "Check that " or "Checking: "? That way it's easier/simpler to understand for new mantis-admins and those that don't update regularly. PS: Maybe also change this subject. :/ |
|
I don't really like the idea of prefixing the lines, it makes the output very repetitive without much benefit (not really clearer) my opinion ... Check that xxxxx |
|
Your right, my last suggestion wasn't thought well. But what about replacing the word "is" with "should be"? |
|
OK. If you do come up with something better, I suggest you submit your proposed changes as a pull request on Github [1] |
|
Since you did not provide any feedback, I'm resolving this as no change required. Feel free to reopen this if and when you can propose specific changes |
|