0017917: Remove magic constants in filter_api.php / view_all_set.php - MantisBT

ID	Project	Category	View Status	Date Submitted	Last Update

0017917	mantisbt	code cleanup	public	2014-11-24 11:54	2016-10-20 11:07

Reporter	dregad	Assigned To
Priority	low	Severity	tweak	Reproducibility	N/A
Status	new	Resolution	open
Product Version	1.2.18

Summary	0017917: Remove magic constants in filter_api.php / view_all_set.php
Description	As part of reviewing PR https://github.com/mantisbt/mantisbt/pull/549 I noted we're using magic constant '6'. We should define it, as well as other values for type (and possibly 'simple' and 'advanced' also) in constants_inc.php.
Tags	No tags attached.

dregad 2015-09-11 08:29 developer ~0051448	atrol, I fail to see a relationship with 0020102, can you clarify ?

atrol 2015-09-11 09:22 developer ~0051449	I fail to see a relationship Me too ;-) Should have been 17919

cproensa 2016-10-20 07:48 developer ~0054300	i doubt if include this in PR 862 i fear that it will modify many more pages and will complicate the merge... what do you think? fix it at a later step, or go once for all?

dregad 2016-10-20 11:07 developer ~0054305	This is a low priority, code cleanup task so I'm fine with postponing this. The refactoring PR is big and complex enough as it is ;-)