View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016771 | mantisbt | administration | public | 2013-12-30 02:34 | 2016-01-22 13:56 |
Reporter | benv8 | Assigned To | dregad | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.15 | ||||
Target Version | 1.3.0-rc.1 | Fixed in Version | 1.3.0-rc.1 | ||
Summary | 0016771: workflow configuration | ||||
Description | I have a problem when I submit the form the page workflow configurations "thresholds that affect Workflow" are not good. manage_config_workflow_set.php The current code: foreach( $t_valid_thresholds as $t_threshold ) { If new value is equal to parent and access has not changed
The comment does not match what is being done: If new value is equal to the parent and access HAS not changedMore functionally if it is the same as the parent project parameterization why delete it if the parent project that you do not want to change the sub-project is changed. the code should look like :
| ||||
Tags | No tags attached. | ||||
Attached Files | |||||
related to | 0014496 | closed | dregad | CVE-2012-5522 Workflow Transitions: Minimal Access Level to Change to this status has no correct 'default' |
has duplicate | 0020441 | closed | dregad | Thresholds that Affect Workflow configuration deleted when not changed |
has duplicate | 0019695 | closed | cproensa | Error in page "manage_config_workflow_set.php" |
related to | 0019970 | closed | dregad | Status to which reopened issues are set drops to 'feedback' |
No time for a deeper look at the moment. |
|
Reminder sent to: dregad I found still no time to have a deeper look at it and I don't like to introduce a regression as your commit fixed a security issue. |
|
MantisBT: master a8f1c088 2015-09-10 13:37 Committer: dregad Details Diff |
Fix Workflow Transitions reverted to default when saving Some fields were reverted to default setting when updating the page twice. Corrections: - lookup proper variable 'set_status_threshold' when performing access check, as well as when updating the threshold - compare against parent settings instead of current Fixes 0019970, 0016771 Signed-off-by: Damien Regad <dregad@mantisbt.org> Changes from original commit: - whitespace - reworded commit message |
Affected Issues 0016771, 0019970 |
|
mod - manage_config_workflow_set.php | Diff File | ||
MantisBT: master b36e56ab 2015-10-30 08:40 Details Diff |
Fix warning 'config option "threshold_xxx" not found' The original fix prepended 'threshold_' to $t_threshold, which is incorrect (maybe a copy/paste error ?). The 'threshold_' prefix is used to determine the name of the corresponding GPC variable's name; $t_threshold already contains the correct config option's name. Fixes 0019970, 0016771 |
Affected Issues 0016771, 0019970 |
|
mod - manage_config_workflow_set.php | Diff File | ||
MantisBT: master 63bbb193 2015-10-31 15:56 Details Diff |
Fix resetting of access level when updating workflow If the access level needed to update a Threshold has been changed from default, it is reset to that default value when the workflow configuration is updated again without changes to that Threshold. This commit fixes the incorrect behavior by applying the same mechanism used to detect a change in the status to the access level, i.e. comparing the updated access level with the parent and not the current value. Fixes 0016771 |
Affected Issues 0016771 |
|
mod - manage_config_workflow_set.php | Diff File | ||
MantisBT: master 576fd772 2015-11-03 09:24 Committer: dregad Details Diff |
Fix resetting of access level when updating workflow This is the same fix as 63bbb19393c3a2b9bdc7e159992c160561a7ce09, and addresses the incorrect behavior for the fields - Who can change workflow - Who can change access levels by applying the same mechanism used to detect a change in the status to the access level, i.e. comparing the updated access level with the parent and not the current value. Fixes 0016771 Signed-off-by: Damien Regad <dregad@mantisbt.org> Original commit message reworded |
Affected Issues 0016771 |
|
mod - manage_config_workflow_set.php | Diff File |