View Issue Details

IDProjectCategoryView StatusLast Update
0015470mantisbtbugtrackerpublic2014-09-23 18:05
Reporterdregad Assigned Todregad  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.14 
Target Version1.2.15Fixed in Version1.2.15 
Summary0015470: Reminders recipient list is truncated
Description

If user requests sending reminders to a large number of recipients, the code truncates the list to 50 (hardcoded). Problems:

  • there is no indication to user that the list was truncated (looking at the REMINDER bugnote)
  • If the actual list of user ID's built is longer than 250 chars (which will happen before the limit of 50 is reached, if user id's are longer than 4 digits
TagsNo tags attached.

Relationships

related to 0010372 closeddregad Don't allow reminders to be sent if the user doesn't have an email address specificed 
related to 0015721 closedgrangeway Functionality to consider porting to master-2.0.x 

Activities

grangeway

grangeway

2013-04-05 17:56

reporter   ~0036096

Marking as 'acknowledged' not resolved/closed to track that change gets ported to master-2.0.x branch

dregad

dregad

2013-04-10 20:05

developer   ~0036569

An alternative way of fixing this issue could be to cap the max number of recipients to something we are sure will fit in the field, e.g.

(250 - 2) / (user_id max length + 1) = 35 for 6 digits user_id, 31 for 7 digits.

Related Changesets

MantisBT: master-1.2.x bf6f0c6a

2013-02-07 05:56

dregad


Details Diff
Improve handling of reminders' recipients list truncation

Replaced the previous method of truncating the list to a hardcoded
number of entries (50), to a more robust approach based on the size of
the underlying database field (250 chars, note_attr in bugnote table).

Added a message on the REMINDER bugnote, to inform user that the list of
recipients stored with the note, was actually truncated (Users should
refer to the issue's history to see who actually received the reminder).

This functionality relies on a hack, i.e. to indicate that the list was
truncated, bug_reminder.php is not storing the trailing delimiter in the
note_attr field, and this is picked up in bugnote_view_inc.php to
display the note to the user's attention.

Fixes 0015470
Affected Issues
0015470
mod - bug_reminder.php Diff File
mod - bugnote_view_inc.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master 4429c8f7

2013-02-07 05:56

dregad


Details Diff
Improve handling of reminders' recipients list truncation

Replaced the previous method of truncating the list to a hardcoded
number of entries (50), to a more robust approach based on the size of
the underlying database field (250 chars, note_attr in bugnote table).

Added a message on the REMINDER bugnote, to inform user that the list of
recipients stored with the note, was actually truncated (Users should
refer to the issue's history to see who actually received the reminder).

This functionality relies on a hack, i.e. to indicate that the list was
truncated, bug_reminder.php is not storing the trailing delimiter in the
note_attr field, and this is picked up in bugnote_view_inc.php to
display the note to the user's attention.

Fixes 0015470
Affected Issues
0015470
mod - bug_reminder.php Diff File
mod - bugnote_view_inc.php Diff File
mod - lang/strings_english.txt Diff File

MantisBT: master d95eeae7

2013-04-10 22:06

dregad


Details Diff
Revised reminder_list_truncated string

Follow-up on revert commit for issue 0002971, as we don't store recipients
in history anymore.

Affects issue 0015470
Affected Issues
0002971, 0015470
mod - lang/strings_english.txt Diff File

MantisBT: master-1.2.x bb6b113d

2013-04-10 22:06

dregad


Details Diff
Revised reminder_list_truncated string

Follow-up on revert commit for issue 0002971, as we don't store recipients
in history anymore.

Affects issue 0015470
Affected Issues
0002971, 0015470
mod - lang/strings_english.txt Diff File