View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0011604 | mantisbt | change log | public | 2010-03-03 10:24 | 2017-01-31 04:02 |
Reporter | otilia.borreta | Assigned To | vboctor | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.2.0 | ||||
Target Version | 2.1.0 | Fixed in Version | 2.1.0 | ||
Summary | 0011604: Versions marked as obsolete appear on change log page | ||||
Description | As far as I understood, obsolete versions shouldn't appear on the change-log page. I quick-fixed it here by commenting out the line 143 in changelog_page.php: version_cache_array_rows( $t_project_ids ); The problem actually is in core/version_api.php, function version_get_all_rows(). Once a project version is in the cache, the parameters $p_released, $p_obsolete and $p_inherit are not considered anymore, thus all versions are returned. | ||||
Tags | patch | ||||
related to | 0017145 | feedback | Need to show obsolete versions in Change Log. |
This seems to be related to 0010873. At least the quick fix is the same, and again it's core/version_api.php:version_get_all_rows() where the real fix should be done. |
|
"obsolete versions shouldn't appear on the change-log page" I'm not agree.. i think that obsolete versions have to appear on changelog page. Else why having Roadmap AND Changelog... ;) |
|
It would be nice to either have another tag to say yes to showing on the change log page, or have multiple pages generated, .. or set a date limit or version count limit. The changelog page can appear empty if your php memory is too low and the version data is too great (bugs.scribus.net changelog) |
|
Better to add some pagination. |
|
I'll have to double check the code, but I believe our intention for this feature was to hide the version from the change log since it is so old. There could be other uses of this flag, but I believe this was the only / main one. If there is a desire to still keep it in the change log, then don't mark it as obsolete. I don't believe we need another flag. |
|
I update my old mantis to 1.2.19 and I discover this feature drawback. :/ Why you do that ? I am agree with Lapinkiller, I think that obsolete versions have to appear on changelog page. Please return on the first idea and show in changelog all version. |
|
I've just installed version 1.2.19 and I'd like to see all the versions in the changelog. I've modified line 157 of FROM TO |
|
I'm sorry I missed the filename: I've modified line 157 of changelog_page.php |
|
Hi Guys it works setting the parameters as follow: because with this |
|
While the fix restores the changelog page functionality as it was intended, I believe we should consider the fact that some people want to display obsolete versions too. To allow that, the Changelog page should offer some basic filtering ability. |
|
I will leave it for one of the motivated users to open a new bug report and provide a good explanation of why we would need to include obsolete versions in changelog and why wouldn't we achieve that by unmarking them as obsolete. Is it a requirement to remove the version from version drop downs but have it appear in the changelog? If there is a compelling reason, then we can consider options like a "Include in Changelog flag" for each version, or a configuration option that decides whether "obsolete" should show up in changelog or not. |
|
|
|
Why can't you make it as an option in Mantis ? |
|
@Lapinkiller and other interested in seeing Obsolete versions in Changelog, please continue the discussion in 0017145
This is more or less what I'm suggesting (see 0011604:0054891, 0017145:0054913) |
|