View Issue Details

WikiRelated ChangesetsJump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0011270mantisbtdb oraclepublic2009-12-07 13:592015-03-16 19:19
Reporterbob Assigned Todregad  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0rc2 
Target Version1.3.0-beta.1Fixed in Version1.3.0-beta.1 
Summary0011270: db_insert_id is wrong for Oracle
Description

Query to select sequence currval is wrong for Oracle

Steps To Reproduce

Try to create a bug, bug_text_id will be 0.

Additional Information

Rewrite db_insert_db to be

function db_insert_id( $p_table = null, $p_field = "id" ) {
global $g_db;

$t_db_type = config_get_global( 'db_type' );

if ( isset($p_table) && ($t_db_type = 'oci8')) {
    $query = "SELECT SEQ_".$p_table.".currval from dual";
    $result = db_query( $query );
    return db_result($result);
}

if( isset( $p_table ) && db_is_pgsql() ) {
    $query = "SELECT currval('" . $p_table . "_" . $p_field . "_seq')";
    $result = db_query_bound( $query );
    return db_result( $result );
}
return $g_db->Insert_ID();

}

TagsNo tags attached.

Relationships

child of 0013227 closeddregad Oracle DB support multiple issues 

Activities

There are no notes attached to this issue.

Related Changesets

MantisBT: master 2ce60e47

2011-08-10 08:34

dregad


Details Diff		 Fix 0013227: Oracle database support (oci8)

Mantis 1.2.6 currently does not work with Oracle DB:
1. Installation:
1.1. Oracle DB autocreates PK, so index creation for same field forbidden
1.2. Oracle DB uses datetime literal format timestamp'YYYY-MM-DD HH-MI:SS'
1.3. Oracle DB don't allows altering field property NOT NULL into NOT NULL
1.4. Oracle DB max object length is 30 chars, so some index names must be reduced
1.5. Oracle DB means empty string as NULLs, so NOT NULL restriction must be disabled for some field
1.6. Oracle DB can resolve database server name through TNS, so database name cannot be required
2. General:
2.2. Direct DB query execution result accessing instead of db_fetch_array() 1.3. usage didn't works with Oracle DB
2.4. Oracle DB binds variable by name, so bind names in statement must be sorted to address them.
2.5. Oracle DB handles NULL/DEFAULT values with specific way.
2.6. Oracle DB returns NULL value as true PHP null
2.7. Oracle DB handles sequence access with specific syntax
2.8. Nothing returned by db_prepare_string() in case of oci8
2.9. Oracle DB max object length is 30 chars, so table names must be reduced
2.10. Oracle DB uses LOB literal format similar to mssql
2.11. GetRowAssoc returns empty field values with oci8, it's need to enable returning both associative and indexed arrays.

The original patch was provided by DKuranov. He reckons that this also resolves
issues 0006853, 0007644, 0010437, 0010996, 0011265, 0011270, 0011276, 0012152, 0012478

Porting to 1.3 - Conflicts:
admin/install.php
admin/schema.php
core/database_api.php
manage_tags_page.php		 Affected Issues
0006853, 0007644, 0010437, 0010996, 0011265, 0011270, 0011276, 0012152, 0012478, 0013227
mod - admin/install.php Diff File
mod - admin/schema.php Diff File
mod - core/database_api.php Diff File