Changesets: MantisBT

Search Browse Back to Index

master e0065992

2002-12-04 05:31

Julian Fitzell


Details Diff		 Added Yves Durasnel as a contributor

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1642 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/CREDITS Diff File

master 7299813c

2002-12-04 05:30

Julian Fitzell


Details Diff		 * doc/README.LDAP: correct a few typos using $t_ instead of $g_
* doc/configuration.html: change g_ldap_organisation to g_ldap_organization
* config_defaults_inc.php
(g_ldap_bind_dn): add config variable
(g_ldap_bind_passwd): add config variable
(g_ldap_organisation): removed in favour of g_ldap_organization
(g_ldap_organization): replacing g_ldap_organisation for consistency
(g_ldap_port): add config variable
* core/ldap_api.php: change g_ldap_organisation to g_ldap_organization
* core/obsolete.php: add an entry to notify that g_ldap_organisation is obsolete and g_ldap_organization is now used

I hope this is right. I originally was fixing the problem that Robert's new config options weren't initialized in the default config file. Then I noticed the two typos in the README. Then I noticed that our config option spelled organisation with an 's' but the LDAP field name (and most of the example of organizationName I could find relating to LDAP on Google spelled it with a 'z'.

If anyone objects, I can revert this. I wouldn't normally rename a variable name because of an alternate spelling but this seems to be a case where we're not using what everyone else uses in this context.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1641 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - config_defaults_inc.php Diff File
mod - doc/configuration.html Diff File
mod - core/obsolete.php Diff File
mod - core/ldap_api.php Diff File
mod - doc/README.LDAP Diff File

master dc57aff4

2002-12-04 05:27

Julian Fitzell


Details Diff		 * core/print_api.php
(print_project_user_option_list): renamed to print_project_access_levels_option_list()
(print_project_access_levels_option_list): new name for print_project_user_option_list()
* manage_user_page.php: change call from print_project_user_option_list() to print_project_access_levels_option_list()
* proj_user_menu_page.php: change call from print_project_user_option_list() to print_project_access_levels_option_list()

This is part of a patch from Yves Durasnel <yves@durasnel.com>.

This function was poorly named and he was adding a function that really wanted the name this function used to use.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1640 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - manage_user_page.php Diff File
mod - proj_user_menu_page.php Diff File
mod - core/print_api.php Diff File

master a2e8c50d

2002-12-04 03:05

Julian Fitzell


Details Diff		 Add code throughout the system to exercise the custom fields API. It is currently all blocked off with if checks on the config variable 'use_experimental_custom_fields' so make sure to set that to ON in your config file if you want to play with it.

This patch is from Christian Mayer <Christian.Mayer@hexal.de>

I've reviewed it to make sure it doesn't do anything nasty to existing code and I'm committing it now because I think it will be easier to fix things and make comments when it's in CVS.

I apologize for the formatting fixes and helper_alternate_class() calls added in the same patch, I'm too tired to put in the effort to pull them out into seperate commits.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1639 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - constant_inc.php Diff File
mod - lang/strings_german.txt Diff File
mod - manage_proj_custom_field_update.php Diff File
mod - manage_proj_custom_field_add_existing.php Diff File
mod - bug_update_page.php Diff File
mod - bug_report.php Diff File
mod - print_bug_page.php Diff File
mod - bug_report_advanced_page.php Diff File
mod - bug_update_advanced_page.php Diff File
mod - bug_view_page.php Diff File
mod - bug_view_advanced_page.php Diff File
mod - doc/custom_fields.txt Diff File
mod - print_all_bug_page_word.php Diff File
mod - core/custom_field_api.php Diff File
mod - bug_update.php Diff File
mod - manage_proj_custom_field_add_new.php Diff File
mod - config_defaults_inc.php Diff File
mod - bug_report_page.php Diff File
mod - manage_proj_edit_page.php Diff File
mod - lang/strings_english.txt Diff File
mod - manage_proj_custom_field_edit_page.php Diff File

master bee502de

2002-12-04 01:15

Julian Fitzell


Details Diff		 Fix line endings in all files

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1638 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - css/default.css Diff File
mod - graphs/graph_reported_by_me.php Diff File
mod - admin/css/core.php Diff File
mod - core/utility_api.php Diff File
mod - manage_proj_custom_field_add_new.php Diff File
mod - admin/css/index.php Diff File
mod - graphs/graph_by_severity.php Diff File
mod - manage_proj_custom_field_add_existing.php Diff File
mod - manage_proj_custom_field_remove.php Diff File
mod - graphs/graph_by_category.php Diff File
mod - admin/css/css_inc.php Diff File
mod - graphs/graph_assigned_to_me.php Diff File
mod - admin/css/css_view.php Diff File
mod - doc/installation.html Diff File
mod - graphs/graph_by_daily_delta.php Diff File
mod - manage_proj_custom_field_update.php Diff File
mod - graphs/graph_by_release_delta.php Diff File
mod - graphs/graph_by_cumulative.php Diff File
mod - graphs/graph_by_severity_status.php Diff File
mod - admin/css/view_inc.php Diff File
mod - manage_proj_custom_field_edit_page.php Diff File
mod - manage_proj_custom_field_delete.php Diff File

master 9468ae9a

2002-12-03 22:18

Julian Fitzell


Details Diff		 * ldap_api.php
(ldap_has_group): change some "" to ''

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1637 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/ldap_api.php Diff File

master 47dc3c25

2002-12-03 22:16

Julian Fitzell


Details Diff		 * constant_inc.php: add some errors for LDAP stuff
* core/authentication_api.php
(auth_does_password_match): call ldap_authenticate() for ldap auth
* core/ldap_api.php: rewrite of ldap api
* doc/README.LDAP: update example config settings
* lang/strings_english.txt: add strings for the new LDAP errors

This is a rewrite of the LDAP api by Robert Foster <rfoster@mountainvisions.com.au>

I cleaned up quite a few things (mostly variable names and spacing) in ldap_api before committing and this hasn't been tested by me since I don't use LDAP. So if I broke it, patches welcome! :)

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1636 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/ldap_api.php Diff File
mod - constant_inc.php Diff File
mod - core/authentication_api.php Diff File
mod - doc/README.LDAP Diff File
mod - lang/strings_english.txt Diff File

master da0464ca

2002-12-03 19:58

Julian Fitzell


Details Diff		 * README.LDAP: change to unix line endings

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1635 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/README.LDAP Diff File

master 862c96ea

2002-11-30 16:27

Julian Fitzell


Details Diff		 * print_api.php
(print_user): use user_api functions to get name and email to make use of caching
(print_user_with_subject): use user_api functions to get name and email to make use of caching

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1634 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/print_api.php Diff File

master 008b25f1

2002-11-30 16:15

Julian Fitzell


Details Diff		 * string_api.php
(string_process_bug_link): don't force a space when replacing, use whatever whitespace we (optionally) matched

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1633 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/string_api.php Diff File

master 88196b3d

2002-11-30 16:11

Julian Fitzell


Details Diff		 * string_api.php
(string_process_bug_link): include the title attribute with the bug's description

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1632 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/string_api.php Diff File

master ca6851f0

2002-11-29 11:46

Julian Fitzell


Details Diff		 * bug_api.php
(bug_assign): flush the bug cache before sending the email, otherwise the handler is wrong
(bug_update_date): add a call to flush the bug data after updating the date

Thanks to Jean-Francois Travers <jean-francois.travers2@fr.thalesgroup.com> for pointing out the first problem

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1631 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/bug_api.php Diff File

master 15e012ed

2002-11-27 20:23

Julian Fitzell


Details Diff		 * history_api.php
(history_get_events_array):
+ check if handler_id is 0 (unassigned) before asking for the username
+ use user_get_name() instead of user_get_field() since it handles users that have been deleted
+ reformat the switch statement for consistency while I'm here

Thanks to Andre Eisenbach for the original patch and bug report

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1630 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/history_api.php Diff File

master 886b1111

2002-11-27 00:12

Julian Fitzell


Details Diff		 * CREDITS: Victor and I are administrators so we might as well indicate that so people know who to look for

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1629 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/CREDITS Diff File

master 0c839ece

2002-11-26 23:27

Julian Fitzell


Details Diff		 * CREDITS: add all the people I've taken patches from and credited in commit logs since September

gotta keep up to date on this in the future

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1628 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - doc/CREDITS Diff File

master a474d294

2002-11-26 22:07

Julian Fitzell


Details Diff		 * core/API.php: add line to load new utility_api file
* core/helper_api.php: remove some functions and move them to utility_api.php
* core/project_api.php: rename uses of helper_terminate_directory_path() to terminate_directory_path() since it is no longer in the helper_api
* core/utility_api.php: new file to hold utility functions needed by all APIs

I added a Utility API which contains little functions that need to be available to all APIs (and therefore do not have dependcies on any other APIs themselves). These are the types of little functions that do little conversions or things that should be in php but aren't, etc.

This was needed to make the is_blank() change work, otherwise there was a an ugly dependency that pushed helper_api and print_api above nearly everything else. I think helper_api needs to come after base APIs like DB and config, but before most other ones (as it is now).

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1627 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/project_api.php Diff File
mod - core/helper_api.php Diff File
mod - core/API.php Diff File
add - core/utility_api.php Diff File

master c7ceb3d2

2002-11-26 21:45

Julian Fitzell


Details Diff		 Replace all instances of empty() with our new function called is_blank().

empty() is a horrid function which isn't intended for checking strings. It is intended for checking whether a variable is unset or false (or rather anything that == false, which includes 0 and ''). In every case, as far as we can tell, we are not checking for this but rather for whether the string contains information. So this function first performs trim() on the string and then checks whether the length is 0.

The patch was submitted by Robert Foster <rfoster@mountainvisions.com.au> at my request.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1626 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/icon_api.php Diff File
mod - core/filter_api.php Diff File
mod - manage_proj_cat_add.php Diff File
mod - core/file_api.php Diff File
mod - bug_view_page.php Diff File
mod - manage_page.php Diff File
mod - bug_update.php Diff File
mod - bugnote_add.php Diff File
mod - login_page.php Diff File
mod - account_update.php Diff File
mod - core/project_api.php Diff File
mod - core/html_api.php Diff File
mod - manage_user_create.php Diff File
mod - manage_proj_ver_add.php Diff File
mod - signup.php Diff File
mod - print_all_bug_page.php Diff File
mod - core/access_api.php Diff File
mod - print_all_bug_page_excel.php Diff File
mod - manage_proj_attribute_add.php Diff File
mod - core/email_api.php Diff File
mod - core/lang_api.php Diff File
mod - core/print_api.php Diff File
mod - set_project.php Diff File
mod - bug_view_advanced_page.php Diff File
mod - print_all_bug_page_word.php Diff File
mod - account_prefs_inc.php Diff File
mod - manage_proj_attribute_update.php Diff File

master 9c7bbf35

2002-11-26 21:42

Julian Fitzell


Details Diff		 * helper_api.php
(is_blank): add comment, rename parameters, remove isset() check since we don't see the need for doing that here, lowercase TRUE and FALSE

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1625 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/helper_api.php Diff File

master 87789de0

2002-11-25 03:06

Julian Fitzell


Details Diff		 some work from Christian on custom fields

I cleaned it up a bit though I haven't finished reviewing the newly added files

Everything important should be prevented from loading unless you set the appropriate flag in your config file (see the bottom of config_defaults)

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1624 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/custom_field_api.php Diff File
mod - manage_proj_edit_page.php Diff File
add - manage_proj_custom_field_edit_page.php Diff File
mod - constant_inc.php Diff File
add - manage_proj_custom_field_add_existing.php Diff File
add - manage_proj_custom_field_add_new.php Diff File
mod - lang/strings_german.txt Diff File
mod - core/API.php Diff File
mod - lang/strings_english.txt Diff File
add - manage_proj_custom_field_update.php Diff File
mod - config_defaults_inc.php Diff File
add - manage_proj_custom_field_delete.php Diff File
add - manage_proj_custom_field_remove.php Diff File

master 19ba68dc

2002-11-24 15:43

Julian Fitzell


Details Diff		 * bug_api.php
(bug_create):
+ move the check for empty fields below the variable cleaning so the cleaning code is all kept together
+ use new is_blank() helper function instead of empty()
(bug_update):
+ use new is_blank() helper function instead of empty()
* helper_api.php
(is_blank): new function to be used instead of empty(). it actually works with "0" and does the trimming for you

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1623 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/bug_api.php Diff File
mod - core/helper_api.php Diff File

master 5080964f

2002-11-24 15:25

Julian Fitzell


Details Diff		 * bug_api.php
(bug_update): add calls to clear the bug cache and bug text cache after updating

Odd... I thought I committed this but just found it in my WCOdd... I thought I committed this but just found it in my WC

This was a fix, half of which was provided by Jean-Francois <jean-francois.travers2@fr.thalesgroup.com> that was causing out of date cached data to be used after modifying a bug

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1622 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/bug_api.php Diff File

master 8835274f

2002-11-19 00:31

vboctor


Details Diff		 Fixed 2717: Where a bug could be submitted or update to have empty summary /
description fields. The fix included added validation in bug_create() and
bug_update() to reject submits/updates with empty trim(summary) or
trim(description).

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1621 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/bug_api.php Diff File

master 77e39033

2002-11-18 16:24

Julian Fitzell


Details Diff		 DOH! wrong file endings on this file... converting it to *nix line endings

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1620 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - core/custom_field_api.php Diff File

master effa61d9

2002-11-16 11:06

Julian Fitzell


Details Diff		 fix error when reporting without submitting a file (in some versions anyway) where tmp_name was set to 'none' so the =='' check didn't work

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1619 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - bug_report.php Diff File

master b08548ee

2002-11-12 22:58

Julian Fitzell


Details Diff		 * constant_inc.php: add ANYBODY and NOBODY to the access levels and replaces spaces with tabs everywhere
* lang/strings_english.txt: new error for missing custom field
* core/custom_field_api.php: new API file (in progress)

Commit intial work on custom field api.

Christian got the ball rolling, Victor and I reviewed it through several iterations. Though my intention was to simply do a quick review and check this in, doing so made me think about several things and I made some changes along the way. We can carry on from here as a base point.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@1618 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
mod - lang/strings_english.txt Diff File
mod - constant_inc.php Diff File
add - core/custom_field_api.php Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 644 645 646 647 648 649 650 ... 700 ... 704 705 706  Next  Last