Changesets: MantisBT
|
master-1.2.x 802bfcfc 2010-11-24 12:34 Damien Regad Committer: dhx Details Diff |
Fix 0012167: Improved LDAP error handling and logging Created a new ldap_log_error function that will call log_event with the code and description of the last LDAP error. This is used after each failed call to a PHP ldap function. Improved the error handling of PHP ldap calls, some error cases were not covered Signed-off-by: David Hicks <d@hx.id.au> |
Affected Issues 0012167 |
|
| mod - core/ldap_api.php | Diff File | ||
|
master e45cfb8d 2010-11-23 10:10 Damien Regad Committer: dhx Details Diff |
Fix 0012552: Periods should not be used in g_cookie_prefix Modified comment in config_defaults_inc.php to document this. The administration guide documentation has also been updated. Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0012552 |
|
| mod - config_defaults_inc.php | Diff File | ||
| mod - docbook/Admin_Guide/en-US/Configuration.xml | Diff File | ||
|
master-1.2.x e28dae6a 2010-11-23 10:10 Damien Regad Committer: dhx Details Diff |
Fix 0012552: Periods should not be used in g_cookie_prefix Modified comment in config_defaults_inc.php to document this. The administration guide documentation has also been updated. Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0012552 |
|
| mod - config_defaults_inc.php | Diff File | ||
| mod - docbook/adminguide/en/configuration.sgml | Diff File | ||
|
master 9483d52f 2010-11-22 04:46 Kirill Krasnov Committer: dhx Details Diff |
Fix 0012846: Escape translation string user tag-chars such Russian <Метки> Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0012846 |
|
| mod - core/print_api.php | Diff File | ||
|
master-1.2.x f190021f 2010-11-22 04:46 Kirill Krasnov Committer: dhx Details Diff |
Fix 0012846: Escape translation string user tag-chars such Russian <Метки> Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0012846 |
|
| mod - core/print_api.php | Diff File | ||
|
master a957378e 2010-11-20 13:40 Committer: dhx Details Diff |
Fix 0012547: FILE_MOVE_FAILED changed to ERROR_FILE_MOVE_FAILED There were some incorrect references to error constants that didn't exist. They must be prefixed with ERROR_. Signed-off-by: SL-Gundam <slgundam@gmail.com> Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0012547 |
|
| mod - core/file_api.php | Diff File | ||
| mod - proj_doc_update.php | Diff File | ||
|
master-1.2.x 650b8358 2010-11-20 13:40 Committer: dhx Details Diff |
Fix 0012547: FILE_MOVE_FAILED changed to ERROR_FILE_MOVE_FAILED There were some incorrect references to error constants that didn't exist. They must be prefixed with ERROR_. Signed-off-by: SL-Gundam <slgundam@gmail.com> Signed-off-by: David Hicks <hickseydr@optusnet.com.au> |
Affected Issues 0012547 |
|
| mod - proj_doc_update.php | Diff File | ||
| mod - core/file_api.php | Diff File | ||
|
master c2c95ed6 2010-11-20 00:26 Details Diff |
Fix 0012545: Refactor manage_proj_edit_page to be XHTML well formed There were a number of errors in the output from manage_proj_edit_page.php which led to XHTML parsing errors. A </form> closing tag was in the wrong place and and <input> tag was unclosed. Some minor reformatting/spacing of sections of this file has also been conducted to improve readability. |
Affected Issues 0012545 |
|
| mod - manage_proj_edit_page.php | Diff File | ||
|
master e31c91e0 2010-11-20 00:15 Details Diff |
Fix 0012545: XHTML attributes must have values Well formed XHTML requires all element attributes to have values. In the case of checkboxes and radio fields this means we need to use checked="checked". |
Affected Issues 0012545 |
|
| mod - manage_user_edit_page.php | Diff File | ||
| mod - plugins/XmlImportExport/pages/import.php | Diff File | ||
|
master 97611506 2010-11-20 00:11 Details Diff |
Fix 0012545: Escape RSS URL before outputting it to XHTML main_page.php sets an RSS URL via a <link> tag to link to the RSS feed of the latest news. The RSS URL should be escaped prior to being inserted into the XHTML output so that the output remains well formed. |
Affected Issues 0012545 |
|
| mod - core/html_api.php | Diff File | ||
|
master c75e5d3b 2010-11-20 00:05 Details Diff |
Fix 0012545: Make some corrections to custom field radio/checkbox output Commit 0fea46fcda274ba9349db6091e875bb011cf11ec refactored the output of radio and checkbox custom fields. However this refactoring introduced an error with submitting radio fields (the name attribute should not be an array). Additionally, currently selected values for the fields were not being checked automatically. The check_checked() function has been rewritten (copied from check_selected()) so they both behave the same and can accept arrays as the first parameter. |
Affected Issues 0012545 |
|
| mod - core/helper_api.php | Diff File | ||
| mod - core/cfdefs/cfdef_standard.php | Diff File | ||
|
master 374ee370 2010-11-19 23:51 Details Diff |
Fix 0012545: Escape strings used in custom enumerations before use Some of the dropdown boxes used for showing custom enumeration fields did not make an attempt to escape the administrator-specified enumeration values. Therefore a custom enumeration value of "< 1 day" for the ETA field would break the XHTML well formed output. |
Affected Issues 0012545 |
|
| mod - core/print_api.php | Diff File | ||
|
master 7161efed 2010-11-19 23:40 Details Diff |
Fix 0012545: Relationship graph output should use cmapx instead of cmap The dot utility of Graphviz has -Tcmap and -Tcmapx output options that correspond to HTML and XHTML output respectively. We should be using "cmapx" to ensure that we're outputting a valid XHTML map element. This commit also fixes incorrect permissions on graphviz_api.php (removed execute bits). |
Affected Issues 0012545 |
|
| mod - core/relationship_graph_api.php | Diff File | ||
|
master 0fea46fc 2010-11-19 23:29 Details Diff |
Fix 0012545: Refactor custom field radio/checkbox fields We should be using well formed XHTML to generate the list of radio and checkbox options for the radio and checkbox custom field types. Input elements should be properly closed. Labels should be used instead of floating text for labelling each option (this improves usability and accessibility). |
Affected Issues 0012545 |
|
| mod - core/cfdefs/cfdef_standard.php | Diff File | ||
|
master 33043bc4 2010-11-19 23:05 Details Diff |
Fix 0012545: Refactor print_timezone_option_list() This function was not producing well formed XHTML due to missing closing tags on the <optgroup> elements. It was also neglecting to send line breaks and tabs to the output engine for each option printed, causing very long lines to appear in the XHTML output. Shorter lines are easier to read through and debug. |
Affected Issues 0012545 |
|
| mod - account_prefs_inc.php | Diff File | ||
| mod - core/print_api.php | Diff File | ||
|
master cb44a76e 2010-11-19 22:49 Details Diff |
Issue 0012545: MantisGraph: refactor bug_graph_page.php bug_graph_page.php needs some refactoring to produce well formed XHTML output. It also needed some documentation updates and conversion to the newer require_* API calls. |
Affected Issues 0012545 |
|
| mod - plugins/MantisGraph/pages/bug_graph_page.php | Diff File | ||
|
master 16e9336c 2010-11-19 22:22 Details Diff |
Fix 0012545: manage_tags_page: close open <a> tag If using a hyperlink element (<a>) as a bookmark anchor then we need to ensure it is properly closed. |
Affected Issues 0012545 |
|
| mod - manage_tags_page.php | Diff File | ||
|
master c0a2944f 2010-11-19 22:18 Details Diff |
Fix 0012545: Don't use ampersands directly in href attributes Well formed XHTML doesn't allow the use of ampersands in attributes. We must therefore use & instead of &. |
Affected Issues 0012545 |
|
| mod - roadmap_page.php | Diff File | ||
| mod - core/print_api.php | Diff File | ||
| mod - bug_relationship_graph.php | Diff File | ||
| mod - core/filter_api.php | Diff File | ||
| mod - admin/check/index.php | Diff File | ||
|
master 4fc1d8b8 2010-11-19 18:53 Details Diff |
Issue 0012545: Enforce XHTML strict output for all pages served We should be using XHTML strict for the pages served up by MantisBT so that browsers can quickly ensure that the MantisBT pages are valid/don't contain errors. This will require quite a fair bit of trial and error testing from the developer end to ensure that the XHTML markup is valid on all pages. Note: this WILL cause breakages - it's meant to. This is the only way to really discover errors in the output we're sending to clients. Plugins are affected too and need to be sending XHTML strict output as well. |
Affected Issues 0012545 |
|
| mod - core/http_api.php | Diff File | ||
| mod - core/html_api.php | Diff File | ||
|
master 6ffc2de1 2010-11-19 18:44 Details Diff |
Update jQuery to 1.4.4, jQuery-UI to 1.8.6 and fix JavaScript MIME types jQuery has been updated to version 1.4.4 jQuery-UI has been updated to version 1.8.6 Additionally the javascript_config.php and javascript_translations.php files were not returning a correct JavaScript MIME type. In Firefox 4 (beta) with NoScript this was an issue because client-side MIME sniffing is disabled for security reasons. |
||
| rm - css/images/ui-anim_basic_16x16.gif | Diff | ||
| rm - css/images/ui-icons_72a7cf_256x240.png | Diff | ||
| rm - css/images/ui-bg_highlight-soft_25_ffef8f_1x100.png | Diff | ||
| rm - css/images/ui-bg_inset-soft_95_fef1ec_1x100.png | Diff | ||
| rm - css/images/ui-bg_highlight-soft_100_deedf7_1x100.png | Diff | ||
| rm - css/images/ui-bg_highlight-hard_100_f2f5f7_1x100.png | Diff | ||
| mod - javascript/jquery-ui.js | Diff File | ||
| rm - css/images/ui-bg_inset-hard_100_fcfdfd_1x100.png | Diff | ||
| rm - css/jquery-ui-1.8.2.css | Diff | ||
| rm - css/images/ui-icons_ffffff_256x240.png | Diff | ||
| rm - css/images/ui-bg_flat_55_fbec88_40x100.png | Diff | ||
| rm - css/images/ui-bg_flat_75_e8e8e8_40x100.png | Diff | ||
| rm - css/images/ui-bg_inset-hard_100_f5f8f9_1x100.png | Diff | ||
| rm - css/images/ui-icons_999999_256x240.png | Diff | ||
| rm - css/images/ui-icons_3d80b3_256x240.png | Diff | ||
| rm - css/images/ui-bg_glass_65_c8c8e8_1x400.png | Diff | ||
| rm - css/images/ui-bg_diagonals-thick_90_eeeeee_40x40.png | Diff | ||
| mod - javascript_config.php | Diff File | ||
| rm - css/images/ui-icons_217bc0_256x240.png | Diff | ||
| rm - css/images/ui-bg_glass_100_e4f1fb_1x400.png | Diff | ||
| rm - css/images/ui-bg_glass_0_c8c8e8_1x400.png | Diff | ||
| rm - css/images/ui-bg_flat_15_cd0a0a_40x100.png | Diff | ||
| rm - css/images/ui-bg_glass_85_dfeffc_1x400.png | Diff | ||
| rm - css/images/ui-bg_gloss-wave_55_5c9ccc_500x100.png | Diff | ||
| rm - css/images/ui-bg_highlight-soft_75_c8c8e8_1x100.png | Diff | ||
| rm - css/images/ui-bg_glass_55_fff9d3_1x400.png | Diff | ||
| mod - javascript/jquery.js | Diff File | ||
| rm - css/images/ui-icons_6da8d5_256x240.png | Diff | ||
| rm - css/images/ui-bg_glass_75_d0e5f5_1x400.png | Diff | ||
| rm - css/images/ui-icons_d8e7f3_256x240.png | Diff | ||
| rm - css/images/ui-bg_glass_50_3baae3_1x400.png | Diff | ||
| rm - css/images/ui-icons_469bdd_256x240.png | Diff | ||
| rm - css/images/ui-icons_f9bd01_256x240.png | Diff | ||
| mod - javascript_translations.php | Diff File | ||
| rm - css/images/ui-bg_glass_75_c8c8e8_1x400.png | Diff | ||
| rm - css/images/ui-bg_highlight-hard_70_000000_1x100.png | Diff | ||
| rm - css/images/ui-bg_glass_80_d7ebf9_1x400.png | Diff | ||
| mod - core/http_api.php | Diff File | ||
| rm - css/images/ui-icons_2694e8_256x240.png | Diff | ||
|
master 3683fac4 2010-11-19 10:08 Details Diff |
Fix 0012471: Bug formatted IDs not escaped properly for DOT relgraph Bug IDs can be pretty formatted by plugins handling the EVENT_DISPLAY_BUG_ID event. The returned pretty formatted ID may not be safe to dump directly into the DOT language script used to generate relationship graphs. Therefore we need to check for a valid format according to DOT language rules. If the format returned is invalid then we use the raw bug ID (non-padded) instead. Thanks to Jimmy Monin for reporting this issue and providing assistance. |
Affected Issues 0012471 |
|
| mod - core/relationship_graph_api.php | Diff File | ||
|
master-1.2.x c60ad8d2 2010-11-19 10:08 Details Diff |
Fix 0012471: Bug formatted IDs not escaped properly for DOT relgraph Bug IDs can be pretty formatted by plugins handling the EVENT_DISPLAY_BUG_ID event. The returned pretty formatted ID may not be safe to dump directly into the DOT language script used to generate relationship graphs. Therefore we need to check for a valid format according to DOT language rules. If the format returned is invalid then we use the raw bug ID (non-padded) instead. Thanks to Jimmy Monin for reporting this issue and providing assistance. |
Affected Issues 0012471 |
|
| mod - core/relationship_graph_api.php | Diff File | ||
|
master 5d073485 2010-11-19 09:28 Details Diff |
Improve escaping of special characters in relationship info | ||
| mod - core/relationship_api.php | Diff File | ||
|
master-1.2.x 1792dd7b 2010-11-19 09:28 Details Diff |
Improve escaping of special characters in relationship info | ||
| mod - core/relationship_api.php | Diff File | ||
|
master a14b882d 2010-11-19 08:53 Details Diff |
Fix 0012363: Billing report end date is inaccurate The strototime() function was being called incorrectly, leading to the last day of a billing report range not being included in the results. There was also an off-by-one-second mistake with calculating the timestamp denoting the end of any given day in the billing report range. Thanks to vr5 for the initial patch. |
Affected Issues 0012363 |
|
| mod - core/bugnote_api.php | Diff File | ||
