Hi,
Apologies if this is not the right forum.
The current revision system works great, but it would be cool if we had inline diffs of what changed.
I started working on a customization that adds a "View Diff" link to the bug_revision_view page. This redirects to a similar page with two drop downs where you can choose the revisions to diff.
Check the attached images for a mockup of how that would work. I'm using Mantis v1 but it would be almost the same for v2.
Can this feature be merged upstream or should I write it as a plugin instead?
It depends on php-diff to work.
Thanks!
Visual diff between revisions
Moderators: Developer, Contributor
Visual diff between revisions
- Attachments
-
- diff-access.png (141.48 KiB) Viewed 7349 times
-
- diff-page.png (146.18 KiB) Viewed 7349 times
Re: Visual diff between revisions
VCS integration is no longer part of Manis core since quite a while, but a plugin.samir wrote:Can this feature be merged upstream or should I write it as a plugin instead?
This is the right place for enhancements https://github.com/mantisbt-plugins/source-integration
Re: Visual diff between revisions
Hi atrol,
I meant a visual diff between issues revisions, not commits or other VCS stuff. Also that would be done for version 1 and version 2 of mantis.
I meant a visual diff between issues revisions, not commits or other VCS stuff. Also that would be done for version 1 and version 2 of mantis.
Re: Visual diff between revisions
Oops, I just read "The current revision system works great"samir wrote: I meant a visual diff between issues revisions
and "diff", and was completely on the wrong track as I didn't have a deeper look on your screenshot.
IMO (just talking for myself, not the whole Mantis core development team) it should be a plugin. (as a side note, plugins can also be merged upstream)samir wrote: Can this feature be merged upstream or should I write it as a plugin instead?
Feel free to start a discussion for it on https://gitter.im/mantisbt/mantisbt
This is one of the reasons why I prefer it as a plugin, as we could decide later on if we merge upstream or not.samir wrote: It depends on php-diff to work.
We would have to ship this library with Mantis. Before that, we would have to have a deeper look at this component.
I had a very short look at it, and what I don't like that much is that the project seems to be quite dead.
There is hardly any development or support the last years and the original author seems to have stopped contributing to the project https://github.com/chrisboulton/php-dif ... ntributors
Re: Visual diff between revisions
The fact that this would require third-party code made me consider creating a plugin.
Thanks atrol, I'll move the conversation to Gitter.
Thanks atrol, I'll move the conversation to Gitter.