View Issue Details

IDProjectCategoryView StatusLast Update
0009995mantisbtapi soappublic2009-01-15 11:27
Reporterrombert Assigned Tojreese  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit trunk 
Fixed in Version1.2.0a3 
Summary0009995: Unable to update version, fixed_in_version and target_version
Description

Using the git snapshot from 22/12 sending the version, target_version and fixed_in_version fields has no effect ( the value is unchanged ).

Please note that this is different from 0008284 which tracks the missing target_version field.

Tagspatch
Attached Files
9995.patch (174 bytes)   
614a615,618
>       $v_fixed_in_version = $p_issue['fixed_in_version'];
>       $v_version = $p_issue['version'];
>       $v_target_version = $p_issue['target_version'];
> 

9995.patch (174 bytes)   
0001-Fix-9995-Unable-to-update-version-fixed_in_version.patch (973 bytes)   
From ac6b019a11048644a51a9d987e52a33c1dd94637 Mon Sep 17 00:00:00 2001
From: Robert Munteanu <robert.munteanu@gmail.com>
Date: Tue, 23 Dec 2008 10:39:31 +0200
Subject: [PATCH] Fix 9995: Unable to update version, fixed_in_version and target_version

Actually extracting the version fields from the issue.
---
 api/soap/mc_issue_api.php |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/api/soap/mc_issue_api.php b/api/soap/mc_issue_api.php
index 0407aa4..b139ea2 100644
--- a/api/soap/mc_issue_api.php
+++ b/api/soap/mc_issue_api.php
@@ -612,6 +612,10 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {
 	$t_description = $p_issue['description'];
 	$t_custom_fields = $p_issue['custom_fields'];
 
+	$v_fixed_in_version = $p_issue['fixed_in_version'];
+	$v_version = $p_issue['version'];
+	$v_target_version = $p_issue['target_version'];
+
 	if( $t_reporter_id == 0 ) {
 		$t_reporter_id = $t_user_id;
 	}
-- 
1.6.0.2

0001-Fix-9995-Unable-to-update-version-fixed_in_version.v2.patch (971 bytes)   
From fe47a062761ea47774080a1217bc8e1edf11c3b8 Mon Sep 17 00:00:00 2001
From: Robert Munteanu <robert@rm.betbrain.test>
Date: Tue, 23 Dec 2008 10:39:31 +0200
Subject: [PATCH] Fix 9995: Unable to update version, fixed_in_version and target_version

Actually extracting the version fields from the issue.
---
 api/soap/mc_issue_api.php |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/api/soap/mc_issue_api.php b/api/soap/mc_issue_api.php
index 0407aa4..b139ea2 100644
--- a/api/soap/mc_issue_api.php
+++ b/api/soap/mc_issue_api.php
@@ -612,6 +612,10 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {
 	$t_description = $p_issue['description'];
 	$t_custom_fields = $p_issue['custom_fields'];
 
+	$v_fixed_in_version = $p_issue['fixed_in_version'];
+	$v_version = $p_issue['version'];
+	$v_target_version = $p_issue['target_version'];
+
 	if( $t_reporter_id == 0 ) {
 		$t_reporter_id = $t_user_id;
 	}
-- 
1.6.0.2

0001-Fix-9995-Unable-to-update-version-fixed_in_version.v3.patch (973 bytes)   
From 308c2ffde71ff7e5357765da2161d44eae5aeca3 Mon Sep 17 00:00:00 2001
From: Robert Munteanu <robert.munteanu@gmail.com>
Date: Tue, 23 Dec 2008 10:39:31 +0200
Subject: [PATCH] Fix 9995: Unable to update version, fixed_in_version and target_version

Actually extracting the version fields from the issue.
---
 api/soap/mc_issue_api.php |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/api/soap/mc_issue_api.php b/api/soap/mc_issue_api.php
index 0407aa4..b139ea2 100644
--- a/api/soap/mc_issue_api.php
+++ b/api/soap/mc_issue_api.php
@@ -612,6 +612,10 @@ function mc_issue_update( $p_username, $p_password, $p_issue_id, $p_issue ) {
 	$t_description = $p_issue['description'];
 	$t_custom_fields = $p_issue['custom_fields'];
 
+	$v_fixed_in_version = $p_issue['fixed_in_version'];
+	$v_version = $p_issue['version'];
+	$v_target_version = $p_issue['target_version'];
+
 	if( $t_reporter_id == 0 ) {
 		$t_reporter_id = $t_user_id;
 	}
-- 
1.6.0.2

Activities

rombert

rombert

2008-12-22 18:35

reporter   ~0020467

Attached trivial patch which fixes the issue by actually extracting the version fields from the issue.

rombert

rombert

2008-12-23 03:45

reporter   ~0020471

Uploaded better (git) patch.

jreese

jreese

2008-12-25 22:40

reporter   ~0020484

Is your Git patch against a local (private?) branch? Commit 'ac6b019' is not in my tree that's a straight clone from the official repo. Could you apply your patch to the latest Git master and post again? I'd just prefer to have a formatted patch so that attribution can be maintained via git am -s.

Cheers.

rombert

rombert

2008-12-27 10:39

reporter   ~0020486

I've attached the v2 file, but I'm not sure that it will help.

I have a local git repo, cloned from master, and this patch is committed in my local repo ( the origin remote described below ).

git remote show origin

  • remote origin
    URL: git://git.mantisbt.org/mantisbt.git
    Remote branch merged with 'git pull' while on branch master
    master
    Tracked remote branches
    master master-1.0.x master-1.1.x

I have used

git format-patch origin

to create the patch. Is there another way I should generate it?

Thanks,

Robert

jreese

jreese

2008-12-27 11:27

reporter   ~0020487

Try doing a git rebase origin/master and then git format-patch origin/master. Otherwise, I`ll just need to manually edit the patch so it will apply to master.

rombert

rombert

2008-12-27 11:58

reporter   ~0020488

v3 patch attached, generated according to your instructions.

jreese

jreese

2008-12-27 22:20

reporter   ~0020489

Fix committed to 1.2.x development tree.

Related Changesets

MantisBT: master 35eba166

2008-12-23 03:39

rombert


Details Diff
Fix 0009995: Unable to update version, fixed_in_version and target_version

Actually extracting the version fields from the issue.

<span class="signoff">Signed-off-by: John Reese <jreese@leetcode.net></span>
Affected Issues
0009995
mod - api/soap/mc_issue_api.php Diff File