View Issue Details

IDProjectCategoryView StatusLast Update
0009882mantisbtpreferencespublic2009-01-15 11:26
Reportermthibeault Assigned Tovboctor  
PrioritynormalSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product Version1.2.0a2 
Fixed in Version1.2.0a3 
Summary0009882: Unknown unit for redirect and refresh delay.
Description

The units used for Redirect and Refresh Delay are defined in the code but never on the user interface. They should be as otherwise the user has no idea what those values really mean.

Tagspatch
Attached Files
Refresh_Redirect_Units.diff (1,618 bytes)   
diff --unified -r mantisbt/account_prefs_inc.php mantisbt-patch/account_prefs_inc.php
--- mantisbt/account_prefs_inc.php	2008-11-20 02:59:42.000000000 -0500
+++ mantisbt-patch/account_prefs_inc.php	2008-11-24 08:50:20.563268400 -0500
@@ -112,7 +112,7 @@
 		<?php echo lang_get( 'refresh_delay' ) ?>
 	</td>
 	<td>
-		<input type="text" name="refresh_delay" size="4" maxlength="4" value="<?php echo $t_pref->refresh_delay ?>" />
+		<input type="text" name="refresh_delay" size="4" maxlength="4" value="<?php echo $t_pref->refresh_delay ?>" /> <?php echo lang_get('in_minutes') ?>
 	</td>
 </tr>
 <tr class="row-2">
@@ -120,7 +120,7 @@
 		<?php echo lang_get( 'redirect_delay' ) ?>
 	</td>
 	<td>
-		<input type="text" name="redirect_delay" size="1" maxlength="1" value="<?php echo $t_pref->redirect_delay ?>" />
+		<input type="text" name="redirect_delay" size="4" maxlength="1" value="<?php echo $t_pref->redirect_delay ?>" /> <?php echo lang_get('in_seconds') ?>
 	</td>
 </tr>
 <tr class="row-1">
diff --unified -r mantisbt/lang/strings_english.txt mantisbt-patch/lang/strings_english.txt
--- mantisbt/lang/strings_english.txt	2008-11-20 02:59:42.000000000 -0500
+++ mantisbt-patch/lang/strings_english.txt	2008-11-24 08:50:17.735306300 -0500
@@ -450,7 +450,9 @@
 $s_advanced_view = 'Advanced View';
 $s_advanced_update = 'Advanced Update';
 $s_refresh_delay = 'Refresh Delay';
+$s_in_minutes = '(in minutes)';
 $s_redirect_delay = 'Redirect Delay';
+$s_in_seconds = '(in seconds)';
 $s_with_minimum_severity = 'With Minimum Severity of';
 $s_bugnote_order = 'Notes Sort Order';
 $s_bugnote_order_asc = 'Ascending';
Refresh_Redirect_Units.diff (1,618 bytes)   

Activities

mthibeault

mthibeault

2008-11-24 09:08

reporter   ~0020009

I am currently unable to post a patch with the resolution for this issue. Mantis server won't let me upload a diff file.

giallu

giallu

2008-11-25 10:18

reporter   ~0020033

the upload issue is fixed now. sorry for the trouble

mthibeault

mthibeault

2008-11-25 11:19

reporter   ~0020036

Patch added. It was done against the code in Git but I still don't really understand the codification so I cannot really give an exact number. It should work anyway with latest version.

vboctor

vboctor

2008-11-26 01:18

manager   ~0020060

Thanks mthibeault, I've applied the patch with minor modifications.

Related Changesets

MantisBT: master 37ca1e45

2008-11-26 01:16

vboctor


Details Diff
Fixes 0009882: Unknown unit for redirect and refresh delay. Affected Issues
0009882
mod - account_prefs_inc.php Diff File
mod - lang/strings_english.txt Diff File
mod - docbook/adminguide/en/configuration.sgml Diff File