View Issue Details

IDProjectCategoryView StatusLast Update
0009008mantisbtintegrationpublic2009-01-15 11:27
Reportercatunda Assigned Tograngeway  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
PlatformLinux PHP 5.2.3 
Product Version1.1.1 
Target Version1.1.3Fixed in Version1.2.0a3 
Summary0009008: Segmentation Fault in core/checkin.php
Description

When a call checkin.php at svn integration the segmentation fault appear :(. I guess it is a PHP bug.

In custom_function_api.php arount 112 line We can see the following call:

bugnote_add( $p_issue_id, $p_comment, 0, VS_PRIVATE == config_get( 'source_control_notes_view_status' ) );

PHP lost when pass this kind of parameter:

VS_PRIVATE == config_get( 'source_control_notes_view_status' )

Additional Information

The following patch will work around this problem:

--- mantis.orig/mantis-1.1.1/core/custom_function_api.php 2007-10-13 15:36:41.000000000 -0700
+++ mantis/core/custom_function_api.php 2008-03-25 16:35:01.000000000 -0700
@@ -112,8 +112,11 @@
function custom_function_default_checkin( $p_issue_id, $p_comment, $p_file, $p_new_version, $p_fixed ) {
if ( bug_exists( $p_issue_id ) ) {
history_log_event_special( $p_issue_id, CHECKIN, $p_file, $p_new_version );

  • bugnote_add( $p_issue_id, $p_comment, 0, VS_PRIVATE == config_get( 'source_control_notes_view_status' ) );
  • $private = false;
  • if ( config_get( 'source_control_notes_view_status' == VS_PRIVATE ) ) {
  • $private = true;
  • }
  • bugnote_add( $p_issue_id, $p_comment, 0, $private );
    $t_status = config_get( 'source_control_set_status_to' );
    if ( ( OFF != $t_status ) && $p_fixed ) {
    bug_set_field( $p_issue_id, 'status', $t_status );
Tagspatch

Activities

giallu

giallu

2008-03-26 11:59

reporter   ~0017460

Reminder sent to: jreese

John, this is an easy target and looks like safe to introduce also for 1.1

I'd fix this unless your work for the SCM integration plugins is going to supersede the whole thing

jreese

jreese

2008-03-26 18:21

reporter   ~0017466

Might as well fix it in both, considering that 1.1 won't have plugins, and my source control integration likely won't be included with Mantis by default. Might as well just keep the existing functionality for those who don't need anything more.

vboctor

vboctor

2008-07-14 04:08

manager   ~0018489

I agree that we should fix this issue. I've targeted it to 1.1.x.

grangeway

grangeway

2008-11-30 12:10

reporter   ~0020158

Fixed in GIT trunk

Related Changesets

MantisBT: master 361958d2

2008-11-30 12:10

Paul Richards


Details Diff
Fix 0009008: Segmentation Fault in core/checkin.php Affected Issues
0009008
mod - core/custom_function_api.php Diff File