View Issue Details

IDProjectCategoryView StatusLast Update
0008931mantisbtrelationshipspublic2008-06-17 02:44
Reporterkosel Assigned Tojreese  
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
Product Version1.1.1 
Target Version1.1.2Fixed in Version1.1.2 
Summary0008931: Circle Relations cause roadmap to malfunction
Description

It is possible to create a triple of tickets, that are parent of each other.
this causes the roadmap to end in an endless loop

Steps To Reproduce

1.create 3 tickets
2.make each ticket parent of the next and the last ticket parent of the first.

Additional Information

roadmap_page.php
lines 184-214

TagsNo tags attached.

Activities

giallu

giallu

2008-03-01 09:21

reporter   ~0017230

Hey John, I'm just curious about how are we going to deal with this...

jreese

jreese

2008-03-01 10:31

reporter   ~0017231

I'm just curious about how are we going to deal with this...

When I orignally but the roadmay together with this functionality, I had planned to make circular hirearchies simply break the chain as soon as a circle was detected, but either I forgot to put that in, or my logic is failing. :P

Regardless, now that my final exams are over for the quarter, I'm going to try to get time to fix this and the other roadmap bugs, and get a patch into trunk and push Victor for a 1.1.2 release with a fixed roadmap.

giallu

giallu

2008-03-01 10:54

reporter   ~0017232

+1 for me, especially if the change is trivial

kosel

kosel

2008-03-01 11:39

reporter   ~0017233

whouldn't it be better to check for circle relations on creation of the relation?

giallu

giallu

2008-03-01 12:08

reporter   ~0017234

It could be wise to check how other projects (bugzilla, trac, etc) are handling such case

kosel

kosel

2008-03-06 04:06

reporter   ~0017267

Last edited: 2008-03-06 04:23

other solution of the problem:
currently tickets are displayed multiple in the roadmap, if they have multiple relations.
If you stop showing them more often than once, you would not end in that loop. (and on a roadmap i don't want to see all those small things a houndred time, that depend to 10 other items. view ticket 0008853)

suggestion: you could add a + symbol to tickets (like on a browser), to show the childs of this ticket (using ajax)

jreese

jreese

2008-03-13 11:36

reporter   ~0017327

Fix commited to 1.1.2 and 1.2.x trunk, r5106 and r5015 respectively.

Related Changesets

MantisBT: master e9800309

2008-03-13 11:22

jreese


Details Diff
Fix 0008931: Circle Relations cause roadmap to malfunction.
Roadmap and Changelog have cycle detection now.
When a cycle is detected, one element from the cycle is placed into the roadmap as if it had no parent.
The rest of the cycle is handled as normal.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@5105 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0008931
mod - changelog_page.php Diff File
mod - roadmap_page.php Diff File

MantisBT: master-1.1.x 466c8c69

2008-03-13 11:33

jreese


Details Diff
Ported Fix 0008931: Circle Relations cause roadmap to malfunction.
Roadmap and Changelog have cycle detection now.
When a cycle is detected, one element from the cycle is placed into the roadmap as if it had no parent.
The rest of the cycle is handled as normal.

git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/branches/BRANCH_1_1_0@5106 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9
Affected Issues
0008931
mod - roadmap_page.php Diff File
mod - changelog_page.php Diff File