View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0008509 | mantisbt | bugtracker | public | 2007-10-25 09:34 | 2008-05-21 02:34 |
| Reporter | seiji | Assigned To | giallu | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | X86 | OS | Gentoo Linux | ||
| Product Version | 1.1.0rc2 | ||||
| Target Version | 1.1.0rc3 | Fixed in Version | 1.1.0rc3 | ||
| Summary | 0008509: Empty Note is added when updating issue | ||||
| Description | When I updated issue with empty note and default time tracking '0:00', empty note was added. | ||||
| Steps To Reproduce |
| ||||
| Additional Information | See attached patch | ||||
| Tags | patch | ||||
| Attached Files | bug_update.php.patch (714 bytes)
Index: bug_update.php
===================================================================
RCS file: /cvsroot/mantisbt/mantisbt/bug_update.php,v
retrieving revision 1.93
diff -u -r1.93 bug_update.php
--- bug_update.php 24 Oct 2007 22:30:44 -0000 1.93
+++ bug_update.php 25 Oct 2007 13:23:16 -0000
@@ -189,8 +189,10 @@
}
}
+ $c_time_tracking = db_prepare_time( $f_time_tracking );
+
# Add a bugnote if there is one
- if ( ( !is_blank( $f_bugnote_text ) || !is_blank( $f_time_tracking ) ) && ( false == $t_bug_note_set ) ) {
+ if ( ( !is_blank( $f_bugnote_text ) || $c_time_tracking > 0 ) && ( false == $t_bug_note_set ) ) {
bugnote_add( $f_bug_id, $f_bugnote_text, $f_time_tracking, $f_private );
}
| ||||
| related to | 0007953 | closed | daryn | Time Tracking assigment lost, when changing issue status without note text |
| parent of | 0009182 | closed | daryn | Port 0008509: Empty Note is added when updating issue |
| has duplicate | 0008513 | closed | giallu | Superfluous empty note entries |
| has duplicate | 0008548 | closed | giallu | Updating issue in advanced mode adds empty notes field |
 |
This looks like a side effect of 0007953 |
|
|
For now I reverted in CVS the modification that triggered this bug. I believe a full fix for this is going to come out from the linked bug report. Feel free to add your comments there |
|
MantisBT: master-1.1.x 049be82e 2007-10-26 04:52 Details Diff |
Revert last change as it causes bug 8509 git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/branches/BRANCH_1_1_0@4668 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0008509 |
|
| mod - bug_update.php | Diff File | ||
|
MantisBT: master bda0f406 2008-04-21 13:28 Details Diff |
Fix bug 0007953, 0007971, 0008362, 0008647, 0008509 Moved checks for adding a bugnote into the bugnote add function. Added configuration option for allowing adding time tracking without bugnote text. This defaults to ON. Moved email on adding a bugnote into the bugnote add function with a parameter to specify whether an email should be sent or not. Defaults to send email. Updated calls to bugnote add to prevent sending the email in cases where an email is already being sent. git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@5187 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0007953, 0007971, 0008362, 0008509, 0008647 |
|
| mod - bugnote_add.php | Diff File | ||
| mod - config_defaults_inc.php | Diff File | ||
| mod - core/bug_api.php | Diff File | ||
| mod - api/soap/mc_issue_api.php | Diff File | ||
| mod - bug_update.php | Diff File | ||
| mod - bug_reminder.php | Diff File | ||
| mod - core/bugnote_api.php | Diff File | ||
