Maby be related to 0006217, but I find my fix better than urlencode (names are kept, only accents are removed).

Fixed using urlencode() to be consistent with other fixes lately applied to similar download pages.

Hi
I don't know what has happened, but the fix (urlencoding) seems not working any more when using Firefox.

Downloading still ok with IE, but no more with Firefox when using accentuated characters.

It's ok when I modify file_download.php and remove the test on 'MSIE'.

Any idea ?

Oops... I made a mistake.
My problem occurs only when trying to download an attached file, not when using export...

Do I need to create another bug ?

For the export problem, urlencode is always used.
So it's still ok.

For file_download.php we probably should do the same.
(Probably something has changed in Firefox).

I think the problem is that in csv_export we always URL encode, but in Firefox we only urlencode when using IE.

In file_download.php, replace:

Added Quotes (") around file name. Also in case of IE url encode the filename

# firefox seems to do fine without the urlencoding.  I am not sure if always
# urlencoding is an issue.
if ( preg_match( "/MSIE/", $_SERVER["HTTP_USER_AGENT"] ) ) {
    header( 'Content-Disposition:' . $t_disposition . ' filename="' . urlencode($t_filename) . '"' );
} else {
    header( 'Content-Disposition:' . $t_disposition . ' filename="' . $t_filename . '"' );
}

With:
header( 'Content-Disposition:' . $t_disposition . ' filename="' . urlencode($t_filename) . '"' );

Let me know, how you go.

It's exactly what I did (and was saying in 0008091:0016232).

Only leaving :

header( 'Content-Disposition:' . $t_disposition . ' filename="' . urlencode($t_filename) . '"' );

in file_download.php solves the problem with Firefox.

The fix for the file_download / firefox case is now tracked by 0008589.