You have a point. This probably will only happen for the users who copy config_defaults_inc.php to config_inc.php and then edit. When they upgrade later the config_inc.php will include the old version and hence Mantis will display the wrong version number.

We should probably move this to somewhere like core.php or something. I don't have the source handy now, so will confirm that later.

I think this would be much better as a define('MANTIS_VERSION') setting instead. This would be more consistent with the purpose, and people don't just edit core/constants_inc.php like they do the configuration.

May I suggest adding a different define like PLUGIN_API_VERSION (or whatever the purpose of the variable is in the plugins)?

That way you can target exact versions of the API, don't need to adjust stuff on the plugins when the mantis version change without canging the API and, more in general, overloading semantics in the code is usually not wise.

May I suggest adding a different define like PLUGIN_API_VERSION

I think for the most part, plugins will be more worried about targetting specific versions of Mantis to use specific features available. And since the version of Mantis would be another way of determining the plugin API version (it's not being developed independently), it seems to me a bit superfluous.

I've committed this change to both 1.1.0rc3 and 1.2.0-CVS.

Is config_get( 'mantis_version' ) still work in the next release?

deboutv: no. The preferred method is to now use the constant MANTIS_VERSION. See core/html_api.php and the Mantis footer for an example of how it is meant to be used.