View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0007995 | mantisbt | other | public | 2007-05-21 09:51 | 2012-02-24 12:00 |
Reporter | akocel | Assigned To | zakman | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | Windows | OS | XP | OS Version | SP2 |
Product Version | 1.0.5 | ||||
Fixed in Version | 1.1.0rc1 | ||||
Summary | 0007995: Confusion in product_version values due to string comparisons with == operator | ||||
Description | If your project version list contains values such as 4.1 and 4.10 Examples :
| ||||
Additional Information | I have fixed the first bug above, in core/helper_api.php, function check_selected() by using === (triple = ) operator instead of == (double =) See attached file. | ||||
Tags | patch | ||||
Attached Files | helper_api.php (10,859 bytes)
<?php # Mantis - a php based bugtracking system # Copyright (C) 2000 - 2002 Kenzaburo Ito - kenito@300baud.org # Copyright (C) 2002 - 2004 Mantis Team - mantisbt-dev@lists.sourceforge.net # This program is distributed under the terms and conditions of the GPL # See the README and LICENSE files for details # -------------------------------------------------------- # $Id: helper_api.php,v 1.62 2005/07/25 11:55:36 thraxisp Exp $ # -------------------------------------------------------- ### Helper API ### # These are miscellaneous functions # -------------------- # alternate color function # If no index is given, continue alternating based on the last index given function helper_alternate_colors( $p_index, $p_odd_color, $p_even_color ) { static $t_index = 1; if ( null !== $p_index ) { $t_index = $p_index; } if ( 1 == $t_index++ % 2 ) { return $p_odd_color; } else { return $p_even_color; } } # -------------------- # alternate classes for table rows # If no index is given, continue alternating based on the last index given function helper_alternate_class( $p_index=null, $p_odd_class="row-1", $p_even_class="row-2" ) { static $t_index = 1; if ( null !== $p_index ) { $t_index = $p_index; } if ( 1 == $t_index++ % 2 ) { return "class=\"$p_odd_class\""; } else { return "class=\"$p_even_class\""; } } # -------------------- # get the color string for the given status function get_status_color( $p_status ) { $t_status_enum_string = config_get( 'status_enum_string' ); $t_status_colors = config_get( 'status_colors' ); # This code creates the appropriate variable name # then references that color variable # You could replace this with a bunch of if... then... else # statements $t_color_str = 'closed'; $t_color = '#ffffff'; $t_arr = explode_enum_string( $t_status_enum_string ); $t_arr_count = count( $t_arr ); for ( $i=0; $i < $t_arr_count ;$i++ ) { $elem_arr = explode_enum_arr( $t_arr[$i] ); if ( $elem_arr[0] == $p_status ) { # now get the appropriate translation $t_color_str = $elem_arr[1]; break; } } if ( isset ( $t_status_colors[$t_color_str] ) ) { $t_color = $t_status_colors[$t_color_str]; } return $t_color; } # -------------------- # Given a enum string and num, return the appropriate string function get_enum_element( $p_enum_name, $p_val ) { $config_var = config_get( $p_enum_name.'_enum_string' ); $string_var = lang_get( $p_enum_name.'_enum_string' ); # use the global enum string to search $t_arr = explode_enum_string( $config_var ); $t_arr_count = count( $t_arr ); for ( $i=0; $i < $t_arr_count ;$i++ ) { $elem_arr = explode_enum_arr( $t_arr[$i] ); if ( $elem_arr[0] == $p_val ) { # now get the appropriate translation return get_enum_to_string( $string_var, $p_val ); } } return '@' . $p_val . '@'; } # -------------------- # If $p_var is not an array and is equal to $p_val then we PRINT SELECTED. # If $p_var is an array, then if any member is equal to $p_val we PRINT SELECTED. # This is used when we want to know if a variable indicated a certain # option element is selected # # If the second parameter is not given, the first parameter is compared # to the boolean value true function check_selected( $p_var, $p_val=true ) { if ( is_array( $p_var ) ) { foreach( $p_var as $p_this_var ) { # Alain Kocelniak 21/05/07 : compare strings with === to not confuse values such as "4.1" and "4.10" if ( is_string( $p_this_var ) && is_string( $p_val ) ) { if ( $p_this_var === $p_val ) { PRINT ' selected="selected" '; return ; } } else if ( $p_this_var == $p_val ) { PRINT ' selected="selected" '; return ; } } } else { # Alain Kocelniak 21/05/07 : compare strings with === to not confuse values such as "4.1" and "4.10" if ( is_string( $p_var ) && is_string( $p_val ) ) { if ( $p_var === $p_val ) { PRINT ' selected="selected" '; return ; } } else if ( $p_var == $p_val ) { PRINT ' selected="selected" '; return ; } } } # -------------------- # If $p_var and $p_val are equal to each other then we PRINT CHECKED # This is used when we want to know if a variable indicated a certain # element is checked # # If the second parameter is not given, the first parameter is compared # to the boolean value true function check_checked( $p_var, $p_val=true ) { if ( $p_var == $p_val ) { PRINT ' checked="checked" '; } } # -------------------- # Set up PHP for a long process execution # The script timeout is set based on the value of the # long_process_timeout config option. # $p_ignore_abort specified whether to ignore user aborts by hitting # the Stop button (the default is not to ignore user aborts) function helper_begin_long_process( $p_ignore_abort=false ) { $t_timeout = config_get( 'long_process_timeout' ); # silent errors or warnings reported when safe_mode is ON. @set_time_limit( $t_timeout ); ignore_user_abort( $p_ignore_abort ); return $t_timeout; } # this allows pages to override the current project settings. # This typically applies to the view bug pages where the "current" # project as used by the filters, etc, does not match the bug being viewed. $g_project_override = null; # -------------------- # Return the current project id as stored in a cookie # If no cookie exists, the user's default project is returned function helper_get_current_project() { global $g_project_override; if ( $g_project_override !== null ) { return $g_project_override; } $t_cookie_name = config_get( 'project_cookie' ); $t_project_id = gpc_get_cookie( $t_cookie_name, null ); if ( null === $t_project_id ) { $t_pref_row = user_pref_cache_row( auth_get_current_user_id(), ALL_PROJECTS, false ); if ( false === $t_pref_row ) { $t_project_id = ALL_PROJECTS; } else { $t_project_id = $t_pref_row['default_project']; } } else { $t_project_id = split( ';', $t_project_id ); $t_project_id = $t_project_id[ count( $t_project_id ) - 1 ]; } if ( !project_exists( $t_project_id ) || ( 0 == project_get_field( $t_project_id, 'enabled' ) ) || !access_has_project_level( VIEWER, $t_project_id ) ) { $t_project_id = ALL_PROJECTS; } return (int)$t_project_id; } # -------------------- # Return the current project id as stored in a cookie, in an Array # If no cookie exists, the user's default project is returned # If the current project is a subproject, the return value will include # any parent projects function helper_get_current_project_trace() { $t_cookie_name = config_get( 'project_cookie' ); $t_project_id = gpc_get_cookie( $t_cookie_name, null ); if ( null === $t_project_id ) { $t_bottom = current_user_get_pref( 'default_project' ); $t_project_id = Array( $t_bottom ); } else { $t_project_id = split( ';', $t_project_id ); $t_bottom = $t_project_id[ count( $t_project_id ) - 1 ]; } if ( !project_exists( $t_bottom ) || ( 0 == project_get_field( $t_bottom, 'enabled' ) ) || !access_has_project_level( VIEWER, $t_bottom ) ) { $t_project_id = Array( ALL_PROJECTS ); } return $t_project_id; } # -------------------- # Set the current project id (stored in a cookie) function helper_set_current_project( $p_project_id ) { $t_project_cookie_name = config_get( 'project_cookie' ); gpc_set_cookie( $t_project_cookie_name, $p_project_id, true ); return true; } # -------------------- # Clear all known user preference cookies function helper_clear_pref_cookies() { gpc_clear_cookie( config_get( 'project_cookie' ) ); gpc_clear_cookie( config_get( 'manage_cookie' ) ); } # -------------------- # Check whether the user has confirmed this action. # # If the user has not confirmed the action, generate a page which asks # the user to confirm and then submits a form back to the current page # with all the GET and POST data and an additional field called _confirmed # to indicate that confirmation has been done. function helper_ensure_confirmed( $p_message, $p_button_label ) { if (true == gpc_get_bool( '_confirmed' ) ) { return true; } if ( !php_version_at_least( '4.1.0' ) ) { global $_POST, $_GET; } html_page_top1(); html_page_top2(); # @@@ we need to improve this formatting. I'd like the text to only # be about 50% the width of the screen so that it doesn't become to hard # to read. PRINT "<br />\n<div align=\"center\">\n"; print_hr(); PRINT "\n$p_message\n"; PRINT '<form method="post" action="' . $_SERVER[ 'PHP_SELF' ] . "\">\n"; print_hidden_inputs( gpc_strip_slashes( $_POST ) ); print_hidden_inputs( gpc_strip_slashes( $_GET ) ); PRINT "<input type=\"hidden\" name=\"_confirmed\" value=\"1\" />\n"; PRINT '<br /><br /><input type="submit" class="button" value="' . $p_button_label . '" />'; PRINT "\n</form>\n"; print_hr(); PRINT "</div>\n"; html_page_bottom1(); exit; } # -------------------- # Call custom function. # # $p_function - Name of function to call (eg: do_stuff). The function will call custom_function_override_do_stuff() # if found, otherwise, will call custom_function_default_do_stuff(). # $p_args_array - Parameters to function as an array function helper_call_custom_function( $p_function, $p_args_array ) { $t_function = 'custom_function_override_' . $p_function; if ( !function_exists( $t_function ) ) { $t_function = 'custom_function_default_' . $p_function; } return call_user_func_array( $t_function, $p_args_array ); } # -------------------- function helper_project_specific_where( $p_project_id, $p_user_id = null ) { if ( null === $p_user_id ) { $p_user_id = auth_get_current_user_id(); } if ( ALL_PROJECTS == $p_project_id ) { $t_topprojects = $t_project_ids = user_get_accessible_projects( $p_user_id ); foreach ( $t_topprojects as $t_project ) { $t_project_ids = array_merge( $t_project_ids, user_get_all_accessible_subprojects( $p_user_id, $t_project ) ); } $t_project_ids = array_unique( $t_project_ids ); } else { access_ensure_project_level( VIEWER, $p_project_id ); $t_project_ids = user_get_all_accessible_subprojects( $p_user_id, $p_project_id ); array_unshift( $t_project_ids, $p_project_id ); } $t_project_ids = array_map( 'db_prepare_int', $t_project_ids ); if ( 0 == count( $t_project_ids ) ) { $t_project_filter = ' 1<>1'; } elseif ( 1 == count( $t_project_ids ) ) { $t_project_filter = ' project_id=' . $t_project_ids[0]; } else { $t_project_filter = ' project_id IN (' . join( ',', $t_project_ids ) . ')'; } return $t_project_filter; } ?> | ||||
MantisBT: master ab391ab4 2007-09-05 07:51 zakman Details Diff |
Fixed Bug # 0007995: Confusion in product_version values due to string comparisons with == operator git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@4566 <a class="text" href="/?p=mantisbt.git;a=object;h=f5dc347c">f5dc347c</a>-c33d-0410-90a0-b07cc1902cb9 |
Affected Issues 0007995 |
|
mod - core/helper_api.php | Diff File | ||
MantisBT: master 1f515b3a 2012-02-23 22:15 Details Diff |
Fix 0013937: Filter dropdown values of [any], [none], etc not saved Damien Regad <damien.regad@merckgroup.com> and Roland Becker <roland@atrol.de> reported an issue whereby filter dropdowns would always select the meta filter option of [any] by default, even if the active filter was set to another value. The cause is incorrect logic within both the check_checked and check_selected functions dating back to issue 0007995 in 2007. Documentation has been added inline to the code to clarify how these functions work and the gotcha to do with == vs. === comparisons. |
Affected Issues 0007995, 0013937 |
|
mod - core/helper_api.php | Diff File |